mirror of
https://github.com/stablyai/orca.git
synced 2026-10-07 16:02:29 +00:00
NeilandOrca
46646d7ff1
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
79 lines
3.3 KiB
TypeScript
79 lines
3.3 KiB
TypeScript
import { execFileSync } from 'node:child_process'
|
|
import { mkdtemp, rm, writeFile } from 'node:fs/promises'
|
|
import { tmpdir } from 'node:os'
|
|
import * as path from 'node:path'
|
|
import { afterEach, describe, expect, it } from 'vitest'
|
|
import { bulkStageFiles, bulkUnstageFiles, stageFile, unstageFile } from './status'
|
|
|
|
const tempRoots: string[] = []
|
|
const globNamedFile = '[k]eep.log'
|
|
const globMatchedFile = 'keep.log'
|
|
|
|
function gitLiteralPathspec(filePath: string): string {
|
|
return `:(literal)${filePath}`
|
|
}
|
|
|
|
async function createRepoWithGlobNamedFiles(): Promise<string> {
|
|
const repo = await mkdtemp(path.join(tmpdir(), 'orca-status-pathspec-'))
|
|
tempRoots.push(repo)
|
|
execFileSync('git', ['init', '-q'], { cwd: repo })
|
|
execFileSync('git', ['config', 'user.email', 'test@example.com'], { cwd: repo })
|
|
execFileSync('git', ['config', 'user.name', 'Test User'], { cwd: repo })
|
|
await writeFile(path.join(repo, globNamedFile), 'selected')
|
|
await writeFile(path.join(repo, globMatchedFile), 'keep')
|
|
execFileSync('git', ['add', gitLiteralPathspec(globNamedFile), globMatchedFile], { cwd: repo })
|
|
execFileSync('git', ['commit', '-q', '-m', 'initial'], { cwd: repo })
|
|
await writeFile(path.join(repo, globNamedFile), 'selected modified')
|
|
await writeFile(path.join(repo, globMatchedFile), 'keep modified')
|
|
return repo
|
|
}
|
|
|
|
function gitNames(repo: string, args: string[]): string[] {
|
|
const stdout = execFileSync('git', args, { cwd: repo, encoding: 'utf8' })
|
|
return stdout.split(/\r?\n/).filter(Boolean)
|
|
}
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(tempRoots.splice(0).map((root) => rm(root, { recursive: true, force: true })))
|
|
})
|
|
|
|
describe('git status pathspec literals', () => {
|
|
it('stages a tracked path with Git glob characters as one literal path', async () => {
|
|
const repo = await createRepoWithGlobNamedFiles()
|
|
|
|
await stageFile(repo, globNamedFile)
|
|
|
|
expect(gitNames(repo, ['diff', '--cached', '--name-only'])).toEqual([globNamedFile])
|
|
expect(gitNames(repo, ['diff', '--name-only'])).toEqual([globMatchedFile])
|
|
})
|
|
|
|
it('bulk stages tracked paths with Git glob characters as literal paths', async () => {
|
|
const repo = await createRepoWithGlobNamedFiles()
|
|
|
|
await bulkStageFiles(repo, [globNamedFile])
|
|
|
|
expect(gitNames(repo, ['diff', '--cached', '--name-only'])).toEqual([globNamedFile])
|
|
expect(gitNames(repo, ['diff', '--name-only'])).toEqual([globMatchedFile])
|
|
})
|
|
|
|
it('unstages a tracked path with Git glob characters as one literal path', async () => {
|
|
const repo = await createRepoWithGlobNamedFiles()
|
|
execFileSync('git', ['add', gitLiteralPathspec(globNamedFile), globMatchedFile], { cwd: repo })
|
|
|
|
await unstageFile(repo, globNamedFile)
|
|
|
|
expect(gitNames(repo, ['diff', '--cached', '--name-only'])).toEqual([globMatchedFile])
|
|
expect(gitNames(repo, ['diff', '--name-only'])).toEqual([globNamedFile])
|
|
})
|
|
|
|
it('bulk unstages tracked paths with Git glob characters as literal paths', async () => {
|
|
const repo = await createRepoWithGlobNamedFiles()
|
|
execFileSync('git', ['add', gitLiteralPathspec(globNamedFile), globMatchedFile], { cwd: repo })
|
|
|
|
await bulkUnstageFiles(repo, [globNamedFile])
|
|
|
|
expect(gitNames(repo, ['diff', '--cached', '--name-only'])).toEqual([globMatchedFile])
|
|
expect(gitNames(repo, ['diff', '--name-only'])).toEqual([globNamedFile])
|
|
})
|
|
})
|