Files
orca/src/main/pty/omp-sqlite-overlay.ts
T
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

62 lines
1.9 KiB
TypeScript

// Why: OMP creates SQLite auth/history DBs lazily under PI_CODING_AGENT_DIR.
// If Orca only mirrors files that already exist, /login writes land in a
// disposable overlay instead of the user's ~/.omp/agent store.
import { closeSync, existsSync, mkdirSync, openSync } from 'node:fs'
import { join } from 'node:path'
import { mirrorWritableFileEntry, safeRemoveTree } from './overlay-mirror'
export const OMP_PERSISTENT_SQLITE_FILES = ['agent.db'] as const
const SQLITE_SIDECAR_SUFFIXES = ['-wal', '-shm'] as const
function ensureEmptyFile(path: string): void {
closeSync(openSync(path, 'a'))
}
function mirrorOmpSqliteFile(
sourcePath: string,
overlayPath: string,
databaseName: string
): string[] {
if (!existsSync(sourcePath)) {
ensureEmptyFile(sourcePath)
}
safeRemoveTree(overlayPath)
for (const sidecarSuffix of SQLITE_SIDECAR_SUFFIXES) {
safeRemoveTree(`${overlayPath}${sidecarSuffix}`)
}
mirrorWritableFileEntry(sourcePath, overlayPath)
const mirroredEntries = [databaseName]
if (process.platform === 'win32') {
// Why: Windows hardlinks do not redirect SQLite's derived WAL filenames.
// Link sidecars too so lazy WAL writes still land in ~/.omp/agent.
for (const sidecarSuffix of SQLITE_SIDECAR_SUFFIXES) {
const sourceSidecar = `${sourcePath}${sidecarSuffix}`
const sidecarName = `${mirroredEntries[0]}${sidecarSuffix}`
ensureEmptyFile(sourceSidecar)
mirrorWritableFileEntry(sourceSidecar, `${overlayPath}${sidecarSuffix}`)
mirroredEntries.push(sidecarName)
}
}
return mirroredEntries
}
export function mirrorOmpPersistentSqliteFiles(
sourceAgentDir: string,
overlayDir: string
): string[] {
mkdirSync(sourceAgentDir, { recursive: true })
return OMP_PERSISTENT_SQLITE_FILES.flatMap((databaseName) =>
mirrorOmpSqliteFile(
join(sourceAgentDir, databaseName),
join(overlayDir, databaseName),
databaseName
)
)
}