mirror of
https://github.com/stablyai/orca.git
synced 2026-09-26 08:02:38 +00:00
JinjingandOrca
33bd676644
* fix(github): align PR source and review head origin * fix(github): pin number-based work item open to the repo source preference Open-by-number and details still ran the upstream-first multi-candidate PR probe, so a fork and its upstream sharing a PR number opened different PRs than the list and start-point paths did once #10677 pinned those to origin. Thread repo.issueSourcePreference through dispatchWorkItem, getWorkItemDetails, getRepoWorkItem, and getRepoWorkItemDetails. getWorkItemByOwnerRepo is left alone: explicit owner/repo already pins identity. auto/upstream/undefined keep the multi-candidate probe. Co-authored-by: Orca <help@stably.ai> * test(github): enforce origin preference in review head origin resolution The explicit origin preference must short-circuit before any identity probe, so no remote queries should occur. Add validation to reject unexpected remotes and tighten the test assertion to verify no remote get-url calls happen at all. * fix(github): enforce origin preference in issue open-by-number lookup listWorkItems and getWorkItem must share preference so origin/upstream toggles cannot disagree. Explicit origin preference now fail-closes when origin identity is unresolved (no bare-lookup fallback), matching the PR candidate resolution rule. --------- Co-authored-by: Orca <help@stably.ai>
88 lines
3.2 KiB
TypeScript
88 lines
3.2 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest'
|
|
import { dispatchWorkItem } from './github-work-item-args'
|
|
|
|
describe('dispatchWorkItem', () => {
|
|
const repo = { path: '/r', connectionId: null }
|
|
|
|
it('rejects non-integer numbers', () => {
|
|
const fn = vi.fn()
|
|
expect(dispatchWorkItem({ repoPath: '/r', number: 1.5 }, repo, fn)).toBeNull()
|
|
expect(fn).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('rejects numbers < 1', () => {
|
|
const fn = vi.fn()
|
|
expect(dispatchWorkItem({ repoPath: '/r', number: 0 }, repo, fn)).toBeNull()
|
|
expect(dispatchWorkItem({ repoPath: '/r', number: -5 }, repo, fn)).toBeNull()
|
|
expect(fn).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('rejects non-number values coming across IPC', () => {
|
|
const fn = vi.fn()
|
|
// Renderer can send anything; simulate a string that slips past TS.
|
|
const bogus = { repoPath: '/r', number: 'abc' as unknown as number }
|
|
expect(dispatchWorkItem(bogus, repo, fn)).toBeNull()
|
|
expect(fn).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('coerces unknown type values to undefined', async () => {
|
|
const fn = vi.fn().mockResolvedValue(null)
|
|
const bogus = {
|
|
repoPath: '/r',
|
|
number: 42,
|
|
type: 'bogus' as unknown as 'issue' | 'pr'
|
|
}
|
|
await dispatchWorkItem(bogus, repo, fn)
|
|
expect(fn).toHaveBeenCalledWith('/r', 42, undefined, null, undefined, undefined)
|
|
})
|
|
|
|
it('passes valid issue type through', async () => {
|
|
const fn = vi.fn().mockResolvedValue(null)
|
|
await dispatchWorkItem({ repoPath: '/r', number: 42, type: 'issue' }, repo, fn)
|
|
expect(fn).toHaveBeenCalledWith('/r', 42, 'issue', null, undefined, undefined)
|
|
})
|
|
|
|
it('passes valid pr type through', async () => {
|
|
const fn = vi.fn().mockResolvedValue(null)
|
|
await dispatchWorkItem({ repoPath: '/r', number: 42, type: 'pr' }, repo, fn)
|
|
expect(fn).toHaveBeenCalledWith('/r', 42, 'pr', null, undefined, undefined)
|
|
})
|
|
|
|
it('passes SSH connection context through', async () => {
|
|
const fn = vi.fn().mockResolvedValue(null)
|
|
await dispatchWorkItem(
|
|
{ repoPath: '/remote/repo', number: 42, type: 'issue' },
|
|
{ path: '/remote/repo', connectionId: 'ssh-1' },
|
|
fn
|
|
)
|
|
expect(fn).toHaveBeenCalledWith('/remote/repo', 42, 'issue', 'ssh-1', undefined, undefined)
|
|
})
|
|
|
|
it('pins the repo issue source preference for open-by-number', async () => {
|
|
const fn = vi.fn().mockResolvedValue(null)
|
|
await dispatchWorkItem(
|
|
{ repoPath: '/r', number: 42, type: 'pr' },
|
|
{ path: '/r', connectionId: null, issueSourcePreference: 'origin' },
|
|
fn,
|
|
{ wslDistro: 'Ubuntu' }
|
|
)
|
|
expect(fn).toHaveBeenCalledWith('/r', 42, 'pr', null, { wslDistro: 'Ubuntu' }, 'origin')
|
|
})
|
|
|
|
it('leaves upstream and auto preferences on the multi-candidate probe', async () => {
|
|
const fn = vi.fn().mockResolvedValue(null)
|
|
await dispatchWorkItem(
|
|
{ repoPath: '/r', number: 7, type: 'pr' },
|
|
{ path: '/r', connectionId: null, issueSourcePreference: 'upstream' },
|
|
fn
|
|
)
|
|
await dispatchWorkItem(
|
|
{ repoPath: '/r', number: 7, type: 'pr' },
|
|
{ path: '/r', connectionId: null, issueSourcePreference: 'auto' },
|
|
fn
|
|
)
|
|
expect(fn).toHaveBeenNthCalledWith(1, '/r', 7, 'pr', null, undefined, 'upstream')
|
|
expect(fn).toHaveBeenNthCalledWith(2, '/r', 7, 'pr', null, undefined, 'auto')
|
|
})
|
|
})
|