mirror of
https://github.com/stablyai/orca.git
synced 2026-09-26 08:02:38 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
230 lines
7.1 KiB
TypeScript
230 lines
7.1 KiB
TypeScript
import { homedir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import type { SFTPWrapper } from 'ssh2'
|
|
import type { AgentHookInstallState, AgentHookInstallStatus } from '../../shared/agent-hook-types'
|
|
import {
|
|
buildManagedCommandHook,
|
|
createManagedCommandMatcher,
|
|
getSharedManagedScriptPath,
|
|
readHooksJson,
|
|
removeManagedCommands,
|
|
wrapPosixHookCommand,
|
|
wrapWindowsHookCommand,
|
|
writeHooksJson,
|
|
writeManagedScript,
|
|
type HookDefinition
|
|
} from '../agent-hooks/installer-utils'
|
|
import {
|
|
readHooksJsonRemote,
|
|
writeHooksJsonRemote,
|
|
writeManagedScriptRemote
|
|
} from '../agent-hooks/installer-utils-remote'
|
|
import { buildCommandCodeManagedScript } from './command-code-managed-script'
|
|
|
|
const COMMAND_CODE_EVENTS = [
|
|
{
|
|
eventName: 'PreToolUse',
|
|
definition: { matcher: '.*', hooks: [{ type: 'command', command: '' }] }
|
|
},
|
|
{
|
|
eventName: 'PostToolUse',
|
|
definition: { matcher: '.*', hooks: [{ type: 'command', command: '' }] }
|
|
},
|
|
{ eventName: 'Stop', definition: { hooks: [{ type: 'command', command: '' }] } }
|
|
] as const
|
|
|
|
function getConfigPath(): string {
|
|
return join(homedir(), '.commandcode', 'settings.json')
|
|
}
|
|
|
|
function getManagedScriptFileName(): string {
|
|
return process.platform === 'win32' ? 'command-code-hook.cmd' : 'command-code-hook.sh'
|
|
}
|
|
|
|
function getManagedScriptPath(): string {
|
|
return getSharedManagedScriptPath(getManagedScriptFileName())
|
|
}
|
|
|
|
function getManagedCommand(scriptPath: string): string {
|
|
return process.platform === 'win32'
|
|
? wrapWindowsHookCommand(scriptPath)
|
|
: wrapPosixHookCommand(scriptPath)
|
|
}
|
|
|
|
function buildInstalledConfig(
|
|
config: NonNullable<ReturnType<typeof readHooksJson>>,
|
|
command: string,
|
|
scriptFileName: string
|
|
): void {
|
|
const nextHooks = { ...config.hooks }
|
|
const isManagedCommand = createManagedCommandMatcher(scriptFileName)
|
|
const managedEvents = new Set<string>(COMMAND_CODE_EVENTS.map((event) => event.eventName))
|
|
|
|
// Why: Orca owns only command-code-hook.* entries. Sweep retired managed
|
|
// events while preserving user-authored Command Code hooks.
|
|
for (const [eventName, definitions] of Object.entries(nextHooks)) {
|
|
if (managedEvents.has(eventName) || !Array.isArray(definitions)) {
|
|
continue
|
|
}
|
|
const cleaned = removeManagedCommands(definitions, isManagedCommand)
|
|
if (cleaned.length === 0) {
|
|
delete nextHooks[eventName]
|
|
} else {
|
|
nextHooks[eventName] = cleaned
|
|
}
|
|
}
|
|
|
|
for (const event of COMMAND_CODE_EVENTS) {
|
|
const current = Array.isArray(nextHooks[event.eventName]) ? nextHooks[event.eventName] : []
|
|
const cleaned = removeManagedCommands(current, isManagedCommand)
|
|
const definition: HookDefinition = {
|
|
...event.definition,
|
|
hooks: [buildManagedCommandHook(command)]
|
|
}
|
|
nextHooks[event.eventName] = [...cleaned, definition]
|
|
}
|
|
|
|
config.hooks = nextHooks
|
|
}
|
|
|
|
export class CommandCodeHookService {
|
|
getStatus(): AgentHookInstallStatus {
|
|
const configPath = getConfigPath()
|
|
const scriptPath = getManagedScriptPath()
|
|
const config = readHooksJson(configPath)
|
|
if (!config) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath,
|
|
managedHooksPresent: false,
|
|
detail: 'Could not parse Command Code settings.json'
|
|
}
|
|
}
|
|
|
|
const command = getManagedCommand(scriptPath)
|
|
const missing: string[] = []
|
|
let presentCount = 0
|
|
for (const event of COMMAND_CODE_EVENTS) {
|
|
const definitions = Array.isArray(config.hooks?.[event.eventName])
|
|
? config.hooks![event.eventName]!
|
|
: []
|
|
const hasCommand = definitions.some((definition) =>
|
|
(definition.hooks ?? []).some((hook) => hook.command === command)
|
|
)
|
|
if (hasCommand) {
|
|
presentCount += 1
|
|
} else {
|
|
missing.push(event.eventName)
|
|
}
|
|
}
|
|
|
|
const managedHooksPresent = presentCount > 0
|
|
let state: AgentHookInstallState
|
|
let detail: string | null
|
|
if (missing.length === 0) {
|
|
state = 'installed'
|
|
detail = null
|
|
} else if (presentCount === 0) {
|
|
state = 'not_installed'
|
|
detail = null
|
|
} else {
|
|
state = 'partial'
|
|
detail = `Managed hook missing for events: ${missing.join(', ')}`
|
|
}
|
|
return { agent: 'command-code', state, configPath, managedHooksPresent, detail }
|
|
}
|
|
|
|
install(): AgentHookInstallStatus {
|
|
const configPath = getConfigPath()
|
|
const scriptPath = getManagedScriptPath()
|
|
const config = readHooksJson(configPath)
|
|
if (!config) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath,
|
|
managedHooksPresent: false,
|
|
detail: 'Could not parse Command Code settings.json'
|
|
}
|
|
}
|
|
|
|
buildInstalledConfig(config, getManagedCommand(scriptPath), getManagedScriptFileName())
|
|
writeManagedScript(scriptPath, buildCommandCodeManagedScript())
|
|
writeHooksJson(configPath, config)
|
|
return this.getStatus()
|
|
}
|
|
|
|
async installRemote(sftp: SFTPWrapper, remoteHome: string): Promise<AgentHookInstallStatus> {
|
|
const home = remoteHome.replace(/\/$/, '')
|
|
const remoteConfigPath = `${home}/.commandcode/settings.json`
|
|
const remoteScriptPath = `${home}/.orca/agent-hooks/command-code-hook.sh`
|
|
try {
|
|
const config = await readHooksJsonRemote(sftp, remoteConfigPath)
|
|
if (!config) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath: remoteConfigPath,
|
|
managedHooksPresent: false,
|
|
detail: 'Could not parse remote Command Code settings.json'
|
|
}
|
|
}
|
|
|
|
buildInstalledConfig(config, wrapPosixHookCommand(remoteScriptPath), 'command-code-hook.sh')
|
|
await writeManagedScriptRemote(sftp, remoteScriptPath, buildCommandCodeManagedScript('posix'))
|
|
await writeHooksJsonRemote(sftp, remoteConfigPath, config)
|
|
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'installed',
|
|
configPath: remoteConfigPath,
|
|
managedHooksPresent: true,
|
|
detail: null
|
|
}
|
|
} catch (err) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath: remoteConfigPath,
|
|
managedHooksPresent: false,
|
|
detail: err instanceof Error ? err.message : String(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
remove(): AgentHookInstallStatus {
|
|
const configPath = getConfigPath()
|
|
const config = readHooksJson(configPath)
|
|
if (!config) {
|
|
return {
|
|
agent: 'command-code',
|
|
state: 'error',
|
|
configPath,
|
|
managedHooksPresent: false,
|
|
detail: 'Could not parse Command Code settings.json'
|
|
}
|
|
}
|
|
|
|
const nextHooks = { ...config.hooks }
|
|
const isManagedCommand = createManagedCommandMatcher(getManagedScriptFileName())
|
|
for (const [eventName, definitions] of Object.entries(nextHooks)) {
|
|
if (!Array.isArray(definitions)) {
|
|
continue
|
|
}
|
|
const cleaned = removeManagedCommands(definitions, isManagedCommand)
|
|
if (cleaned.length === 0) {
|
|
delete nextHooks[eventName]
|
|
} else {
|
|
nextHooks[eventName] = cleaned
|
|
}
|
|
}
|
|
|
|
config.hooks = nextHooks
|
|
writeHooksJson(configPath, config)
|
|
return this.getStatus()
|
|
}
|
|
}
|
|
|
|
export const commandCodeHookService = new CommandCodeHookService()
|