mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 16:03:26 +00:00
Jinjing
144df671ab
* Automatically link newly created pull requests/merge requests to the worktree using the provider-specific metadata key (e.g., linkedPR, linkedGitLabMR) and persist the submitted base ref. * Prefer worktree-specific base ref returned by worktree.show when resolving the comparison base ref. * Handle metadata linking failures gracefully as a non-fatal warning without blocking the pull request creation flow.
101 lines
3.3 KiB
TypeScript
101 lines
3.3 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest'
|
|
import type { RpcClient } from '../transport/rpc-client'
|
|
import {
|
|
buildWorktreeSetHostedReviewLinkParams,
|
|
buildWorktreeSetLinkParams,
|
|
fetchWorktreeLinkedPR,
|
|
linkMobilePr
|
|
} from './mobile-pr-link'
|
|
|
|
describe('buildWorktreeSetLinkParams', () => {
|
|
it('sets linkedPR to a number when linking', () => {
|
|
expect(buildWorktreeSetLinkParams('repo42::/p', 12)).toEqual({
|
|
worktree: 'id:repo42::/p',
|
|
linkedPR: 12
|
|
})
|
|
})
|
|
|
|
it('sets linkedPR to null when unlinking', () => {
|
|
expect(buildWorktreeSetLinkParams('repo42::/p', null)).toEqual({
|
|
worktree: 'id:repo42::/p',
|
|
linkedPR: null
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('buildWorktreeSetHostedReviewLinkParams', () => {
|
|
it.each([
|
|
['github', 'linkedPR'],
|
|
['gitlab', 'linkedGitLabMR'],
|
|
['bitbucket', 'linkedBitbucketPR'],
|
|
['azure-devops', 'linkedAzureDevOpsPR'],
|
|
['gitea', 'linkedGiteaPR']
|
|
] as const)('maps %s reviews to the matching worktree field', (provider, key) => {
|
|
expect(buildWorktreeSetHostedReviewLinkParams('repo42::/p', provider, 12)).toEqual({
|
|
worktree: 'id:repo42::/p',
|
|
[key]: 12
|
|
})
|
|
})
|
|
|
|
it('includes a submitted base ref so mobile diff review refreshes against the review base', () => {
|
|
expect(
|
|
buildWorktreeSetHostedReviewLinkParams('repo42::/p', 'github', 12, {
|
|
baseRef: ' origin/release '
|
|
})
|
|
).toEqual({
|
|
worktree: 'id:repo42::/p',
|
|
baseRef: 'origin/release',
|
|
linkedPR: 12
|
|
})
|
|
})
|
|
|
|
it('does not invent a metadata field for unsupported providers', () => {
|
|
expect(buildWorktreeSetHostedReviewLinkParams('repo42::/p', 'unsupported', 12)).toEqual({
|
|
worktree: 'id:repo42::/p'
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('fetchWorktreeLinkedPR', () => {
|
|
const client = (result: unknown, okFlag = true) =>
|
|
({
|
|
sendRequest: vi.fn(async () =>
|
|
okFlag ? { ok: true, result } : { ok: false, error: { message: 'x' } }
|
|
)
|
|
}) as unknown as Pick<RpcClient, 'sendRequest'>
|
|
|
|
it('returns the linkedPR number when present', async () => {
|
|
expect(await fetchWorktreeLinkedPR(client({ worktree: { linkedPR: 12 } }), 'w')).toBe(12)
|
|
})
|
|
|
|
it('returns null when unset, null, or non-numeric', async () => {
|
|
expect(await fetchWorktreeLinkedPR(client({ worktree: {} }), 'w')).toBeNull()
|
|
expect(await fetchWorktreeLinkedPR(client({ worktree: { linkedPR: null } }), 'w')).toBeNull()
|
|
expect(await fetchWorktreeLinkedPR(client({ worktree: { linkedPR: 'x' } }), 'w')).toBeNull()
|
|
})
|
|
|
|
it('returns null when the request fails', async () => {
|
|
expect(await fetchWorktreeLinkedPR(client(null, false), 'w')).toBeNull()
|
|
})
|
|
|
|
it('returns null when the request rejects (no escaping rejection)', async () => {
|
|
const rejecting = {
|
|
sendRequest: vi.fn(async () => {
|
|
throw new Error('transport closed')
|
|
})
|
|
} as unknown as Pick<RpcClient, 'sendRequest'>
|
|
expect(await fetchWorktreeLinkedPR(rejecting, 'w')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('linkMobilePr transport rejection', () => {
|
|
it('normalizes a thrown sendRequest into { ok:false, error }', async () => {
|
|
const rejecting = {
|
|
sendRequest: vi.fn(async () => {
|
|
throw new Error('socket hung up')
|
|
})
|
|
} as unknown as Pick<RpcClient, 'sendRequest'>
|
|
expect(await linkMobilePr(rejecting, 'w', 5)).toEqual({ ok: false, error: 'socket hung up' })
|
|
})
|
|
})
|