Files
orca/src/main/computer/macos-native-provider-socket.test.ts
T
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

63 lines
1.9 KiB
TypeScript

import { EventEmitter } from 'node:events'
import { describe, expect, it, vi } from 'vitest'
const { createConnectionMock } = vi.hoisted(() => ({
createConnectionMock: vi.fn()
}))
vi.mock('net', () => ({
default: {
createConnection: createConnectionMock
}
}))
import { connectMacOSProviderSocket } from './macos-native-provider-socket'
class FakeSocket extends EventEmitter {
destroy = vi.fn()
}
describe('connectMacOSProviderSocket', () => {
it('removes socket listeners after a connection error', async () => {
vi.useFakeTimers()
try {
const socket = new FakeSocket()
createConnectionMock.mockReturnValueOnce(socket)
const promise = connectMacOSProviderSocket('/tmp/orca-computer.sock', 50)
await Promise.resolve()
expect(socket.listenerCount('error')).toBe(1)
expect(socket.listenerCount('connect')).toBe(1)
const rejection = expect(promise).rejects.toThrow(
'native macOS helper app did not open its socket'
)
socket.emit('error', new Error('ECONNREFUSED'))
await vi.advanceTimersByTimeAsync(100)
await rejection
expect(socket.destroy).toHaveBeenCalledTimes(1)
expect(socket.listenerCount('error')).toBe(0)
expect(socket.listenerCount('connect')).toBe(0)
} finally {
vi.useRealTimers()
}
})
it('destroys the pending socket and removes listeners when aborted', async () => {
const socket = new FakeSocket()
createConnectionMock.mockReturnValueOnce(socket)
const abort = new AbortController()
const promise = connectMacOSProviderSocket('/tmp/orca-computer.sock', 5_000, abort.signal)
await Promise.resolve()
abort.abort()
await expect(promise).rejects.toThrow('startup was cancelled')
expect(socket.destroy).toHaveBeenCalledTimes(1)
expect(socket.listenerCount('error')).toBe(0)
expect(socket.listenerCount('connect')).toBe(0)
})
})