Files
orca/src/main/computer/macos-native-provider-socket.ts
T
NeilandOrca 46646d7ff1 chore(lint): upgrade oxlint to 1.71 + enable 7 new rules (autofixed backlog) (#6841)
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules

Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day
minimum-release-age supply-chain guard; nothing here needs it). The
bump is a no-op on the existing config.

Enable 3 error rules (backlog autofixed to zero in this commit) and
4 warn rules (surface signal without gating CI):

error (autofixed, behavior-preserving):
- unicorn/prefer-node-protocol        (~1531 sites: bare builtin -> node:)
- typescript/no-import-type-side-effects (~36: all-inline-type -> import type)
- unicorn/no-array-reverse            (19: copy-then-reverse -> toReversed)

warn (real signal, current fires are test-only/correct):
- unicorn/no-array-fill-with-reference-type  (aliasing footgun guard)
- typescript/no-unsafe-function-type         (bans bare Function type)
- unicorn/prefer-array-flat-map              (map().flat() -> flatMap())
- unicorn/prefer-regexp-test                 (.match() in bool ctx -> .test())

mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix
ran from root and covered mobile/ too.

Verification (all green): oxlint 0 errors (root+mobile+aux configs),
oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed,
builds (electron-vite + web + cli) succeed. node: rewrites confirmed to
skip embedded SSH/CLI string payloads (AST-only); all toReversed sites
verified to operate on fresh copies or write-once locals.

* chore(lint): bump mobile oxlint to 1.71 so inherited rules parse

mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which
lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since
mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile &&
oxlint' failed to parse the new rule. Bump mobile to match root (1.71).

Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit
pass, vitest 978 passed / 0 failed.

Co-authored-by: Orca <help@stably.ai>

---------

Co-authored-by: Orca <help@stably.ai>
2026-06-29 22:38:29 -07:00

88 lines
2.4 KiB
TypeScript

import net from 'node:net'
import { RuntimeClientError } from './runtime-client-error'
export async function connectMacOSProviderSocket(
socketPath: string,
timeoutMs: number,
signal?: AbortSignal
): Promise<net.Socket> {
const deadline = Date.now() + timeoutMs
let lastError: Error | null = null
while (Date.now() < deadline && !signal?.aborted) {
try {
return await connectSocket(socketPath, signal)
} catch (error) {
lastError = error instanceof Error ? error : new Error(String(error))
if (signal?.aborted) {
break
}
await sleep(100, signal)
}
}
if (signal?.aborted) {
throw new RuntimeClientError(
'accessibility_error',
'native macOS helper app startup was cancelled'
)
}
throw new RuntimeClientError(
'action_timeout',
`native macOS helper app did not open its socket: ${lastError?.message ?? 'timed out'}`
)
}
function connectSocket(socketPath: string, signal?: AbortSignal): Promise<net.Socket> {
return new Promise((resolve, reject) => {
if (signal?.aborted) {
reject(
new RuntimeClientError(
'accessibility_error',
'native macOS helper app startup was cancelled'
)
)
return
}
const socket = net.createConnection(socketPath)
const cleanup = (): void => {
socket.off('error', onError)
socket.off('connect', onConnect)
signal?.removeEventListener('abort', onAbort)
}
const onError = (error: Error): void => {
cleanup()
socket.destroy()
reject(error)
}
const onConnect = (): void => {
cleanup()
resolve(socket)
}
const onAbort = (): void => {
cleanup()
socket.destroy()
reject(
new RuntimeClientError(
'accessibility_error',
'native macOS helper app startup was cancelled'
)
)
}
socket.once('error', onError)
socket.once('connect', onConnect)
signal?.addEventListener('abort', onAbort, { once: true })
})
}
function sleep(ms: number, signal?: AbortSignal): Promise<void> {
return new Promise((resolve) => {
const timer = setTimeout(finish, ms)
const onAbort = (): void => finish()
function finish(): void {
clearTimeout(timer)
signal?.removeEventListener('abort', onAbort)
resolve()
}
signal?.addEventListener('abort', onAbort, { once: true })
})
}