Files
orca/src/shared/agent-session-thread-goal.test.ts
T
NeilandClaude cd42d59a77 refactor: drop the unused sync spool drain and thread-goal wrapper; reuse the shared absence check (#29820)
The synchronous drainAgentHookSpool and currentAgentSessionThreadGoalBySequence lost their
last production callers earlier today; tests now exercise the functions production calls.
git-object-quarantine reuses isDefinitiveAbsence instead of a private ENOENT/ENOTDIR copy.

Co-authored-by: Claude <noreply@anthropic.com>
2026-10-16 13:33:42 -07:00

141 lines
5.4 KiB
TypeScript

import { describe, expect, it } from 'vitest'
import type {
AgentJournalItemBody,
AgentJournalRenderItem,
AgentJournalThreadGoal
} from './agent-session-journal-types'
import {
agentSessionThreadGoalElapsedSeconds,
agentSessionThreadGoalStatusChange,
currentAgentSessionThreadGoal,
currentAgentSessionThreadGoalSourceBySequence,
isAgentSessionThreadGoalOpen
} from './agent-session-thread-goal'
const PAYLOAD = { head: '{"goal":', byteLength: 4096, digest: 'd'.repeat(64), truncated: true }
function goal(overrides: Partial<AgentJournalThreadGoal> = {}): AgentJournalThreadGoal {
return {
objective: 'Ship the parser',
status: 'active',
tokenBudget: null,
tokensUsed: 10,
timeUsedSeconds: 30,
createdAt: 1_000_000,
updatedAt: 1_000_000,
...overrides
}
}
function row(
sequence: number,
body: AgentJournalItemBody,
extra: Partial<AgentJournalRenderItem> = {}
): AgentJournalRenderItem {
return { itemId: `item-${sequence}`, revision: 1, sequence, observedAt: sequence, body, ...extra }
}
function goalRow(sequence: number, state: 'set' | 'cleared', value = goal()) {
return row(sequence, {
kind: 'status',
text: state === 'set' ? `Goal set: ${value.objective}` : 'Goal cleared',
providerFrame: {
provider: 'codex',
kind: `notification:thread/goal/${state === 'set' ? 'updated' : 'cleared'}`,
payload: PAYLOAD
},
threadGoal: state === 'set' ? { state: 'set', goal: value } : { state: 'cleared' }
})
}
describe('current thread goal', () => {
it('reports no answer when no row records a goal transition', () => {
expect(
currentAgentSessionThreadGoal([
row(1, { kind: 'message', role: 'user', blocks: [{ type: 'text', text: 'hi' }] }),
row(2, { kind: 'status', text: 'Context compacted' })
])
).toBeUndefined()
})
it('reads the last goal row of a rendered snapshot, past later rows of other kinds', () => {
const paused = goal({ status: 'paused' })
expect(
currentAgentSessionThreadGoal([
goalRow(1, 'set'),
goalRow(2, 'set', paused),
row(3, { kind: 'status', text: 'Context compacted' })
])
).toEqual(paused)
})
it('takes the latest transition by sequence for items held unordered', () => {
const paused = goal({ status: 'paused' })
const unordered = new Map([
['b', goalRow(5, 'set', paused)],
['a', goalRow(2, 'set')]
])
expect(currentAgentSessionThreadGoalSourceBySequence(unordered.values())?.goal).toEqual(paused)
expect(currentAgentSessionThreadGoalSourceBySequence([])?.goal).toBeUndefined()
})
it('answers null once the latest transition cleared the goal', () => {
expect(currentAgentSessionThreadGoal([goalRow(1, 'set'), goalRow(2, 'cleared')])).toBeNull()
})
it('answers null for a row written before the typed snapshot existed', () => {
const legacy = row(3, {
kind: 'status',
text: 'Goal set: Ship the parser',
providerFrame: {
provider: 'codex',
kind: 'notification:thread/goal/updated',
payload: PAYLOAD
}
})
// The legacy row still supersedes the older typed one; it just cannot be read.
expect(currentAgentSessionThreadGoal([goalRow(1, 'set'), legacy])).toBeNull()
})
it('ignores a subagent goal and a status this build cannot place', () => {
const subagent = { ...goalRow(4, 'cleared'), agentId: 'child-1' }
expect(currentAgentSessionThreadGoal([goalRow(1, 'set'), subagent])).toEqual(goal())
// A newer provider status must not read as a known one.
const future = goalRow(5, 'set', Object.assign(goal(), { status: 'snoozed' }))
expect(currentAgentSessionThreadGoal([goalRow(1, 'set'), future])).toBeNull()
})
})
describe('thread goal presentation facts', () => {
it('keeps every status but complete open', () => {
expect(isAgentSessionThreadGoalOpen(goal({ status: 'blocked' }))).toBe(true)
expect(isAgentSessionThreadGoalOpen(goal({ status: 'complete' }))).toBe(false)
expect(isAgentSessionThreadGoalOpen(null)).toBe(false)
})
it('pauses only an active goal, and resumes a paused, blocked or usage-limited one', () => {
expect(agentSessionThreadGoalStatusChange('active')).toBe('paused')
expect(agentSessionThreadGoalStatusChange('paused')).toBe('active')
expect(agentSessionThreadGoalStatusChange('blocked')).toBe('active')
expect(agentSessionThreadGoalStatusChange('usageLimited')).toBe('active')
// A spent budget is not a pause: the provider will not resume it.
expect(agentSessionThreadGoalStatusChange('budgetLimited')).toBeNull()
expect(agentSessionThreadGoalStatusChange('complete')).toBeNull()
})
it('adds time only while an active goal has a turn running', () => {
const now = 1_000_000 + 7_500
const running = { startedAt: null }
expect(agentSessionThreadGoalElapsedSeconds(goal(), now, null)).toBe(30)
expect(agentSessionThreadGoalElapsedSeconds(goal(), now, running)).toBe(37)
expect(agentSessionThreadGoalElapsedSeconds(goal({ status: 'paused' }), now, running)).toBe(30)
// A report older than the turn counts from the turn's start, not across the idle gap.
expect(agentSessionThreadGoalElapsedSeconds(goal(), now, { startedAt: now - 2_000 })).toBe(32)
// A provider clock ahead of this one never subtracts time.
expect(
agentSessionThreadGoalElapsedSeconds(goal({ updatedAt: now + 5_000 }), now, running)
).toBe(30)
})
})