Files
orca/src/main/runtime/runtime-provider-command-ssh-routing.test.ts
T
Brennan BensonandHotragn 8f3d8c8583 fix(gitlab): preserve MR pagination when totals are missing (#34171)
* fix(gitlab): keep paging merge requests when GitLab omits the totals

When total headers are absent, a full response advertises another page to probe and a short response ends pagination. Keep the existing header precedence and unknown total count.

Tracked in #33800

* test(gitlab): cover MR pagination exhaustion and header precedence

* test(gitlab): verify unknown-total metadata across list consumers

* test(gitlab): cover remaining screen consumers of list metadata

* test: use checked GitLab RPC runtime fixtures

---------

Co-authored-by: Hotragn <103170876+Hotragn@users.noreply.github.com>
2026-10-27 13:46:07 -07:00

102 lines
3.3 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest'
import type { Repo } from '../../shared/repo-types'
const { getIssueMock, listTodosMock, listMergeRequestsMock, listWorkItemsMock } = vi.hoisted(
() => ({
getIssueMock: vi.fn(),
listTodosMock: vi.fn(),
listMergeRequestsMock: vi.fn(),
listWorkItemsMock: vi.fn()
})
)
vi.mock('../github/client', () => ({
getIssue: getIssueMock,
getPRCheckDetails: vi.fn(),
getPRChecks: vi.fn(),
getPRComments: vi.fn()
}))
vi.mock('../github/work-item-details', () => ({ getPRFileContents: vi.fn() }))
vi.mock('../gitlab/client', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
listTodos: listTodosMock,
listMergeRequests: listMergeRequestsMock,
listWorkItems: listWorkItemsMock
}))
import { RuntimeGitHubReviewQueryCommands } from './runtime-github-review-query-commands'
import { RuntimeGitLabQueryCommands } from './runtime-gitlab-query-commands'
function repoOn(fields: Pick<Repo, 'connectionId' | 'executionHostId'>): Repo {
return {
id: 'repo-1',
path: '/srv/project',
displayName: 'project',
badgeColor: '#000',
addedAt: 0,
kind: 'git',
...fields
}
}
// Raw connectionId missed ssh:-only rows and ran gh/glab on this host.
describe('runtime provider commands route an SSH project to its host', () => {
beforeEach(() => {
getIssueMock.mockReset().mockResolvedValue(null)
listTodosMock.mockReset().mockResolvedValue([])
listMergeRequestsMock.mockReset()
listWorkItemsMock.mockReset()
})
it.each([
['executionHostId only', { executionHostId: 'ssh:gpu' as const }, 'gpu'],
['legacy connectionId', { connectionId: 'gpu' }, 'gpu'],
['local', { executionHostId: 'local' as const }, null]
])('GitHub issue lookup (%s)', async (_label, fields, expected) => {
const commands = new RuntimeGitHubReviewQueryCommands({
resolveRepo: async () => repoOn(fields),
getLocalGitArgs: () => []
})
await commands.getRepoIssue('id:repo-1', 7)
expect(getIssueMock).toHaveBeenCalledWith('/srv/project', 7, expected)
})
it.each([
['executionHostId only', { executionHostId: 'ssh:gpu' as const }, 'gpu'],
['local', { executionHostId: 'local' as const }, null]
])('GitLab todo list (%s)', async (_label, fields, expected) => {
const commands = new RuntimeGitLabQueryCommands({
resolveRepo: async () => repoOn(fields),
getLocalGitArgs: () => [],
recordProjectRecent: () => {}
})
await commands.listGitLabRepoTodos('id:repo-1')
expect(listTodosMock).toHaveBeenCalledWith('/srv/project', expected)
})
it('preserves unknown-total list envelopes through the GitLab runtime commands', async () => {
const result = {
items: [{ id: 'mr-7', type: 'mr', number: 7 }],
page: 3,
perPage: 1,
totalCount: 0,
totalPages: 4
}
listMergeRequestsMock.mockResolvedValue(result)
listWorkItemsMock.mockResolvedValue(result)
const commands = new RuntimeGitLabQueryCommands({
resolveRepo: async () => repoOn({ executionHostId: 'ssh:gpu' }),
getLocalGitArgs: () => [],
recordProjectRecent: () => {}
})
await expect(commands.listGitLabRepoMRs('id:repo-1', 'opened', 3, 1)).resolves.toEqual(result)
await expect(commands.listGitLabRepoWorkItems('id:repo-1', 'opened', 3, 1)).resolves.toEqual(
result
)
})
})