Files
orca/tests
e9285f0f58 fix(floating-workspace): open the floating panel instead of blanking the main window on host reveals (#28184)
* fix(floating-workspace): reveal workspaces where they live instead of selecting the floating one

Every renderer path that takes the user to a workspace hand-wrote the main-window
selection sequence, so a floating workspace id (terminal switch, CLI focus, agent
launch, notification and mobile reveals, terminal handle links) became the main
window's selection and blanked it while the floating panel stayed closed.

revealWorkspaceSurface is now the one way to show a workspace: the floating
workspace opens its panel and leaves the main window alone, any other workspace
becomes the main window's selection and a visit. selectWorkspaceSurfaceOwner is
its non-navigating twin for tabs opening beside the user. The ad-hoc floating
checks in worktree activation, http links, the editor close queue, Activity and
open-terminal-beside-tab now go through the same module.

Co-authored-by: Velm14 <10477408+Velm14@users.noreply.github.com>

* fix(notifications): bind clicks for floating and folder workspace terminals

A terminal notification only bound its click when the worktree id carried a
repo ("repoId::path"), so floating-workspace and folder-workspace terminal
notifications did nothing when clicked. ui:focusTerminal now reveals any
workspace where it lives, so the click binds whenever there is a pane to focus
and ui:activateWorktree is sent only when a repo exists.

Co-authored-by: YuriNachos <19365375+YuriNachos@users.noreply.github.com>

* refactor(floating-workspace): tighten the workspace surface reveal

Move the floating-owned check into floating-workspace-panel-reveal as
revealFloatingWorkspacePanelFor so worktree activation no longer depends on
workspace-surface-reveal, rename selectWorkspaceSurfaceOwner to
selectWorkspaceSurface with a named state type, reuse the panel visibility
selector, and flatten the IPC bridges' surface-owner branches.

Co-authored-by: Velm14 <10477408+Velm14@users.noreply.github.com>

* fix(floating-workspace): leave the floating setting alone before settings hydrate

Host reveals (CLI focus, mobile, notification clicks) can arrive before
settings load; re-enabling the floating feature then would overwrite a
saved `false`. Unhydrated settings now skip the reveal.

Co-authored-by: Velm14 <10477408+Velm14@users.noreply.github.com>

* refactor(floating-workspace): drop extra reveal concepts

Co-authored-by: Velm14 <10477408+Velm14@users.noreply.github.com>

* fix(floating-workspace): keep main's setActiveWorktree call shape for plain reveals

Co-authored-by: Velm14 <10477408+Velm14@users.noreply.github.com>

---------

Co-authored-by: Velm14 <10477408+Velm14@users.noreply.github.com>
Co-authored-by: YuriNachos <19365375+YuriNachos@users.noreply.github.com>
2026-10-13 03:33:11 -04:00
..