mirror of
https://github.com/stablyai/orca.git
synced 2026-11-04 02:57:36 +00:00
* Source control actions start chats and terminals on their saved model A "start an agent" action's model lived only in free-text CLI arguments, which a native chat never reads, so AI Fix opened a chat on the default model. Each action now saves a structured model and effort that both routes apply: chat create options, or the agent's own flags in a terminal (winning over the same flag in CLI arguments). Desktop, dialog, fix-checks and mobile launches carry it; Settings rows get Model/Effort selects and the CLI arguments field says it is terminal-only. Tracked in STA-11102. * Name the model in the repository override note * Type the dialog's model hand-off; keep Agent in English in Japanese copy * fix: preserve action chat model choices through launch * Preserve action selection ownership across chat launches * Keep terminal host contract fixtures aligned with preflight * fix: wait for action Settings agent inventory * fix: consolidate direct agent routing imports * fix: use standard action option labels * fix: align action launch contracts with shared types * fix: sync action option localization metadata * test: provide action Settings inventory in mounted fixtures * Keep action options row height stable while loading * Let each Source Control action choose its chat permission mode An action's saved chat choice may now carry a permission mode, with or without a model; "Same as new chats" saves nothing. A model is replaced only when the action names one, so a permission-only choice keeps the chat's remembered model and options. * fix(native-chat): leave older hosts their own permission mode and keep action options readable - An action's saved permission mode is sent only to hosts that advertise agentSession.create.options-mode.v1. Older hosts get no mode, in create options or a later setOption, so the chat starts on that host's new-chat default, as a phone launch to such a host already does. Hosts from 1.4.225 to 1.4.227 refused a mode their tables lacked (OpenCode, Grok, OMP), leaving the action unable to start. - Settings action rows give Model and Permissions full rows in the options column so saved values are readable; the loading placeholder reserves the same rows. - Remove two unused locale keys; fix two stale comments. - Tests: the older-host create carries no permission mode; a permission mode picked alone keeps the remembered model on an acquired create. * fix(settings): reserve one options row while loading an action with nothing saved Terminal and permissions-only rows no longer shrink when loading ends; a chat agent with a model list may grow by its Model row once known. * fix(native-chat): keep the create options mode a checked literal type * fix(settings): share verified action option fields * fix(settings): keep action selectors on standard typography * Keep the launch files under their length limits after the main merge The structured route imports its result types where they are defined, and the two older-host action-launch tests share one setup helper. * One action settings section for chat and terminal launches A Source Control action's Model, model options and Permissions now apply whether it opens a chat or a terminal; terminals receive them as the agent's own flags, and a repository's own CLI arguments keep the flags it sets. Extra CLI arguments stay terminal-only. * fix(source-control-ai): one terminal projection for saved action choices Ask in a terminal now states its permission instead of leaving it to the user's own config: Claude and Grok pass --permission-mode default, Codex passes -a on-request -s read-only -c approvals_reviewer="user" (the interactive CLI has no untrusted policy, so a read-only sandbox is what asks before edits). Agents whose CLI has no flag for a mode show the existing "Applies to chats only" hint. The strict launch-preferences projection now requires the launch agent at every caller, composes model ids through the resolver's own step, carries a mode only where the agent's terminal has a flag for it, and the local string wire keeps booleans as 'true'/'false', so Cursor Thinking/Fast reach the terminal and an OpenCode permission-only choice is not refused. The argument parser knows flag arity, so removing a boolean permission flag keeps other options' values, following positionals and '--'. Pre-admission and executor share one terminal admission check on the options the terminal will receive. Customize with Save launches the recipe as it will resolve once saved; legacy partial repository overrides are edited as the complete recipe they resolve to. Empty Extra CLI arguments start collapsed. * fix(source-control-ai): an edited repository action saves complete Every Settings edit of a repository action (agent, model, permission, prompt or arguments) now starts from the complete recipe the action resolves to, whether its stored override is owned or a legacy partial. The resolved agent selection is kept (never an agent only detected to run a default), an explicit null args clear stays null, and empty args stay empty instead of being dropped. Clearing the last preference therefore means the action agent's own defaults rather than re-inheriting Global. The action text draft is lossless: unset or cleared prompt and args stay so until the user types, and the inputs show them as empty, so saving a prompt no longer writes empty args that suppress the agent's default flags. Untouched sibling actions are not rewritten by the edit. * fix(settings): style the Extra CLI arguments toggle through Button's own variant and size CI's changed-code quality check refuses restyle classes on Button and CollapsibleContent. Use the ghost variant at size xs with a margin, and put the content spacing on a plain inner wrapper. * fix: keep saved action and restart launch recipes consistent * fix: describe inherited arguments and chat-only permissions accurately * test: check repository action settings fixture type * test: map saved action options into terminal compiler inputs * fix: retain saved action controls during agent detection * fix(i18n): retire obsolete Portuguese action labels * test: align folder launch fallback mock with outcome export * fix: carry resolved connector launch intent and mode together * test: pin shared action launch branches to recorded agent output * test: preserve saved source control choices through detection and migration * test: align launch fixtures with integrated result contract * test: retain recipe and restart contracts after main integration * Unify Source Control action permission settings * Keep native Ask copy with its owning change * Preserve action drafts and old-host permission intent * Consume rejected Source Control action saves * Follow the moved Settings persistence fixture * Keep permission integration contracts in the cross-version test project * Include the action permission inheritance label in English catalogs * Align launch contracts with shared permission recipes * Keep Source Control action controls within their Settings columns * Use primitive variants for compact action settings controls * Show action arguments only for terminal defaults and widen recipe rows * Apply terminal-only action arguments visibility to repository overrides * Align action permission control with model controls * Use shared settings label for action permissions * Hide action model controls until argument migration ships
124 lines
5.2 KiB
TypeScript
124 lines
5.2 KiB
TypeScript
/** Fingerprint behavioral fields, excluding telemetry: omissions can replay a different launch; extra attribution fields can reject an honest retry. */
|
|
|
|
import { describe, expect, it } from 'vitest'
|
|
import {
|
|
computeAgentLaunchFingerprint,
|
|
type AgentLaunchFingerprintInput
|
|
} from './agent-launch-operation'
|
|
import { canonicalAgentSessionDigest } from './agent-session-mutation-envelope'
|
|
|
|
const BASE = {
|
|
agent: 'claude',
|
|
target: { kind: 'existing' as const, worktree: 'wt-1' }
|
|
}
|
|
const PANE_KEY = '9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d:3f2504e0-4f89-41d3-9a0c-0305e82c3301'
|
|
const OTHER_PANE_KEY = '9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d:6fa459ea-ee8a-4ca4-894e-db77e160355e'
|
|
|
|
/** The handler passes whole wire objects; test runtime exclusion of launchSource rather than its absence from the input type. */
|
|
function fingerprintOfWirePayload(
|
|
params: AgentLaunchFingerprintInput & { launchSource?: string }
|
|
): string {
|
|
return computeAgentLaunchFingerprint(params)
|
|
}
|
|
|
|
describe('fields the launch fingerprint covers', () => {
|
|
it('covers encoded chat choices while omission keeps the previous digest', () => {
|
|
expect(
|
|
computeAgentLaunchFingerprint({ ...BASE, chatOptions: { model: 'opus', fastMode: 'false' } })
|
|
).not.toBe(computeAgentLaunchFingerprint(BASE))
|
|
expect(
|
|
computeAgentLaunchFingerprint({ ...BASE, chatOptions: { model: 'opus', fastMode: 'false' } })
|
|
).not.toBe(
|
|
computeAgentLaunchFingerprint({ ...BASE, chatOptions: { model: 'opus', fastMode: 'true' } })
|
|
)
|
|
})
|
|
|
|
it('separates two launches that differ only in agentArgs', () => {
|
|
expect(computeAgentLaunchFingerprint({ ...BASE, agentArgs: '--model opus' })).not.toBe(
|
|
computeAgentLaunchFingerprint({ ...BASE, agentArgs: '--model sonnet' })
|
|
)
|
|
})
|
|
|
|
it('treats an explicit "no arguments" as different from falling back to the settings default', () => {
|
|
// Preserve explicit-clear versus default-arguments identity across retries.
|
|
expect(computeAgentLaunchFingerprint({ ...BASE, agentArgs: null })).not.toBe(
|
|
computeAgentLaunchFingerprint(BASE)
|
|
)
|
|
})
|
|
|
|
it('separates two launches that differ only in cwd', () => {
|
|
expect(computeAgentLaunchFingerprint({ ...BASE, cwd: '/repo/packages/a' })).not.toBe(
|
|
computeAgentLaunchFingerprint({ ...BASE, cwd: '/repo/packages/b' })
|
|
)
|
|
})
|
|
|
|
it('separates two launches that reserved different panes or sessions', () => {
|
|
// The key is baked into the pane's env; replaying another pane's key strands the new reservation.
|
|
expect(computeAgentLaunchFingerprint({ ...BASE, paneKey: PANE_KEY })).not.toBe(
|
|
computeAgentLaunchFingerprint({ ...BASE, paneKey: OTHER_PANE_KEY })
|
|
)
|
|
expect(computeAgentLaunchFingerprint({ ...BASE, paneKey: PANE_KEY })).not.toBe(
|
|
computeAgentLaunchFingerprint(BASE)
|
|
)
|
|
const sessionId = '11111111-1111-4111-8111-111111111111'
|
|
expect(computeAgentLaunchFingerprint({ ...BASE, sessionId })).not.toBe(
|
|
computeAgentLaunchFingerprint({ ...BASE, sessionId: '22222222-2222-4222-8222-222222222222' })
|
|
)
|
|
expect(computeAgentLaunchFingerprint({ ...BASE, sessionId })).not.toBe(
|
|
computeAgentLaunchFingerprint(BASE)
|
|
)
|
|
})
|
|
|
|
it('separates a retry that picked another surface, or none, from the first launch', () => {
|
|
const terminal = computeAgentLaunchFingerprint({ ...BASE, surface: 'terminal' })
|
|
expect(terminal).not.toBe(computeAgentLaunchFingerprint({ ...BASE, surface: 'chat' }))
|
|
expect(terminal).not.toBe(computeAgentLaunchFingerprint(BASE))
|
|
})
|
|
})
|
|
|
|
describe('fields the launch fingerprint deliberately ignores', () => {
|
|
it('does not separate two launches that differ only in launchSource', () => {
|
|
// Attribution changes must not turn an identical launch retry into a conflict.
|
|
expect(fingerprintOfWirePayload({ ...BASE, launchSource: 'shortcut' })).toBe(
|
|
fingerprintOfWirePayload({ ...BASE, launchSource: 'tab_bar_quick_launch' })
|
|
)
|
|
})
|
|
|
|
it('ignores launchSource entirely, so sending one matches sending none', () => {
|
|
expect(fingerprintOfWirePayload({ ...BASE, launchSource: 'sidebar' })).toBe(
|
|
computeAgentLaunchFingerprint(BASE)
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('compatibility with rows written before these fields existed', () => {
|
|
/** Preserve previous-build digests when new fields are absent so host upgrades do not refuse in-flight retries. */
|
|
it('matches the pre-existing digest when no new field is sent', () => {
|
|
const previousBuild = canonicalAgentSessionDigest({
|
|
method: 'agent.launch',
|
|
agent: BASE.agent,
|
|
target: BASE.target,
|
|
prompt: undefined,
|
|
sessionOptions: undefined,
|
|
reuseTerminal: undefined
|
|
})
|
|
expect(computeAgentLaunchFingerprint(BASE)).toBe(previousBuild)
|
|
})
|
|
|
|
it('matches the digest from before the pane key existed when no pane is reserved', () => {
|
|
const beforePaneKey = canonicalAgentSessionDigest({
|
|
method: 'agent.launch',
|
|
agent: BASE.agent,
|
|
target: BASE.target,
|
|
prompt: undefined,
|
|
sessionOptions: undefined,
|
|
reuseTerminal: undefined,
|
|
agentArgs: '--model opus',
|
|
cwd: '/repo/packages/a'
|
|
})
|
|
expect(
|
|
computeAgentLaunchFingerprint({ ...BASE, agentArgs: '--model opus', cwd: '/repo/packages/a' })
|
|
).toBe(beforePaneKey)
|
|
})
|
|
})
|