Files
orca/src/main/runtime/agent-launch-scope-runtime.test.ts
T
Brennan Benson d78363ab36 fix(agent-launch): find a repo's project the way the window does (#28237)
* fix(agent-launch): find a repo's project the way the window does

The host now also takes a project named after the repo as that repo's project, as the window
does, so both pick the same project row and runtime even when a repo was moved out of the
project named after it.

* refactor(agent-launch): share one repo-to-project match with the window

The host's agent-launch lookup and the window's launch preflight now call one projectMatchesRepo
instead of each writing the match out. No behaviour change on either side.
2026-10-14 17:52:41 -07:00

134 lines
5.6 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, it } from 'vitest'
import type { Repo } from '../../shared/repo-types'
import type { FolderWorkspace } from '../../shared/folder-workspace-types'
import { _resetWslCachesForTests, _setWslCachesForTests } from '../wsl'
import {
agentLaunchPlatformForScope,
resolveAgentLaunchRuntime
} from './agent-launch-scope-runtime'
import type { TerminalWorkspaceLaunchScope } from './runtime-legacy-worker-terminal-recovery-types'
import { agentLaunchQuotingShell } from '../../shared/agent-launch-runtime'
const WIN = 'C:\\repo'
const SHARE = '\\\\wsl$\\Ubuntu\\home\\a\\repo'
const UBUNTU = { kind: 'wsl', distro: 'Ubuntu' } as const
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: the resolvers read only the fields each fixture sets.
const fixture = <T>(fields: Partial<T>): T => fields as T
const repo = (path: string) => fixture<Repo>({ id: 'r', path, projectGroupId: 'g' })
const folder = (path: string) =>
fixture<FolderWorkspace>({ id: 'f', projectGroupId: 'g', folderPath: path })
const scope = (
path: string,
kind: { repo?: Repo; folder?: FolderWorkspace }
): TerminalWorkspaceLaunchScope => ({
id: kind.repo ? 'r' : 'f',
path,
connectionId: null,
repo: kind.repo ?? null,
folderWorkspace: kind.folder ?? null
})
function store(args: {
repos?: Repo[]
/** Repo `r`'s project runtime. */
project?: unknown
global?: unknown
folder?: FolderWorkspace
shell?: string
}) {
const fake = {
getProjects: () => [
{ id: 'p', sourceRepoIds: ['r'], localWindowsRuntimePreference: args.project }
],
getSettings: () => ({
terminalWindowsShell: args.shell ?? 'cmd.exe',
localWindowsRuntimeDefault: args.global
}),
getRepo: (id: string) => (id === 'r' ? repo(WIN) : undefined),
getRepos: () => args.repos ?? [],
getFolderWorkspaces: () => (args.folder ? [args.folder] : []),
getProjectGroups: () => [{ id: 'g', name: 'g', parentPath: null, connectionId: null }]
}
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: the resolvers read only these members and fields.
return fake as never
}
const claudeRuntime = (s: never, launchScope: TerminalWorkspaceLaunchScope) =>
resolveAgentLaunchRuntime(s, launchScope, undefined, 'claude')
const WORK = folder('C:\\work')
const IN_WORK = scope('C:\\work', { folder: WORK })
const original = process.platform
const setPlatform = (value: string) =>
Object.defineProperty(process, 'platform', { configurable: true, value })
beforeEach(() => setPlatform('win32'))
afterEach(() => {
setPlatform(original)
_resetWslCachesForTests()
})
// Relied on by C2: "+" moves onto the host planner with no change, because both sides use this rule.
describe("the window's runtime rule, on the host", () => {
it.each([
['repo, project WSL', store({ project: UBUNTU }), scope(WIN, { repo: repo(WIN) }), 'linux'],
[
'folder holding one WSL-project repo',
store({ project: UBUNTU, repos: [repo(WIN)], folder: WORK }),
IN_WORK,
'linux'
],
[
'repo-less folder ignores the global default, as the window does',
store({ global: UBUNTU, folder: WORK }),
IN_WORK,
'win32'
]
])('%s', (_name, s, launchScope, platform) => {
expect(agentLaunchPlatformForScope(s, launchScope)).toBe(platform)
})
})
// PLAN §7 UNVERIFIED 4. Relied on by C2, whose pane spawn takes the host's answer.
it("answers from main's WSL cache, which the window may not have read yet", () => {
_setWslCachesForTests({ available: true, distros: ['Debian'] })
expect(() => claudeRuntime(store({ project: UBUNTU }), scope(WIN, { repo: repo(WIN) }))).toThrow(
'Ubuntu is not installed in WSL'
)
// A `\\wsl$` path proves its distro, so a stale cache never refuses it.
expect(claudeRuntime(store({}), scope(SHARE, { repo: repo(SHARE) })).platform).toBe('linux')
})
// The window's lookup: a project named after the repo counts as its project, as does one listing it.
it("finds a repo's project the way the window does, by its id too", () => {
const projects = [
{ id: 'r', sourceRepoIds: [], localWindowsRuntimePreference: UBUNTU },
{ id: 'p', sourceRepoIds: ['r'], localWindowsRuntimePreference: { kind: 'windows-host' } }
]
const fake = { getProjects: () => projects, getSettings: () => ({}), getRepo: () => repo(WIN) }
// oxlint-disable-next-line typescript/consistent-type-assertions -- SAFETY: the resolver reads only these members.
expect(agentLaunchPlatformForScope(fake as never, scope(WIN, { repo: repo(WIN) }))).toBe('linux')
})
// Relied on by C2: the pane's pty:spawn takes the fact as is, for quoting and shell alike.
it('quotes for the shell the PTY gets, not a setting the runtime replaced', () => {
const windowsHost = store({ project: { kind: 'windows-host' }, shell: 'wsl.exe' })
const local = claudeRuntime(windowsHost, scope(WIN, { repo: repo(WIN) }))
expect(local.pty.shellOverride).toBe('powershell.exe')
expect(agentLaunchQuotingShell(local)).toBe('powershell')
// A `\\wsl$` path runs in WSL whatever the setting says, so it is written for Linux there.
expect(claudeRuntime(windowsHost, scope(SHARE, { repo: repo(SHARE) })).platform).toBe('linux')
})
// TEMPORARY until STA-10231. Only folders reach it: every local repo has a project runtime.
it("keeps a folder's WSL Terminal shell where its repo's project is set to Windows host", () => {
const project = { kind: 'windows-host' }
const legacy = claudeRuntime(
store({ project, shell: 'wsl.exe', repos: [repo(WIN)], folder: WORK }),
IN_WORK
)
expect([legacy.platform, legacy.pty.shellOverride, agentLaunchQuotingShell(legacy)]).toEqual([
'win32',
'wsl.exe',
'posix'
])
})