Files
orca/src/main/github/github-issue-link-title-fill.ts
T
Neil 386afed0ca refactor(persistence): organize profile state and Store domains (#41106)
* refactor(persistence): organize profile state and Store domains

* fix(test): locate relocated profile state worker fixtures
2026-11-11 02:44:06 -08:00

167 lines
6.2 KiB
TypeScript

import type { ExecutionHostId } from '../../shared/execution-host'
import type { Repo } from '../../shared/repo-types'
import type { WorktreeMeta } from '../../shared/worktree/meta-types'
import type { WorkspaceAttachment } from '../../shared/worktree/types'
import type { WorkspaceAttachmentMutation } from '../../shared/workspace-attachments/workspace-attachment-mutation'
import { getWorkspaceAttachments } from '../../shared/workspace-attachments/workspace-attachments'
import { WORKSPACE_ATTACHMENT_NUMBER_SLOTS } from '../../shared/workspace-attachments/workspace-attachment-legacy'
import { getWorkspaceReferenceIdentity } from '../../shared/workspace-attachments/workspace-reference-identity'
import {
hostWorktreeTarget,
type HostWorktreeTarget
} from '../../shared/worktree/host-qualified-identity'
import { getRepoIdFromWorktreeId } from '../../shared/worktree/id'
import type { WorktreeMetaWriteListener } from '../persistence/loading-store/profile-writing/write-scheduling'
import { findRepoRowForHostScopedWrite } from '../persistence/tracking-repos/repo-update-operations'
export type GitHubIssueLinkTitleFillStore = {
onWorktreeMetaWritten: (listener: WorktreeMetaWriteListener) => () => void
getWorktreeMetaForHost: (worktreeId: string, hostId: ExecutionHostId) => WorktreeMeta | undefined
setWorktreeMeta: (
target: HostWorktreeTarget,
meta: Partial<WorktreeMeta> & WorkspaceAttachmentMutation
) => WorktreeMeta
getRepos: () => Repo[]
}
type Job = {
worktreeId: string
hostId: ExecutionHostId
instanceId: string | undefined
identity: string
link: WorkspaceAttachment
}
function untitledGitHubIssues(meta: WorktreeMeta | undefined): WorkspaceAttachment[] {
return getWorkspaceAttachments(meta).filter(
(item) => item.provider === 'github' && item.type === 'issue' && !item.title?.trim()
)
}
/**
* Links made without a title (CLI `--issue N`, phones, typed numbers) get the issue's title once, on the
* host that owns the workspace, so search can match it without a client re-reading every linked issue.
*/
export function installGitHubIssueLinkTitleFill(deps: {
store: GitHubIssueLinkTitleFillStore
readIssueTitle: (repo: Repo, link: WorkspaceAttachment) => Promise<string | null>
// Addressed to the one workspace whose links changed; never a repo-wide refresh.
publish: (change: { worktreeId: string; hostId: ExecutionHostId; meta: WorktreeMeta }) => void
schedule?: (run: () => void) => void
}): () => void {
const schedule = deps.schedule ?? ((run) => setImmediate(run))
const queue = new Map<string, Job>()
let draining = false
let disposed = false
// The job's link as it is now; null once removed, retitled or its workspace re-created.
const currentTarget = (job: Job) => {
const meta = deps.store.getWorktreeMetaForHost(job.worktreeId, job.hostId)
if (!meta || meta.instanceId !== job.instanceId) {
return null
}
const items = getWorkspaceAttachments(meta)
const index = items.findIndex(
(item) => getWorkspaceReferenceIdentity(item) === job.identity && !item.title?.trim()
)
return index === -1 ? null : { meta, items, index }
}
const apply = (job: Job, title: string): void => {
const target = currentTarget(job)
if (!target) {
return
}
const { meta, items, index } = target
const reviewSlots = WORKSPACE_ATTACHMENT_NUMBER_SLOTS.filter(([, , type]) => type !== 'issue')
// A cleared review selection must be restated or the merge re-picks one; a set one it keeps.
const keepClearedSelection = reviewSlots.every(([slot]) => (meta[slot] ?? null) === null)
? Object.fromEntries(reviewSlots.map(([slot]) => [slot, null]))
: {}
const updated = deps.store.setWorktreeMeta(
hostWorktreeTarget({ id: job.worktreeId, hostId: job.hostId }),
{
...keepClearedSelection,
linkedItemsBase: items,
linkedItems: items.map((item, i) => (i === index ? { ...item, title } : item))
}
)
deps.publish({ worktreeId: job.worktreeId, hostId: job.hostId, meta: updated })
}
const drain = async (): Promise<void> => {
if (draining) {
return
}
draining = true
try {
for (const [key, job] of queue) {
queue.delete(key)
if (disposed) {
return
}
try {
const repo = currentTarget(job)
? findRepoRowForHostScopedWrite(
deps.store.getRepos(),
getRepoIdFromWorktreeId(job.worktreeId),
job.hostId
)
: undefined
const title = repo ? await deps.readIssueTitle(repo, job.link).catch(() => null) : null
if (title?.trim() && !disposed) {
apply(job, title.trim())
}
} catch {
// One link whose target changed underneath it (e.g. an alias turned ambiguous) is skipped;
// the rest of the queue still drains.
}
}
} finally {
draining = false
}
}
const unsubscribe = deps.store.onWorktreeMetaWritten(({ worktreeId, hostId, previous, next }) => {
// Most writes (stamps, flags, comments) leave links untouched; skip them without normalizing.
// linkedWorkItem is re-created on every write and always titled, so it is not compared.
if (
previous &&
previous.instanceId === next.instanceId &&
previous.linkedItems === next.linkedItems &&
previous.linkedIssue === next.linkedIssue
) {
return
}
const known = new Set(
previous?.instanceId === next.instanceId
? untitledGitHubIssues(previous).map(getWorkspaceReferenceIdentity)
: []
)
let added = false
for (const link of untitledGitHubIssues(next)) {
const identity = getWorkspaceReferenceIdentity(link)
if (known.has(identity)) {
continue
}
queue.set(JSON.stringify([hostId, worktreeId, next.instanceId, identity]), {
worktreeId,
hostId,
instanceId: next.instanceId,
identity,
link
})
added = true
}
if (added) {
// Run after the caller's write returns; nothing the user asked for waits on GitHub.
schedule(() => void drain())
}
})
return () => {
disposed = true
queue.clear()
unsubscribe()
}
}