mirror of
https://github.com/stablyai/orca.git
synced 2026-10-21 16:03:26 +00:00
The Chinese IME fix (#6396) added a third clause to shouldSuppressTerminalImeKeyboardEvent that swallows IME-owned editing keys (Backspace, Enter, arrows, etc.) whenever a composition is active, for ANY IME. This is correct for CJK candidate-window editing, but it breaks Vietnamese Telex/VNI, which compose inline and use Backspace mid-composition to rebuild a base char into its accented form (aa -> â, chaof -> chào). Those Backspaces were swallowed before reaching xterm/PTY, dropping or garbling diacritics. Gate clause 3 to CJK input sources via the existing macCjkInputSourceTracker (null on non-Mac, so Windows/Linux fall through to the universal isComposing / keyCode===229 paths unchanged). Clauses 1 and 2 are Chromium per-event flags valid for all IMEs and are left untouched, so Chinese Pinyin candidate selection is preserved. Fixes #6494 Co-authored-by: Orca <help@stably.ai>