mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 09:07:40 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
662 lines
25 KiB
TypeScript
662 lines
25 KiB
TypeScript
import { spawn } from 'node:child_process'
|
||
import { chmodSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs'
|
||
import { join } from 'node:path'
|
||
import { tmpdir } from 'node:os'
|
||
|
||
import { afterEach, describe, expect, it, vi } from 'vitest'
|
||
|
||
import { getDefaultRepoHookSettings } from './constants'
|
||
import {
|
||
createSequencedSetupAgentCommands,
|
||
createSetupAgentSequenceNonce,
|
||
SETUP_COMPLETE_MESSAGE,
|
||
resolveSetupAgentSequenceLaunchCommand,
|
||
SETUP_AGENT_SEQUENCE_STARTUP_COMMAND_ENV,
|
||
SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV
|
||
} from './setup-agent-sequencing'
|
||
import { shouldWaitForSetupBeforeAgentStartup } from './setup-agent-startup-policy'
|
||
|
||
const TEMP_DIRS: string[] = []
|
||
const WINDOWS_PROCESS_TEST_TIMEOUT_MS = 30_000
|
||
|
||
afterEach(() => {
|
||
for (const dir of TEMP_DIRS.splice(0)) {
|
||
rmSync(dir, { recursive: true, force: true })
|
||
}
|
||
})
|
||
|
||
describe('createSequencedSetupAgentCommands', () => {
|
||
it('defaults agent startup to immediate unless the wait policy is explicit', () => {
|
||
expect(getDefaultRepoHookSettings().setupAgentStartupPolicy).toBe('start-immediately')
|
||
expect(shouldWaitForSetupBeforeAgentStartup(undefined)).toBe(false)
|
||
expect(shouldWaitForSetupBeforeAgentStartup('start-immediately')).toBe(false)
|
||
expect(shouldWaitForSetupBeforeAgentStartup('wait-for-setup')).toBe(true)
|
||
})
|
||
|
||
it('uses the original sequenced startup command as the launch hint when present', () => {
|
||
expect(
|
||
resolveSetupAgentSequenceLaunchCommand(
|
||
{ [SETUP_AGENT_SEQUENCE_STARTUP_COMMAND_ENV]: 'omp --resume' },
|
||
'powershell wait-wrapper'
|
||
)
|
||
).toBe('omp --resume')
|
||
expect(
|
||
resolveSetupAgentSequenceLaunchCommand(
|
||
{ [SETUP_AGENT_SEQUENCE_STARTUP_COMMAND_ENV]: ' ' },
|
||
'powershell wait-wrapper'
|
||
)
|
||
).toBe('powershell wait-wrapper')
|
||
})
|
||
|
||
it('wraps POSIX setup and startup commands with a matching nonce marker', () => {
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: '/repo/.git/orca/setup-runner.sh',
|
||
startupCommand: "codex 'fix bug'",
|
||
platform: 'posix',
|
||
nonce: 'nonce-123',
|
||
waitTimeoutSeconds: 9
|
||
})
|
||
|
||
expect(result.setupCommand).toMatch(/^bash -lc /)
|
||
expect(result.setupCommand).toContain('bash /repo/.git/orca/setup-runner.sh')
|
||
expect(result.setupCommand).toContain('printf')
|
||
expect(result.setupCommand).toContain('nonce-123 "$status"')
|
||
expect(result.setupCommand).toContain(
|
||
'mv -f /repo/.git/orca/setup-runner.sh.nonce-123.done.tmp'
|
||
)
|
||
const startupScript = result.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]
|
||
expect(result.startupCommand).toBe(
|
||
`bash -lc 'eval "$${SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV}"'`
|
||
)
|
||
expect(startupScript).toContain('deadline=$((SECONDS + 9))')
|
||
expect(startupScript).not.toContain('date +%s')
|
||
expect(startupScript).toContain('Waiting for setup to finish before starting agent...')
|
||
expect(startupScript).toContain('[ "$seen" = nonce-123 ]')
|
||
expect(startupScript).toContain(
|
||
'rm -f /repo/.git/orca/setup-runner.sh.nonce-123.done /repo/.git/orca/setup-runner.sh.nonce-123.done.tmp'
|
||
)
|
||
expect(startupScript).toContain('exec codex')
|
||
expect(startupScript).toContain('fix bug')
|
||
expect(result.startupEnv).toEqual(
|
||
expect.objectContaining({
|
||
[SETUP_AGENT_SEQUENCE_STARTUP_COMMAND_ENV]: "codex 'fix bug'",
|
||
[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]: startupScript
|
||
})
|
||
)
|
||
})
|
||
|
||
it('announces success so the pane stops showing the waiting line', () => {
|
||
const commands = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: '/repo/.git/orca/setup-runner.sh',
|
||
startupCommand: 'codex',
|
||
platform: 'posix',
|
||
nonce: 'nonce-1'
|
||
})
|
||
const script = commands.startupEnv?.ORCA_SEQUENCED_STARTUP_SCRIPT ?? ''
|
||
// Why ordering: `eval`/`exec` never returns, so a later message never renders.
|
||
expect(script.indexOf(SETUP_COMPLETE_MESSAGE)).toBeGreaterThan(-1)
|
||
expect(script.indexOf(SETUP_COMPLETE_MESSAGE)).toBeLessThan(
|
||
script.indexOf('eval "$ORCA_SEQUENCED_STARTUP_COMMAND"')
|
||
)
|
||
})
|
||
|
||
it('announces success on the native Windows gate too', () => {
|
||
const commands = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: 'C:\\repo\\.git\\orca\\setup-runner.cmd',
|
||
platform: 'windows',
|
||
startupCommand: 'codex',
|
||
nonce: 'nonce-2'
|
||
})
|
||
const decoded = Buffer.from(
|
||
commands.startupCommand.split('-EncodedCommand ')[1] ?? '',
|
||
'base64'
|
||
).toString('utf16le')
|
||
expect(decoded).toContain(SETUP_COMPLETE_MESSAGE)
|
||
expect(decoded.indexOf(SETUP_COMPLETE_MESSAGE)).toBeLessThan(
|
||
decoded.indexOf('Invoke-Expression $startup')
|
||
)
|
||
})
|
||
|
||
it('doubles typographic single quotes in native Windows gate literals', () => {
|
||
const commands = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: 'C:\\O\u2019Brien\\.git\\orca\\setup-runner.cmd',
|
||
platform: 'windows',
|
||
startupCommand: 'codex',
|
||
nonce: 'nonce-3'
|
||
})
|
||
const decoded = Buffer.from(
|
||
commands.setupCommand.split('-EncodedCommand ')[1] ?? '',
|
||
'base64'
|
||
).toString('utf16le')
|
||
expect(decoded).toContain("$runner = 'C:\\O\u2019\u2019Brien\\.git\\orca\\setup-runner.cmd'")
|
||
})
|
||
|
||
it('leaves the failure and timeout messages as the only other outcomes', () => {
|
||
const script =
|
||
createSequencedSetupAgentCommands({
|
||
runnerScriptPath: '/repo/.git/orca/setup-runner.sh',
|
||
startupCommand: 'codex',
|
||
platform: 'posix',
|
||
nonce: 'nonce-3'
|
||
}).startupEnv?.ORCA_SEQUENCED_STARTUP_SCRIPT ?? ''
|
||
// Silence on success is what made a healthy worktree look stuck.
|
||
expect(script).toContain(SETUP_COMPLETE_MESSAGE)
|
||
expect(script).toContain('Setup failed; skipping agent startup.')
|
||
expect(script).toContain('Timed out waiting for setup before starting agent.')
|
||
})
|
||
|
||
it('keeps the POSIX terminal submission below the canonical input floor', () => {
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: `/repo/${'nested-worktree/'.repeat(100)}setup-runner.sh`,
|
||
startupCommand: 'codex',
|
||
platform: 'posix',
|
||
nonce: 'long-path'
|
||
})
|
||
|
||
expect(result.startupCommand.length).toBeLessThan(256)
|
||
expect(result.startupCommand).not.toContain('nested-worktree')
|
||
expect(result.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]).toContain(
|
||
'nested-worktree'
|
||
)
|
||
})
|
||
|
||
it('uses launch-specific marker paths for overlapping setup gates', () => {
|
||
const first = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: '/repo/.git/orca/setup-runner.sh',
|
||
startupCommand: 'claude',
|
||
platform: 'posix',
|
||
nonce: 'first-launch'
|
||
})
|
||
const second = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: '/repo/.git/orca/setup-runner.sh',
|
||
startupCommand: 'codex',
|
||
platform: 'posix',
|
||
nonce: 'second-launch'
|
||
})
|
||
|
||
expect(first.setupCommand).toContain('/repo/.git/orca/setup-runner.sh.first-launch.done')
|
||
expect(first.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]).toContain(
|
||
'/repo/.git/orca/setup-runner.sh.first-launch.done'
|
||
)
|
||
expect(second.setupCommand).toContain('/repo/.git/orca/setup-runner.sh.second-launch.done')
|
||
expect(second.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]).toContain(
|
||
'/repo/.git/orca/setup-runner.sh.second-launch.done'
|
||
)
|
||
expect(first.setupCommand).not.toContain('/repo/.git/orca/setup-runner.sh.second-launch.done')
|
||
expect(second.setupCommand).not.toContain('/repo/.git/orca/setup-runner.sh.first-launch.done')
|
||
})
|
||
|
||
it('keeps simple POSIX startup commands eligible for exec when quoted text has separators', () => {
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: '/repo/.git/orca/setup-runner.sh',
|
||
startupCommand: "codex 'fix this; then test'",
|
||
platform: 'posix',
|
||
nonce: 'nonce-quoted',
|
||
waitTimeoutSeconds: 9
|
||
})
|
||
|
||
const startupScript = result.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]
|
||
expect(startupScript).toContain("exec codex 'fix this; then test'")
|
||
expect(startupScript).not.toContain('eval codex')
|
||
})
|
||
|
||
it('preserves POSIX inline environment assignment startup commands', () => {
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: '/repo/.git/orca/setup-runner.sh',
|
||
startupCommand: 'FOO=bar claude',
|
||
platform: 'posix',
|
||
nonce: 'nonce-env',
|
||
waitTimeoutSeconds: 9
|
||
})
|
||
|
||
const startupScript = result.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]
|
||
expect(startupScript).toContain('FOO=bar claude')
|
||
expect(startupScript).toContain('exit "$?"')
|
||
expect(startupScript).not.toContain('exec FOO=bar claude')
|
||
})
|
||
|
||
it('uses the converted Linux marker path for WSL UNC runners on Windows', () => {
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath:
|
||
'\\\\wsl.localhost\\Ubuntu\\home\\jin\\repo\\.git\\worktrees\\feature\\orca\\setup-runner.sh',
|
||
startupCommand: 'claude',
|
||
platform: 'windows',
|
||
nonce: 'nonce-wsl'
|
||
})
|
||
|
||
expect(result.setupCommand).toContain(
|
||
'bash /home/jin/repo/.git/worktrees/feature/orca/setup-runner.sh'
|
||
)
|
||
expect(result.setupCommand).toContain(
|
||
'/home/jin/repo/.git/worktrees/feature/orca/setup-runner.sh.nonce-wsl.done'
|
||
)
|
||
expect(result.setupCommand).not.toContain('wsl.localhost')
|
||
})
|
||
|
||
it('keeps remote POSIX runners in bash even from a Windows client', () => {
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: '/remote/repo/.git/worktrees/feature/orca/setup-runner.sh',
|
||
startupCommand: 'claude',
|
||
platform: 'windows',
|
||
nonce: 'nonce-remote'
|
||
})
|
||
|
||
expect(result.setupCommand).toContain(
|
||
'bash /remote/repo/.git/worktrees/feature/orca/setup-runner.sh'
|
||
)
|
||
expect(result.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]).toContain(
|
||
'[ "$seen" = nonce-remote ]'
|
||
)
|
||
})
|
||
|
||
it('preserves WSL shell metadata when sequencing native Windows runners', () => {
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: 'C:\\repo\\.git\\orca\\setup-runner.sh',
|
||
startupCommand: 'claude',
|
||
platform: 'windows',
|
||
shell: { family: 'posix', executable: 'wsl.exe' },
|
||
nonce: 'nonce-wsl-shell'
|
||
})
|
||
|
||
expect(result.setupCommand).toContain('bash /mnt/c/repo/.git/orca/setup-runner.sh')
|
||
expect(result.setupCommand).toContain(
|
||
'/mnt/c/repo/.git/orca/setup-runner.sh.nonce-wsl-shell.done'
|
||
)
|
||
expect(result.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]).toContain(
|
||
'/mnt/c/repo/.git/orca/setup-runner.sh.nonce-wsl-shell.done'
|
||
)
|
||
})
|
||
|
||
it('wraps native Windows runners in a cmd-pinned setup and startup gate', () => {
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: 'C:\\repo\\.git\\orca\\setup-runner.cmd',
|
||
startupCommand: "codex --model gpt-5 'fix !PATH! & test'",
|
||
platform: 'windows',
|
||
nonce: 'nonce-win',
|
||
waitTimeoutSeconds: 3
|
||
})
|
||
const setupPowerShell = decodePowerShellScript(result.setupCommand)
|
||
const startupPowerShell = decodePowerShellScript(result.startupCommand)
|
||
|
||
expect(result.setupCommand).toContain(
|
||
'powershell.exe -NoProfile -NonInteractive -EncodedCommand'
|
||
)
|
||
expect(setupPowerShell).toContain("$runner = 'C:\\repo\\.git\\orca\\setup-runner.cmd'")
|
||
expect(setupPowerShell).toContain('$nonce + ":" + $setupStatus')
|
||
expect(result.startupCommand.match(/powershell\.exe/g)).toHaveLength(1)
|
||
expect(result.startupCommand).toContain(
|
||
'powershell.exe -NoProfile -NonInteractive -EncodedCommand'
|
||
)
|
||
expect(startupPowerShell).toContain('AddSeconds(3)')
|
||
expect(startupPowerShell).toContain('Missing setup marker path.')
|
||
expect(startupPowerShell).toContain('Timed out waiting for setup before starting agent.')
|
||
expect(startupPowerShell).toContain('Setup failed; skipping agent startup.')
|
||
expect(startupPowerShell).toContain(
|
||
'Remove-Item -LiteralPath $marker, $tmp -Force -ErrorAction SilentlyContinue'
|
||
)
|
||
expect(result.startupCommand).not.toContain('%ERRORLEVEL%')
|
||
expect(startupPowerShell).toContain('Invoke-Expression')
|
||
expect(result.startupCommand).not.toContain('fix !PATH! & test')
|
||
expect(result.startupEnv).toEqual({
|
||
[SETUP_AGENT_SEQUENCE_STARTUP_COMMAND_ENV]: "codex --model gpt-5 'fix !PATH! & test'"
|
||
})
|
||
// EncodedCommand is not policy-gated; command-line ExecutionPolicy Bypass was a no-op with an EDR-heavy shape.
|
||
// Keep base64 because terminal panes reparse these strings.
|
||
expect(result.setupCommand).not.toMatch(/-ExecutionPolicy/i)
|
||
expect(result.startupCommand).not.toMatch(/-ExecutionPolicy/i)
|
||
// User startup may invoke policy-gated .ps1; move relief inside the payload instead of deleting it.
|
||
expect(startupPowerShell).toContain(
|
||
'Set-ExecutionPolicy -Scope Process -ExecutionPolicy Bypass -Force -ErrorAction Stop'
|
||
)
|
||
// Stop routes autoload failures (e.g. duplicate PS5.1 type data) to a reporting catch.
|
||
// Report without rethrowing so broken policy cmdlets cannot abort startup.
|
||
expect(startupPowerShell).not.toContain('catch {}')
|
||
expect(startupPowerShell).toMatch(/catch \{ \[Console\]::Error\.WriteLine\(/)
|
||
expect(startupPowerShell).toContain('$_.FullyQualifiedErrorId')
|
||
expect(startupPowerShell).not.toMatch(/catch \{[^}]*throw/)
|
||
// Why: the autoloaded module's progress record would otherwise corrupt this gate's stderr.
|
||
expect(startupPowerShell).toContain("$ProgressPreference = 'SilentlyContinue'")
|
||
expect(startupPowerShell).toContain('$ProgressPreference = $orcaProgress')
|
||
// The setup gate only ever launches a .cmd/.bat runner, so it needs no relief.
|
||
expect(setupPowerShell).not.toMatch(/Set-ExecutionPolicy/i)
|
||
})
|
||
|
||
it('launches a batch runner through the cmd launcher inside a Git Bash gate', () => {
|
||
// Batch setup stays a cmd runner inside Git Bash; the gate remains bash to parse the already-POSIX-quoted startup command (#6896).
|
||
const result = createSequencedSetupAgentCommands({
|
||
runnerScriptPath: 'C:\\repo\\.git\\orca\\setup-runner.cmd',
|
||
startupCommand: "claude 'fix the user'\\''s login'",
|
||
platform: 'windows',
|
||
shell: { family: 'posix' },
|
||
nonce: 'nonce-gitbash-cmd'
|
||
})
|
||
|
||
expect(result.setupCommand).toContain(
|
||
'powershell.exe -NoProfile -NonInteractive -EncodedCommand'
|
||
)
|
||
expect(result.setupCommand).not.toMatch(/bash\s+\S*setup-runner/)
|
||
expect(decodePowerShellScript(result.setupCommand)).toContain(
|
||
"$runner = 'C:\\repo\\.git\\orca\\setup-runner.cmd'"
|
||
)
|
||
// PowerShell Invoke-Expression cannot parse POSIX apostrophe escaping; bash must evaluate startup.
|
||
expect(result.setupCommand).toMatch(/^bash -lc /)
|
||
expect(result.startupCommand).toMatch(/^bash -lc /)
|
||
expect(result.startupCommand).not.toContain('Invoke-Expression')
|
||
expect(result.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]).toContain(
|
||
'eval "$ORCA_SEQUENCED_STARTUP_COMMAND"'
|
||
)
|
||
// Why: bash writes and reads the marker here, so it needs the /c/... form of the path.
|
||
expect(result.setupCommand).toContain(
|
||
'/c/repo/.git/orca/setup-runner.cmd.nonce-gitbash-cmd.done'
|
||
)
|
||
expect(result.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]).toContain(
|
||
'/c/repo/.git/orca/setup-runner.cmd.nonce-gitbash-cmd.done'
|
||
)
|
||
})
|
||
|
||
it.skipIf(process.platform !== 'win32')(
|
||
'executes the native Windows setup-to-agent sequence through cmd.exe',
|
||
async () => {
|
||
const tempDir = join(makeTempDir(), 'path with spaces')
|
||
mkdirSync(tempDir)
|
||
const runnerScriptPath = join(tempDir, 'setup runner.cmd')
|
||
const startupScriptPath = join(tempDir, 'agent-startup.cmd')
|
||
const logPath = join(tempDir, 'sequence.log')
|
||
|
||
writeFileSync(
|
||
runnerScriptPath,
|
||
['@echo off', `>> "${logPath}" echo setup-done`, 'exit /b 0'].join('\r\n'),
|
||
'utf8'
|
||
)
|
||
writeFileSync(
|
||
startupScriptPath,
|
||
['@echo off', `>> "${logPath}" echo agent-start`, 'exit /b 0'].join('\r\n'),
|
||
'utf8'
|
||
)
|
||
|
||
const commands = createSequencedSetupAgentCommands({
|
||
runnerScriptPath,
|
||
startupCommand: `cmd.exe /d /c "${startupScriptPath}"`,
|
||
platform: 'windows',
|
||
nonce: 'windows-sequence',
|
||
waitTimeoutSeconds: 2
|
||
})
|
||
|
||
const setupExit = await waitForExit(
|
||
spawnWindowsCommand(tempDir, 'run-setup.cmd', commands.setupCommand)
|
||
)
|
||
expect(setupExit.code).toBe(0)
|
||
expect(readIfExists(`${runnerScriptPath}.windows-sequence.done`)).toBe(
|
||
'windows-sequence:0\r\n'
|
||
)
|
||
|
||
const startupExit = await waitForExit(
|
||
spawnWindowsCommand(
|
||
tempDir,
|
||
'run-startup.cmd',
|
||
commands.startupCommand,
|
||
commands.startupEnv
|
||
)
|
||
)
|
||
|
||
expect(startupExit.code).toBe(0)
|
||
expect(startupExit.stderr).toContain('Waiting for setup to finish before starting agent...')
|
||
expect(readFileSync(logPath, 'utf8')).toBe('setup-done\r\nagent-start\r\n')
|
||
},
|
||
WINDOWS_PROCESS_TEST_TIMEOUT_MS
|
||
)
|
||
|
||
it.skipIf(process.platform === 'win32')(
|
||
'ignores stale markers until the matching setup run finishes, even when startup launches first',
|
||
async () => {
|
||
const tempDir = makeTempDir()
|
||
const runnerScriptPath = join(tempDir, 'setup-runner.sh')
|
||
const startupScriptPath = join(tempDir, 'startup.sh')
|
||
const logPath = join(tempDir, 'sequence.log')
|
||
const markerPath = `${runnerScriptPath}.fresh-sequence.done`
|
||
|
||
writeExecutable(
|
||
runnerScriptPath,
|
||
[
|
||
'#!/bin/sh',
|
||
`printf 'setup-start\\n' >> ${quoteSh(logPath)}`,
|
||
'sleep 1',
|
||
`printf 'setup-done\\n' >> ${quoteSh(logPath)}`
|
||
].join('\n')
|
||
)
|
||
writeExecutable(
|
||
startupScriptPath,
|
||
['#!/bin/sh', `printf 'agent-start\\n' >> ${quoteSh(logPath)}`].join('\n')
|
||
)
|
||
writeFileSync(markerPath, 'stale:0\n', 'utf8')
|
||
|
||
const commands = createSequencedSetupAgentCommands({
|
||
runnerScriptPath,
|
||
startupCommand: `bash ${quoteSh(startupScriptPath)}`,
|
||
platform: 'posix',
|
||
nonce: 'fresh-sequence',
|
||
waitTimeoutSeconds: 5
|
||
})
|
||
|
||
const startupExitPromise = waitForExit(
|
||
spawn('bash', ['-lc', commands.startupCommand], {
|
||
stdio: 'pipe',
|
||
env: { ...process.env, ...commands.startupEnv }
|
||
})
|
||
)
|
||
await sleep(250)
|
||
expect(readIfExists(logPath)).toBe('')
|
||
expect(readFileSync(markerPath, 'utf8')).toBe('stale:0\n')
|
||
|
||
const setupExit = await waitForExit(
|
||
spawn('bash', ['-lc', commands.setupCommand], { stdio: 'pipe' })
|
||
)
|
||
expect(setupExit.code).toBe(0)
|
||
|
||
const startupExit = await startupExitPromise
|
||
expect(startupExit.code).toBe(0)
|
||
|
||
expect(readFileSync(logPath, 'utf8')).toBe('setup-start\nsetup-done\nagent-start\n')
|
||
expect(readIfExists(markerPath)).toBe('')
|
||
expect(readIfExists(`${markerPath}.tmp`)).toBe('')
|
||
}
|
||
)
|
||
|
||
it.skipIf(process.platform === 'win32')(
|
||
'runs compound POSIX startup cleanup commands after setup succeeds',
|
||
async () => {
|
||
const tempDir = makeTempDir()
|
||
const runnerScriptPath = join(tempDir, 'setup-runner.sh')
|
||
const logPath = join(tempDir, 'sequence.log')
|
||
|
||
writeExecutable(
|
||
runnerScriptPath,
|
||
['#!/bin/sh', `printf 'setup-done\\n' >> ${quoteSh(logPath)}`].join('\n')
|
||
)
|
||
|
||
const commands = createSequencedSetupAgentCommands({
|
||
runnerScriptPath,
|
||
startupCommand: `printf 'agent-start\\n' >> ${quoteSh(logPath)}; printf 'cleanup\\n' >> ${quoteSh(logPath)}`,
|
||
platform: 'posix',
|
||
nonce: 'compound-sequence',
|
||
waitTimeoutSeconds: 5
|
||
})
|
||
|
||
const setupExitPromise = waitForExit(
|
||
spawn('bash', ['-lc', commands.setupCommand], { stdio: 'pipe' })
|
||
)
|
||
const startupExit = await waitForExit(
|
||
spawn('bash', ['-lc', commands.startupCommand], {
|
||
stdio: 'pipe',
|
||
env: { ...process.env, ...commands.startupEnv }
|
||
})
|
||
)
|
||
const setupExit = await setupExitPromise
|
||
|
||
expect(setupExit.code).toBe(0)
|
||
expect(startupExit.code).toBe(0)
|
||
expect(readFileSync(logPath, 'utf8')).toBe('setup-done\nagent-start\ncleanup\n')
|
||
const startupScript = commands.startupEnv?.[SETUP_AGENT_SEQUENCE_STARTUP_SCRIPT_ENV]
|
||
expect(startupScript).toContain('eval')
|
||
expect(startupScript).not.toContain('exec printf')
|
||
}
|
||
)
|
||
|
||
it.skipIf(process.platform === 'win32')(
|
||
'prefers the env-provided startup command after setup succeeds',
|
||
async () => {
|
||
const tempDir = makeTempDir()
|
||
const runnerScriptPath = join(tempDir, 'setup-runner.sh')
|
||
const startupScriptPath = join(tempDir, 'startup.sh')
|
||
const logPath = join(tempDir, 'sequence.log')
|
||
|
||
writeExecutable(
|
||
runnerScriptPath,
|
||
['#!/bin/sh', `printf 'setup-done\\n' >> ${quoteSh(logPath)}`].join('\n')
|
||
)
|
||
writeExecutable(
|
||
startupScriptPath,
|
||
[
|
||
'#!/bin/sh',
|
||
'if [ "$FOO" = "bar" ]; then',
|
||
` printf 'env-start\\n' >> ${quoteSh(logPath)}`,
|
||
'fi'
|
||
].join('\n')
|
||
)
|
||
|
||
const commands = createSequencedSetupAgentCommands({
|
||
runnerScriptPath,
|
||
startupCommand: `printf 'inline-start\\n' >> ${quoteSh(logPath)}`,
|
||
platform: 'posix',
|
||
nonce: 'env-sequence',
|
||
waitTimeoutSeconds: 5
|
||
})
|
||
|
||
const setupExitPromise = waitForExit(
|
||
spawn('bash', ['-lc', commands.setupCommand], { stdio: 'pipe' })
|
||
)
|
||
const startupExit = await waitForExit(
|
||
spawn('bash', ['-lc', commands.startupCommand], {
|
||
stdio: 'pipe',
|
||
env: {
|
||
...process.env,
|
||
...commands.startupEnv,
|
||
[SETUP_AGENT_SEQUENCE_STARTUP_COMMAND_ENV]: `FOO=bar bash ${quoteSh(startupScriptPath)}; printf 'env-cleanup\\n' >> ${quoteSh(logPath)}`
|
||
}
|
||
})
|
||
)
|
||
const setupExit = await setupExitPromise
|
||
|
||
expect(setupExit.code).toBe(0)
|
||
expect(startupExit.code).toBe(0)
|
||
expect(readFileSync(logPath, 'utf8')).toBe('setup-done\nenv-start\nenv-cleanup\n')
|
||
}
|
||
)
|
||
|
||
it.skipIf(process.platform === 'win32')(
|
||
'times out instead of hanging forever when setup never writes a matching marker',
|
||
async () => {
|
||
const tempDir = makeTempDir()
|
||
const runnerScriptPath = join(tempDir, 'setup-runner.sh')
|
||
|
||
writeExecutable(runnerScriptPath, '#!/bin/sh\nexit 0\n')
|
||
|
||
const commands = createSequencedSetupAgentCommands({
|
||
runnerScriptPath,
|
||
startupCommand: 'printf ready',
|
||
platform: 'posix',
|
||
nonce: 'timeout-sequence',
|
||
waitTimeoutSeconds: 1
|
||
})
|
||
|
||
const startupExit = await waitForExit(
|
||
spawn('bash', ['-lc', commands.startupCommand], {
|
||
stdio: 'pipe',
|
||
env: { ...process.env, ...commands.startupEnv }
|
||
})
|
||
)
|
||
|
||
expect(startupExit.code).toBe(124)
|
||
expect(startupExit.stderr).toContain('Timed out waiting for setup before starting agent.')
|
||
}
|
||
)
|
||
})
|
||
|
||
describe('createSetupAgentSequenceNonce', () => {
|
||
it('prefers crypto.randomUUID when available', () => {
|
||
const originalCrypto = globalThis.crypto
|
||
vi.stubGlobal('crypto', { randomUUID: () => 'uuid-1' })
|
||
|
||
expect(createSetupAgentSequenceNonce()).toBe('uuid-1')
|
||
|
||
vi.stubGlobal('crypto', originalCrypto)
|
||
})
|
||
})
|
||
|
||
function makeTempDir(): string {
|
||
const dir = mkdtempSync(join(tmpdir(), 'orca-setup-sequencing-'))
|
||
TEMP_DIRS.push(dir)
|
||
return dir
|
||
}
|
||
|
||
function writeExecutable(path: string, contents: string): void {
|
||
writeFileSync(path, contents, 'utf8')
|
||
chmodSync(path, 0o755)
|
||
}
|
||
|
||
function quoteSh(value: string): string {
|
||
return `'${value.replace(/'/g, `'\\''`)}'`
|
||
}
|
||
|
||
function readIfExists(path: string): string {
|
||
try {
|
||
return readFileSync(path, 'utf8')
|
||
} catch {
|
||
return ''
|
||
}
|
||
}
|
||
|
||
function sleep(ms: number): Promise<void> {
|
||
return new Promise((resolve) => {
|
||
setTimeout(resolve, ms)
|
||
})
|
||
}
|
||
|
||
function spawnWindowsCommand(
|
||
dir: string,
|
||
filename: string,
|
||
command: string,
|
||
env: Record<string, string> = {}
|
||
): ReturnType<typeof spawn> {
|
||
const scriptPath = join(dir, filename)
|
||
// Avoid /s stripping Node’s batch-path quotes; argv spawning still exercises native cmd parsing.
|
||
writeFileSync(scriptPath, `@echo off\r\n${command}\r\nexit /b %ERRORLEVEL%\r\n`, 'utf8')
|
||
return spawn('cmd.exe', ['/d', '/c', scriptPath], {
|
||
stdio: 'pipe',
|
||
env: { ...process.env, ...env }
|
||
})
|
||
}
|
||
|
||
function decodePowerShellScript(command: string): string {
|
||
const encoded = command.match(/-EncodedCommand\s+([A-Za-z0-9+/=]+)/)?.[1]
|
||
if (!encoded) {
|
||
throw new Error('Missing PowerShell encoded command')
|
||
}
|
||
return Buffer.from(encoded, 'base64').toString('utf16le')
|
||
}
|
||
|
||
function waitForExit(
|
||
child: ReturnType<typeof spawn>
|
||
): Promise<{ code: number | null; stderr: string }> {
|
||
return new Promise((resolve, reject) => {
|
||
let stderr = ''
|
||
child.stderr?.on('data', (chunk: Buffer | string) => {
|
||
stderr += chunk.toString()
|
||
})
|
||
child.once('error', reject)
|
||
child.once('close', (code) => {
|
||
resolve({ code, stderr })
|
||
})
|
||
})
|
||
}
|