mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 09:07:40 +00:00
Kelvin Amoaba
c97e6f16bc
* fix(computer): fail set-value when its read-back shows a different value A value_mismatch came back as ok with exit 0, so callers that check only the exit status took an ignored or misplaced write as success. The runtime now turns it into a verification_failed error at the sidecar boundary, which covers every provider and every caller of the RPC. Part of #33511 * fix(computer): pair macOS AX windows with their CGWindowID AppKit and WebKit windows don't answer AXWindowNumber, so matching a capture to its accessibility window fell back to frames. Two windows with the same frame then paired the screenshot of one with the tree and title of whichever AX listed first, under the first one's id. Read the id with _AXUIElementGetWindow, as yabai and Hammerspoon do, and keep AXWindowNumber as the fallback. Fixes #27252 * fix(computer): fail fast when a macOS app stops answering accessibility Every request runs behind one helper lock, and a hung app cost a timeout per AX read, so one get-app-state on it held every agent for up to the 60 s RPC timeout. Pin the AX messaging timeout at 1.5 s, refuse an app that doesn't answer a root probe, and stop a tree walk at the first read that waits out the timeout, each with an action_timeout error. A press or write that the app received but didn't answer now fails the same way, saying it may have taken effect. Before, the click fell through to AXConfirm and then a synthetic click, so a button whose handler blocked ran twice, and type-text typed the text again as keys. * fix(computer): report macOS accessibility actions that changed nothing AXPress and other accessibility actions came back as plain unasserted success even when the app ignored them, as Chromium does for a role=button whose handler sits on a child. After such an action the helper now compares the target's tree, frame and on-screen windows with the snapshot it took just before. If they still match after re-reading for about a second, the result says unverified/suspected_noop; if they change late, the result carries the settled state instead. The new reason is additive; older CLIs print it like any other reason. Refs #31758 * fix(computer): propagate late macOS observation failures * fix(computer): select existing text before replacement * fix(computer): share native macOS window identity