Files
orca/src/main/github/work-item-details-issue-source.test.ts
T
NeilandKatsuma Takehisa ce07786266 Keep opened issue details and edits in the selected repository (#24729)
Keeps a fork issue’s details, metadata and edits bound to the repository the user opened, including same-number issues in fork and upstream. Repairs selected-assignee leakage and delayed failed edits repainting another issue.

Fixes #24378

Incorporates and cross-reviews contributor PR #24379, including its source-resolver correction and regression material. Covers the contributor PR’s Project-row identity and retained-dialog mutation findings. The final published head passes focused tests, hidden macOS rendering and current CI; the callback-timing bot thread has an evidence-based response.

Co-authored-by: Katsuma Takehisa <k.takehisa@nissogr.com>
2026-10-03 23:19:55 -07:00

240 lines
7.9 KiB
TypeScript

import type * as WorkItemDetailsTestLookup from './work-item-details-test-lookup'
import { beforeEach, describe, expect, it, vi } from 'vitest'
const {
ghExecFileAsyncMock,
getOwnerRepoMock,
getOwnerRepoForRemoteMock,
getWorkItemMock,
getWorkItemByOwnerRepoMock,
acquireMock,
releaseMock
} = vi.hoisted(() => ({
ghExecFileAsyncMock: vi.fn(),
getOwnerRepoMock: vi.fn(),
getOwnerRepoForRemoteMock: vi.fn(),
getWorkItemMock: vi.fn(),
getWorkItemByOwnerRepoMock: vi.fn(),
acquireMock: vi.fn(),
releaseMock: vi.fn()
}))
vi.mock('./gh-utils', () => ({
ghExecFileAsync: ghExecFileAsyncMock,
getOwnerRepo: getOwnerRepoMock,
getOwnerRepoForRemote: getOwnerRepoForRemoteMock,
ghRepoExecOptions: vi.fn((context) => ({ cwd: context.repoPath })),
githubRepoContext: vi.fn((repoPath, connectionId, localGitOptions) => ({
repoPath,
connectionId: connectionId ?? null,
...localGitOptions
})),
acquire: acquireMock,
release: releaseMock
}))
vi.mock('./client', async () => ({
getWorkItem: getWorkItemMock,
getWorkItemWithRepository: (
await vi.importActual<typeof WorkItemDetailsTestLookup>('./work-item-details-test-lookup')
).makeWorkItemDetailsLookupMock(getWorkItemMock),
getWorkItemByOwnerRepo: getWorkItemByOwnerRepoMock,
getPRChecks: vi.fn(),
getPRComments: vi.fn()
}))
vi.mock('./github-enterprise-repository', () => ({
getEnterpriseGitHubRepoSlug: vi.fn().mockResolvedValue(null),
getEnterpriseGitHubRepoSlugForRemote: vi.fn().mockResolvedValue(null),
isGitHubHostAuthenticated: vi.fn().mockResolvedValue(true)
}))
vi.mock('./rate-limit', () => ({
repositoryRateLimitGuard: vi.fn(() => ({ blocked: false })),
noteRepositoryRateLimitSpend: vi.fn()
}))
vi.mock('../git/remote-name-listing', () => ({
shouldProbeGitRemote: vi.fn().mockResolvedValue(true)
}))
import { getWorkItemDetails } from './work-item-details'
import { _resetOriginGitHubApiRepositoryCache } from './github-api-repository'
const REMOTES: Record<string, { owner: string; repo: string }> = {
origin: { owner: 'fork-owner', repo: 'widgets' },
upstream: { owner: 'upstream-owner', repo: 'widgets' }
}
function graphQLIssueResponse(assignee: string): { stdout: string } {
return {
stdout: JSON.stringify({
data: {
repository: {
issue: {
body: `${assignee} body`,
assignees: { nodes: [{ login: assignee }] },
participants: { nodes: [] },
comments: { nodes: [] }
}
}
}
})
}
}
function graphQLOwnerArg(): string | undefined {
const args: string[] = ghExecFileAsyncMock.mock.calls[0][0]
return args.find((arg) => arg.startsWith('owner='))
}
describe('getWorkItemDetails issue source', () => {
beforeEach(() => {
_resetOriginGitHubApiRepositoryCache()
ghExecFileAsyncMock.mockReset()
getOwnerRepoMock.mockReset()
getOwnerRepoMock.mockResolvedValue(REMOTES.origin)
getOwnerRepoForRemoteMock.mockReset()
getOwnerRepoForRemoteMock.mockImplementation(
async (_repoPath: string, remoteName: string) => REMOTES[remoteName] ?? null
)
getWorkItemMock.mockReset()
getWorkItemByOwnerRepoMock.mockReset()
getWorkItemMock.mockResolvedValue({
id: 'issue:5',
type: 'issue',
number: 5,
title: 'Origin issue',
state: 'open',
url: 'https://github.com/fork-owner/widgets/issues/5',
labels: [],
updatedAt: '2026-04-01T00:00:00Z',
author: 'fork-author'
})
acquireMock.mockReset()
acquireMock.mockResolvedValue(undefined)
releaseMock.mockReset()
})
it('reads body, assignees and comments from origin when origin is selected', async () => {
ghExecFileAsyncMock
.mockResolvedValueOnce(graphQLIssueResponse('fork-assignee'))
.mockResolvedValueOnce({ stdout: '' })
const details = await getWorkItemDetails('/repo-root', 5, 'issue', null, {}, 'origin')
expect(getWorkItemMock).toHaveBeenCalledWith('/repo-root', 5, 'issue', null, {}, 'origin')
expect(graphQLOwnerArg()).toBe('owner=fork-owner')
expect(ghExecFileAsyncMock.mock.calls[1][0]).toContain(
'repos/fork-owner/widgets/issues/5/timeline?per_page=100&page=1'
)
expect(details?.assignees).toEqual(['fork-assignee'])
})
it('keeps the upstream-first default when no preference is set', async () => {
ghExecFileAsyncMock
.mockResolvedValueOnce(graphQLIssueResponse('upstream-assignee'))
.mockResolvedValueOnce({ stdout: '' })
const details = await getWorkItemDetails('/repo-root', 5, 'issue', null, {})
expect(graphQLOwnerArg()).toBe('owner=upstream-owner')
expect(details?.assignees).toEqual(['upstream-assignee'])
})
it('keeps a Project row on upstream even when Origin is selected', async () => {
const upstream = { ...REMOTES.upstream, host: 'github.com' }
getWorkItemByOwnerRepoMock.mockResolvedValue({
id: 'issue:5',
type: 'issue',
number: 5,
title: 'Upstream project issue',
url: 'https://github.com/upstream-owner/widgets/issues/5',
state: 'open',
labels: [],
updatedAt: '',
author: 'upstream-author'
})
ghExecFileAsyncMock
.mockResolvedValueOnce(graphQLIssueResponse('upstream-assignee'))
.mockResolvedValueOnce({ stdout: '' })
const details = await getWorkItemDetails('/repo-root', 5, 'issue', null, {}, 'origin', upstream)
expect(getWorkItemMock).not.toHaveBeenCalled()
expect(getWorkItemByOwnerRepoMock).toHaveBeenCalledWith(
'/repo-root',
upstream,
5,
'issue',
null,
{}
)
expect(graphQLOwnerArg()).toBe('owner=upstream-owner')
expect(details?.item.title).toBe('Upstream project issue')
expect(details?.assignees).toEqual(['upstream-assignee'])
})
it('does not fall back when the selected issue repository is unavailable', async () => {
getWorkItemByOwnerRepoMock.mockResolvedValue(null)
await expect(
getWorkItemDetails('/repo-root', 5, 'issue', null, {}, 'upstream', {
...REMOTES.origin,
host: 'github.com'
})
).resolves.toBeNull()
expect(getWorkItemMock).not.toHaveBeenCalled()
expect(ghExecFileAsyncMock).not.toHaveBeenCalled()
})
it('rejects an invalid runtime issue host before calling the repository lookup', async () => {
await expect(
getWorkItemDetails('/repo-root', 5, 'issue', null, {}, 'upstream', {
...REMOTES.origin,
host: 42
})
).resolves.toBeNull()
expect(getWorkItemByOwnerRepoMock).not.toHaveBeenCalled()
expect(getWorkItemMock).not.toHaveBeenCalled()
expect(ghExecFileAsyncMock).not.toHaveBeenCalled()
})
it('ignores an issue repository override on an untyped lookup', async () => {
ghExecFileAsyncMock
.mockResolvedValueOnce(graphQLIssueResponse('fork-assignee'))
.mockResolvedValueOnce({ stdout: '' })
await getWorkItemDetails('/repo-root', 5, undefined, null, {}, 'origin', {
owner: 'untrusted',
repo: 'other',
host: 'untrusted.example'
})
expect(getWorkItemByOwnerRepoMock).not.toHaveBeenCalled()
expect(graphQLOwnerArg()).toBe('owner=fork-owner')
expect(ghExecFileAsyncMock.mock.calls[0][1]).toMatchObject({ host: 'github.com' })
})
it('normalizes host-less issue targets before loading the conversation', async () => {
getWorkItemByOwnerRepoMock.mockResolvedValue({
type: 'issue',
number: 5,
title: 'Origin issue',
url: 'https://github.com/fork-owner/widgets/issues/5',
author: null
})
ghExecFileAsyncMock
.mockResolvedValueOnce(graphQLIssueResponse('fork-assignee'))
.mockResolvedValueOnce({ stdout: '' })
await getWorkItemDetails('/repo-root', 5, 'issue', null, {}, 'upstream', REMOTES.origin)
expect(graphQLOwnerArg()).toBe('owner=fork-owner')
expect(ghExecFileAsyncMock.mock.calls[0][1]).toMatchObject({ host: 'github.com' })
expect(ghExecFileAsyncMock.mock.calls[1][1]).toMatchObject({ host: 'github.com' })
})
})