mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 00:02:31 +00:00
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
62 lines
1.9 KiB
TypeScript
62 lines
1.9 KiB
TypeScript
import { resolve } from 'node:path'
|
|
import type { Store } from '../persistence'
|
|
import {
|
|
getLocalProjectWorktreeGitOptions,
|
|
type LocalProjectWorktreeGitOptions
|
|
} from '../project-runtime-git-options'
|
|
import { splitWorktreeId } from '../../shared/worktree-id'
|
|
|
|
function comparableLocalPath(value: string): string {
|
|
const normalized = resolve(value)
|
|
return process.platform === 'win32' ? normalized.toLowerCase() : normalized
|
|
}
|
|
|
|
function getCandidateLocalWorktreePaths(
|
|
worktreePath: string,
|
|
resolvedWorktreePath: string
|
|
): Set<string> {
|
|
return new Set([worktreePath, resolvedWorktreePath].map(comparableLocalPath))
|
|
}
|
|
|
|
function hasRegisteredWorktreeMetaForRepo(
|
|
store: Store,
|
|
repoId: string,
|
|
candidatePaths: Set<string>
|
|
): boolean {
|
|
const worktreeMeta =
|
|
typeof store.getAllWorktreeMeta === 'function' ? store.getAllWorktreeMeta() : {}
|
|
for (const worktreeId of Object.keys(worktreeMeta)) {
|
|
const parsed = splitWorktreeId(worktreeId)
|
|
if (parsed?.repoId === repoId && candidatePaths.has(comparableLocalPath(parsed.worktreePath))) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
export function getLocalGitOptionsForRegisteredWorktree(
|
|
store: Store,
|
|
worktreePath: string,
|
|
resolvedWorktreePath: string
|
|
): LocalProjectWorktreeGitOptions {
|
|
if (typeof store.getProjects !== 'function' || typeof store.getSettings !== 'function') {
|
|
return {}
|
|
}
|
|
|
|
const candidatePaths = getCandidateLocalWorktreePaths(worktreePath, resolvedWorktreePath)
|
|
for (const repo of store.getRepos()) {
|
|
if (repo.connectionId) {
|
|
continue
|
|
}
|
|
if (
|
|
candidatePaths.has(comparableLocalPath(repo.path)) ||
|
|
hasRegisteredWorktreeMetaForRepo(store, repo.id, candidatePaths)
|
|
) {
|
|
// Why: file discovery must use the same resolved runtime as project git,
|
|
// terminals, and agents even when the worktree path is a Windows path.
|
|
return getLocalProjectWorktreeGitOptions(store, repo)
|
|
}
|
|
}
|
|
return {}
|
|
}
|