mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 08:02:28 +00:00
NeilandOrca
46646d7ff1
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
82 lines
2.7 KiB
TypeScript
82 lines
2.7 KiB
TypeScript
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest'
|
|
import { __resetShellStartupEnvCache } from '../main/pty/shell-startup-env'
|
|
import { resolveOpenCodeSourceConfigDir, resolvePiSourceAgentDir } from './plugin-overlay-env'
|
|
|
|
describe('plugin overlay env source resolution', () => {
|
|
let homeDir: string
|
|
|
|
beforeEach(() => {
|
|
homeDir = mkdtempSync(join(tmpdir(), 'relay-plugin-overlay-env-'))
|
|
__resetShellStartupEnvCache()
|
|
})
|
|
|
|
afterEach(() => {
|
|
rmSync(homeDir, { recursive: true, force: true })
|
|
__resetShellStartupEnvCache()
|
|
})
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'uses zsh startup exports before inherited public overlay env',
|
|
() => {
|
|
mkdirSync(join(homeDir, 'company-opencode'), { recursive: true })
|
|
mkdirSync(join(homeDir, 'company-pi'), { recursive: true })
|
|
writeFileSync(
|
|
join(homeDir, '.zshrc'),
|
|
[
|
|
'export OPENCODE_CONFIG_DIR="$HOME/company-opencode"',
|
|
'export PI_CODING_AGENT_DIR="$HOME/company-pi"'
|
|
].join('\n')
|
|
)
|
|
|
|
const env = {
|
|
HOME: homeDir,
|
|
OPENCODE_CONFIG_DIR: '/tmp/inherited-opencode-overlay',
|
|
PI_CODING_AGENT_DIR: '/tmp/inherited-pi-overlay'
|
|
}
|
|
|
|
expect(resolveOpenCodeSourceConfigDir(env, '/bin/zsh')).toBe(
|
|
join(homeDir, 'company-opencode')
|
|
)
|
|
expect(resolvePiSourceAgentDir(env, '/bin/zsh', 'pi')).toBe(join(homeDir, 'company-pi'))
|
|
}
|
|
)
|
|
|
|
it.skipIf(process.platform === 'win32')(
|
|
'discovers overlay sources from a custom zsh ZDOTDIR',
|
|
() => {
|
|
const zshDir = join(homeDir, '.config', 'zsh')
|
|
mkdirSync(zshDir, { recursive: true })
|
|
writeFileSync(join(homeDir, '.zshenv'), 'export ZDOTDIR="$HOME/.config/zsh"\n')
|
|
writeFileSync(join(zshDir, '.zshrc'), 'export OPENCODE_CONFIG_DIR="$HOME/opencode-src"\n')
|
|
|
|
expect(
|
|
resolveOpenCodeSourceConfigDir(
|
|
{
|
|
HOME: homeDir,
|
|
OPENCODE_CONFIG_DIR: '/tmp/inherited-opencode-overlay'
|
|
},
|
|
'/bin/zsh'
|
|
)
|
|
).toBe(join(homeDir, 'opencode-src'))
|
|
}
|
|
)
|
|
|
|
it('keeps explicit original-source env ahead of startup hints', () => {
|
|
writeFileSync(join(homeDir, '.zshrc'), 'export OPENCODE_CONFIG_DIR="$HOME/company-opencode"\n')
|
|
|
|
expect(
|
|
resolveOpenCodeSourceConfigDir(
|
|
{
|
|
HOME: homeDir,
|
|
ORCA_OPENCODE_SOURCE_CONFIG_DIR: '/remote/original-opencode',
|
|
OPENCODE_CONFIG_DIR: '/tmp/inherited-opencode-overlay'
|
|
},
|
|
'/bin/zsh'
|
|
)
|
|
).toBe('/remote/original-opencode')
|
|
})
|
|
})
|