mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 16:02:32 +00:00
NeilandOrca
46646d7ff1
* chore(lint): upgrade oxlint to 1.71 and enable 7 new rules Upgrade oxlint 1.67.0 -> 1.71.0 (1.72 was blocked by the repo's 3-day minimum-release-age supply-chain guard; nothing here needs it). The bump is a no-op on the existing config. Enable 3 error rules (backlog autofixed to zero in this commit) and 4 warn rules (surface signal without gating CI): error (autofixed, behavior-preserving): - unicorn/prefer-node-protocol (~1531 sites: bare builtin -> node:) - typescript/no-import-type-side-effects (~36: all-inline-type -> import type) - unicorn/no-array-reverse (19: copy-then-reverse -> toReversed) warn (real signal, current fires are test-only/correct): - unicorn/no-array-fill-with-reference-type (aliasing footgun guard) - typescript/no-unsafe-function-type (bans bare Function type) - unicorn/prefer-array-flat-map (map().flat() -> flatMap()) - unicorn/prefer-regexp-test (.match() in bool ctx -> .test()) mobile/.oxlintrc.json extends root, so it inherits all 7; the autofix ran from root and covered mobile/ too. Verification (all green): oxlint 0 errors (root+mobile+aux configs), oxfmt clean, typecheck (node+cli+web), vitest 22795 passed / 0 failed, builds (electron-vite + web + cli) succeed. node: rewrites confirmed to skip embedded SSH/CLI string payloads (AST-only); all toReversed sites verified to operate on fresh copies or write-once locals. * chore(lint): bump mobile oxlint to 1.71 so inherited rules parse mobile/ is a standalone pnpm project pinning its own oxlint@1.67, which lacks unicorn/no-array-fill-with-reference-type (needs >=1.70). Since mobile/.oxlintrc.json extends the root config, mobile CI's 'cd mobile && oxlint' failed to parse the new rule. Bump mobile to match root (1.71). Verified in mobile/: oxlint 0 errors, oxfmt --check clean, tsc --noEmit pass, vitest 978 passed / 0 failed. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Orca <help@stably.ai>
60 lines
2.4 KiB
TypeScript
60 lines
2.4 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
import { access, mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises'
|
|
import * as path from 'node:path'
|
|
import { tmpdir } from 'node:os'
|
|
import { removeSafeUntrackedDiscardTarget } from './git-discard-path-safety'
|
|
|
|
const tempRoots: string[] = []
|
|
|
|
async function createWorktree(): Promise<string> {
|
|
const worktreePath = await mkdtemp(path.join(tmpdir(), 'orca-discard-safety-'))
|
|
tempRoots.push(worktreePath)
|
|
return worktreePath
|
|
}
|
|
|
|
afterEach(async () => {
|
|
await Promise.all(tempRoots.splice(0).map((root) => rm(root, { recursive: true, force: true })))
|
|
})
|
|
|
|
describe('removeSafeUntrackedDiscardTarget', () => {
|
|
it('rejects empty and root targets before removing anything', async () => {
|
|
const worktreePath = await createWorktree()
|
|
const keepFile = path.join(worktreePath, 'keep.txt')
|
|
const removePath = vi.fn(async () => undefined)
|
|
await writeFile(keepFile, 'keep')
|
|
|
|
await expect(removeSafeUntrackedDiscardTarget(worktreePath, '', removePath)).rejects.toThrow(
|
|
'resolves outside the worktree'
|
|
)
|
|
await expect(removeSafeUntrackedDiscardTarget(worktreePath, '.', removePath)).rejects.toThrow(
|
|
'resolves outside the worktree'
|
|
)
|
|
await expect(
|
|
removeSafeUntrackedDiscardTarget(worktreePath, 'child/..', removePath)
|
|
).rejects.toThrow('resolves outside the worktree')
|
|
|
|
await expect(access(keepFile)).resolves.toBeUndefined()
|
|
expect(removePath).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('allows missing child paths whose nearest existing parent is the worktree', async () => {
|
|
const worktreePath = await createWorktree()
|
|
const removePath = vi.fn(async () => undefined)
|
|
await mkdir(path.join(worktreePath, 'existing'))
|
|
|
|
await expect(
|
|
removeSafeUntrackedDiscardTarget(worktreePath, 'existing/missing.txt', removePath)
|
|
).resolves.toBeUndefined()
|
|
await expect(
|
|
removeSafeUntrackedDiscardTarget(worktreePath, 'new-dir/missing.txt', removePath)
|
|
).resolves.toBeUndefined()
|
|
await expect(
|
|
removeSafeUntrackedDiscardTarget(worktreePath, 'missing.txt', removePath)
|
|
).resolves.toBeUndefined()
|
|
await expect(access(worktreePath)).resolves.toBeUndefined()
|
|
expect(removePath).toHaveBeenNthCalledWith(1, 'existing/missing.txt')
|
|
expect(removePath).toHaveBeenNthCalledWith(2, 'new-dir/missing.txt')
|
|
expect(removePath).toHaveBeenNthCalledWith(3, 'missing.txt')
|
|
})
|
|
})
|