Files
orca/mobile/src/components/MobileDiffReviewFileSummary.tsx
T
Neil 77f23b013f refactor(shared): drop the shared/types barrel and import from the real modules (#14447)
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as
a re-export barrel so the import sites did not have to change. This removes
the barrel: every consumer now imports from the module that actually declares
the type, and `src/shared/types.ts` is deleted.

Barrels hide where a type lives, make every consumer look like it depends on
the whole domain, and let an unrelated edit invalidate a module that ~2,000
files transitively import.

2,323 import declarations across 2,321 files. Rewritten mechanically: each
specifier was resolved to an absolute path via the TypeScript AST and
recomputed, rather than string-substituted, so alias forms (`@/../../shared/
types`) and per-specifier `type` modifiers survive.

Four cases the mechanical pass had to handle, each found by a gate rather than
by reading the diff:

- Modules inside `src/shared` import the barrel as `./types`, not
  `shared/types`. A pre-filter on the latter string skipped 176 of them and
  left imports dangling at a deleted file, which surfaced as confusing
  `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>`
  errors rather than "module not found".
- The barrel RENAMED one type on the way through
  (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name
  in the owning module has to be re-aliased at each consumer.
- Three test files put `;(globalThis as ...)` on the line after the import.
  TypeScript parses that `;` as the import statement's terminator, so
  replacing through `statement.getEnd()` deletes it and breaks ASI. The
  rewrite now stops at the module specifier.
- A file that already imported directly from a module got a SECOND import
  from it, because the barrel re-exported those same names — which trips
  `import/no-duplicates` under `--deny-warnings`. A post-pass merges
  declarations sharing a specifier and type-only-ness; the `import type` plus
  `import` pair from one module is left alone, since that form is allowed.

Splitting one barrel import into several genuinely adds lines, which pushed
`terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character
import must wrap, and neither local type collapses onto one line (101 and 116
characters). Rather than contort a type declaration to fit a line budget,
`collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` —
they are pure structural operations on the layout tree and independent of PTY
ownership. `visible-worktrees.ts` similarly loses its own mini-barrel
re-export of `isDefaultBranchWorkspace`, with the four real consumers
repointed at the declaring module. No `max-lines` bypass added.

Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted
first — these projects are `composite: true` and reuse stale caches); the full
`pnpm lint` green, not just bare oxlint — the narrower local check is what let
the duplicate imports reach CI; max-lines ratchet OK at 344.
2026-08-13 22:48:24 -07:00

130 lines
4.5 KiB
TypeScript

import { Pressable, Text, View } from 'react-native'
import { ArrowDown, ArrowUp } from 'lucide-react-native'
import type { DiffComment } from '../../../src/shared/diff-comment-types'
import { colors } from '../theme/mobile-theme'
import type { MobileDiffReviewQueueItem } from '../session/mobile-diff-review-queue'
import { MOBILE_GIT_STATUS_LABELS } from '../source-control/mobile-git-status'
import {
mobileReviewCountLabel,
mobileReviewScopeLabel,
type ReviewDiffState
} from '../session/mobile-diff-review-screen-model'
import { mobileDiffReviewStyles as styles } from './mobile-diff-review-screen-styles'
type Props = {
currentIndex: number
diffState: ReviewDiffState
fileNotes: DiffComment[]
filteredCount: number
item: MobileDiffReviewQueueItem
staleCommentIds: ReadonlySet<string>
onEditNote: (comment: DiffComment) => void
onJumpHunk: (direction: 'next' | 'previous') => void
}
function statusColor(status: MobileDiffReviewQueueItem['status']): string {
switch (status) {
case 'added':
case 'copied':
return colors.statusGreen
case 'deleted':
return colors.statusRed
case 'renamed':
return colors.accentBlue
case 'untracked':
return colors.statusAmber
case 'modified':
default:
return colors.textSecondary
}
}
export function MobileDiffReviewFileSummary({
currentIndex,
diffState,
fileNotes,
filteredCount,
item,
staleCommentIds,
onEditNote,
onJumpHunk
}: Props) {
const hunkDisabled = diffState.kind !== 'ready' || diffState.hunks.length === 0
const badgeColor = statusColor(item.status)
return (
<View style={styles.fileHeader}>
<View style={styles.fileTitleRow}>
<View style={[styles.statusBadge, { borderColor: badgeColor }]}>
<Text style={[styles.statusBadgeText, { color: badgeColor }]}>
{MOBILE_GIT_STATUS_LABELS[item.status]}
</Text>
</View>
<View style={styles.fileTitleBlock}>
<Text style={styles.filePath} numberOfLines={1}>
{item.filePath}
</Text>
<Text style={styles.fileMeta} numberOfLines={1}>
{mobileReviewScopeLabel(item)}
{item.oldPath ? ` from ${item.oldPath}` : ''}
</Text>
</View>
</View>
<View style={styles.fileMetaRow}>
<Text style={styles.fileMeta}>
{currentIndex + 1}/{filteredCount}
</Text>
{item.isReviewed ? <Text style={styles.reviewedPill}>Reviewed</Text> : null}
{item.changedSinceReview ? <Text style={styles.stalePill}>Changed</Text> : null}
{item.noteCount > 0 ? (
<Text style={styles.fileMeta}>
{mobileReviewCountLabel(item.noteCount, 'note', 'notes')}
</Text>
) : null}
{item.staleNoteCount > 0 ? (
<Text style={styles.staleText}>{item.staleNoteCount} stale</Text>
) : null}
</View>
{fileNotes.length > 0 ? (
<View style={styles.fileNotes}>
{fileNotes.map((note) => (
<Pressable
key={note.id}
style={({ pressed }) => [styles.fileNote, pressed && styles.fileNotePressed]}
onPress={() => onEditNote(note)}
accessibilityRole="button"
accessibilityLabel="Edit file note"
>
<Text style={styles.fileNoteText} numberOfLines={2}>
{note.body}
</Text>
{staleCommentIds.has(note.id) ? <Text style={styles.staleText}>Stale</Text> : null}
</Pressable>
))}
</View>
) : null}
<View style={styles.hunkRow}>
<Pressable
style={({ pressed }) => [styles.hunkButton, pressed && styles.hunkButtonPressed]}
disabled={hunkDisabled}
onPress={() => onJumpHunk('previous')}
accessibilityRole="button"
accessibilityLabel="Previous hunk"
>
<ArrowUp size={14} color={colors.textSecondary} strokeWidth={2.2} />
<Text style={styles.hunkButtonText}>Hunk</Text>
</Pressable>
<Pressable
style={({ pressed }) => [styles.hunkButton, pressed && styles.hunkButtonPressed]}
disabled={hunkDisabled}
onPress={() => onJumpHunk('next')}
accessibilityRole="button"
accessibilityLabel="Next hunk"
>
<ArrowDown size={14} color={colors.textSecondary} strokeWidth={2.2} />
<Text style={styles.hunkButtonText}>Hunk</Text>
</Pressable>
</View>
</View>
)
}