mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 17:17:38 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
381 lines
13 KiB
JavaScript
381 lines
13 KiB
JavaScript
import { globSync, readFileSync } from 'node:fs'
|
|
import path from 'node:path'
|
|
import { pathToFileURL } from 'node:url'
|
|
import ts from 'typescript-api'
|
|
import {
|
|
diffCounts,
|
|
parseCountBaseline,
|
|
pruneCountBaseline,
|
|
totalCount
|
|
} from './ratchet-baseline.mjs'
|
|
import { literalString, propertyName, unwrap } from './static-module-specifiers.mjs'
|
|
import { isTestOnlySourcePath } from './test-only-source-path.mjs'
|
|
|
|
// Synchronous launches freeze all Electron windows; Windows antivirus magnifies the delay. Count launch APIs and synchronous wrappers per file.
|
|
|
|
const ROOT = path.resolve(import.meta.dirname, '..', '..')
|
|
const BASELINE_PATH = 'config/main-sync-spawn-baseline.txt'
|
|
const SCAN_DIRECTORIES = ['src/main', 'src/shared']
|
|
const PROCESS_ADVICE = 'use runProcess or spawnProcess from @orca/process-host'
|
|
const SECURE_ADVICE = `rewrites a DACL on the calling thread, and a directory rewrite blocks on its whole subtree; use restrictWindowsDirectory for a directory, or raise this file's count in ${BASELINE_PATH} (or add a row)`
|
|
// Include package/repo re-exporters so moving an import cannot bypass the gate.
|
|
const GATED_FAMILIES = [
|
|
{
|
|
modules: ['child_process', 'node:child_process'],
|
|
advice: { execFileSync: PROCESS_ADVICE, spawnSync: PROCESS_ADVICE, execSync: PROCESS_ADVICE }
|
|
},
|
|
{ modules: ['@orca/process-host'], advice: { runProcessSync: PROCESS_ADVICE } },
|
|
{
|
|
modules: ['src/shared/secure-path-windows-acl'],
|
|
advice: { restrictWindowsPathSync: SECURE_ADVICE }
|
|
},
|
|
{
|
|
modules: ['src/main/git/command-runner/git-exec-file', 'src/main/git/runner'],
|
|
advice: { gitExecFileSync: 'use gitExecFileAsync' }
|
|
},
|
|
{
|
|
modules: ['src/main/wsl'],
|
|
advice: {
|
|
getWslHome: 'use getWslHomeAsync',
|
|
listWslDistros: 'use listWslDistrosAsync',
|
|
wslUncDirectoryExists: 'use wslUncDirectoryExistsAsync'
|
|
}
|
|
},
|
|
{
|
|
modules: ['src/main/wsl-availability', 'src/main/wsl'],
|
|
advice: { isWslAvailable: 'use isWslAvailableAsync' }
|
|
},
|
|
{ modules: ['src/main/pwsh'], advice: { isPwshAvailable: 'use isPwshAvailableAsync' } },
|
|
{ modules: ['src/main/win32-utils'], advice: { grantDirAcl: 'use grantDirAclAsync' } }
|
|
]
|
|
const ADVICE = new Map(GATED_FAMILIES.flatMap((family) => Object.entries(family.advice)))
|
|
const GATED_MARKERS = [
|
|
...ADVICE.keys(),
|
|
...new Set(
|
|
GATED_FAMILIES.flatMap((family) => family.modules.map((module) => path.posix.basename(module)))
|
|
)
|
|
]
|
|
const FALLBACK_OPERATORS = new Set([ts.SyntaxKind.QuestionQuestionToken, ts.SyntaxKind.BarBarToken])
|
|
const BASELINE_HEADER = [
|
|
'# Synchronous child-process launches in production src/main and src/shared, per file: uses of',
|
|
'# execFileSync/spawnSync/execSync, runProcessSync and the repo sync wrappers listed in',
|
|
'# config/scripts/check-main-sync-spawn-ratchet.mjs (synchronous ACL rewrites and grants, which',
|
|
'# can block on a whole directory subtree).',
|
|
'# Some entries run in the daemon or orcad process, or are test harnesses outside the test-path',
|
|
'# conventions. This is a RATCHET: counts may only go DOWN.',
|
|
'# Prune after removing launches: pnpm check:main-sync-spawn-ratchet --prune'
|
|
]
|
|
|
|
function normalized(file) {
|
|
return file.replaceAll('\\', '/')
|
|
}
|
|
|
|
function moduleKey(file) {
|
|
return normalized(file).replace(/\.[cm]?[jt]sx?$/, '')
|
|
}
|
|
|
|
function symbolsOf(key) {
|
|
const names = GATED_FAMILIES.filter((family) => family.modules.includes(key)).flatMap((family) =>
|
|
Object.keys(family.advice)
|
|
)
|
|
return names.length > 0 ? new Set(names) : null
|
|
}
|
|
|
|
export function gatedSymbolsFor(file, specifier) {
|
|
const normalizedSpecifier = normalized(specifier)
|
|
if (!normalizedSpecifier.startsWith('.')) {
|
|
return symbolsOf(normalizedSpecifier)
|
|
}
|
|
return symbolsOf(
|
|
moduleKey(
|
|
path.posix.normalize(
|
|
path.posix.join(path.posix.dirname(normalized(file)), normalizedSpecifier)
|
|
)
|
|
)
|
|
)
|
|
}
|
|
|
|
function isValueReference(node) {
|
|
const parent = node.parent
|
|
if (
|
|
ts.isImportSpecifier(parent) ||
|
|
ts.isImportClause(parent) ||
|
|
ts.isNamespaceImport(parent) ||
|
|
ts.isImportEqualsDeclaration(parent)
|
|
) {
|
|
return false
|
|
}
|
|
if (ts.isExportSpecifier(parent)) {
|
|
return !parent.parent.parent.moduleSpecifier && node === (parent.propertyName ?? parent.name)
|
|
}
|
|
if (ts.isBindingElement(parent)) {
|
|
return node === parent.initializer
|
|
}
|
|
return (
|
|
ts.isShorthandPropertyAssignment(parent) ||
|
|
(parent.name !== node && parent.propertyName !== node && parent.label !== node)
|
|
)
|
|
}
|
|
|
|
// Count each gated value reference, alias use and re-export; imports alone do not count.
|
|
// File-wide, not scope-aware: computed specifiers/members and non-const holder flows are unresolved; local wrappers are not traced.
|
|
export function collectSyncLaunchUses(file, contents) {
|
|
// Escaped spellings and relative imports inside gated modules still need the full analysis.
|
|
const analyze =
|
|
contents.includes('\\') ||
|
|
GATED_MARKERS.some((marker) => contents.includes(marker) || file.includes(marker))
|
|
const source = ts.createSourceFile(file, contents, ts.ScriptTarget.Latest, analyze)
|
|
if (source.parseDiagnostics.length > 0) {
|
|
throw new Error(`Cannot parse ${file}; the sync-spawn ratchet must not skip it.`)
|
|
}
|
|
if (!analyze) {
|
|
return { count: 0, symbols: [] }
|
|
}
|
|
const used = new Set()
|
|
let count = 0
|
|
const namespaces = new Map()
|
|
const functions = new Map([...(symbolsOf(moduleKey(file)) ?? [])].map((name) => [name, name]))
|
|
const aliases = []
|
|
const members = []
|
|
const identifiers = []
|
|
const destructures = []
|
|
|
|
function moduleSymbols(node) {
|
|
node = unwrap(node)
|
|
if (!node) {
|
|
return null
|
|
}
|
|
if (ts.isIdentifier(node)) {
|
|
return namespaces.get(node.text) ?? null
|
|
}
|
|
const loads =
|
|
ts.isCallExpression(node) &&
|
|
(node.expression.kind === ts.SyntaxKind.ImportKeyword ||
|
|
(ts.isIdentifier(node.expression) && node.expression.text === 'require'))
|
|
const specifier = loads ? literalString(node.arguments[0]) : null
|
|
return specifier === null ? null : gatedSymbolsFor(file, specifier)
|
|
}
|
|
function gatedFunction(node) {
|
|
node = unwrap(node)
|
|
if (!node) {
|
|
return null
|
|
}
|
|
if (ts.isIdentifier(node)) {
|
|
return functions.get(node.text) ?? null
|
|
}
|
|
if (ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node)) {
|
|
const name = propertyName(node)
|
|
return moduleSymbols(node.expression)?.has(name) ? name : null
|
|
}
|
|
if (ts.isConditionalExpression(node)) {
|
|
return gatedFunction(node.whenTrue) ?? gatedFunction(node.whenFalse)
|
|
}
|
|
if (ts.isBinaryExpression(node) && FALLBACK_OPERATORS.has(node.operatorToken.kind)) {
|
|
return gatedFunction(node.left) ?? gatedFunction(node.right)
|
|
}
|
|
return null
|
|
}
|
|
function recordUse(name) {
|
|
used.add(name)
|
|
count += 1
|
|
}
|
|
function visitImport(node) {
|
|
const symbols = gatedSymbolsFor(file, node.moduleSpecifier.text)
|
|
const clause = node.importClause
|
|
if (!symbols || !clause || clause.isTypeOnly) {
|
|
return
|
|
}
|
|
if (clause.name) {
|
|
namespaces.set(clause.name.text, symbols)
|
|
}
|
|
const named = clause.namedBindings
|
|
if (named && ts.isNamespaceImport(named)) {
|
|
namespaces.set(named.name.text, symbols)
|
|
}
|
|
for (const element of named && ts.isNamedImports(named) ? named.elements : []) {
|
|
const imported = (element.propertyName ?? element.name).text
|
|
if (!element.isTypeOnly && symbols.has(imported)) {
|
|
functions.set(element.name.text, imported)
|
|
}
|
|
}
|
|
}
|
|
function visitExport(node) {
|
|
const symbols =
|
|
node.moduleSpecifier && ts.isStringLiteral(node.moduleSpecifier) && !node.isTypeOnly
|
|
? gatedSymbolsFor(file, node.moduleSpecifier.text)
|
|
: null
|
|
if (!symbols) {
|
|
return
|
|
}
|
|
const names =
|
|
!node.exportClause || ts.isNamespaceExport(node.exportClause)
|
|
? [...symbols]
|
|
: node.exportClause.elements
|
|
.filter((element) => !element.isTypeOnly)
|
|
.map((element) => (element.propertyName ?? element.name).text)
|
|
for (const name of names.filter((name) => symbols.has(name))) {
|
|
used.add(name)
|
|
count += 1
|
|
}
|
|
}
|
|
function visit(node) {
|
|
if (ts.isTypeNode(node) && !ts.isExpressionWithTypeArguments(node)) {
|
|
return
|
|
}
|
|
if (ts.isImportDeclaration(node) && ts.isStringLiteral(node.moduleSpecifier)) {
|
|
visitImport(node)
|
|
} else if (
|
|
ts.isImportEqualsDeclaration(node) &&
|
|
!node.isTypeOnly &&
|
|
ts.isExternalModuleReference(node.moduleReference) &&
|
|
ts.isStringLiteral(node.moduleReference.expression)
|
|
) {
|
|
const symbols = gatedSymbolsFor(file, node.moduleReference.expression.text)
|
|
if (symbols) {
|
|
namespaces.set(node.name.text, symbols)
|
|
}
|
|
} else if (ts.isExportDeclaration(node)) {
|
|
visitExport(node)
|
|
} else if (ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node)) {
|
|
members.push(node)
|
|
} else if (ts.isIdentifier(node) && isValueReference(node)) {
|
|
identifiers.push(node)
|
|
} else if (ts.isVariableDeclaration(node) && node.initializer) {
|
|
if (ts.isIdentifier(node.name)) {
|
|
aliases.push({ name: node.name.text, initializer: node.initializer })
|
|
} else if (ts.isObjectBindingPattern(node.name)) {
|
|
destructures.push(node)
|
|
}
|
|
}
|
|
ts.forEachChild(node, visit)
|
|
}
|
|
visit(source)
|
|
|
|
// Aliases can chain (`const cp = require('child_process'); const run = cp.execFileSync`).
|
|
for (let changed = true; changed;) {
|
|
changed = false
|
|
for (const { name, initializer } of aliases) {
|
|
const symbols = moduleSymbols(initializer)
|
|
const gated = symbols ? null : gatedFunction(initializer)
|
|
if (symbols && !namespaces.has(name)) {
|
|
namespaces.set(name, symbols)
|
|
changed = true
|
|
} else if (gated && !functions.has(name)) {
|
|
functions.set(name, gated)
|
|
changed = true
|
|
}
|
|
}
|
|
for (const node of destructures) {
|
|
const symbols = moduleSymbols(node.initializer)
|
|
for (const element of symbols ? node.name.elements : []) {
|
|
const key = element.propertyName ?? element.name
|
|
const name = ts.isIdentifier(key) ? key.text : literalString(key)
|
|
if (
|
|
symbols.has(name) &&
|
|
ts.isIdentifier(element.name) &&
|
|
!functions.has(element.name.text)
|
|
) {
|
|
functions.set(element.name.text, name)
|
|
changed = true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
for (const node of members) {
|
|
const name = propertyName(node)
|
|
if (moduleSymbols(node.expression)?.has(name)) {
|
|
recordUse(name)
|
|
}
|
|
}
|
|
for (const node of identifiers) {
|
|
const name = functions.get(node.text)
|
|
if (name) {
|
|
recordUse(name)
|
|
}
|
|
}
|
|
return { count, symbols: [...used].sort() }
|
|
}
|
|
|
|
export function isRatchetedSourcePath(file) {
|
|
return (
|
|
SCAN_DIRECTORIES.some((directory) => file.startsWith(`${directory}/`)) &&
|
|
!file.endsWith('.d.ts') &&
|
|
!isTestOnlySourcePath(file)
|
|
)
|
|
}
|
|
|
|
export function countSyncSpawnUses(sources) {
|
|
const counts = new Map()
|
|
const symbols = new Map()
|
|
for (const [file, contents] of sources) {
|
|
if (!isRatchetedSourcePath(file)) {
|
|
continue
|
|
}
|
|
const uses = collectSyncLaunchUses(file, contents)
|
|
if (uses.count > 0) {
|
|
counts.set(file, uses.count)
|
|
symbols.set(file, uses.symbols)
|
|
}
|
|
}
|
|
return { counts, symbols }
|
|
}
|
|
|
|
export function adviceFor(symbols) {
|
|
const groups = new Map()
|
|
for (const symbol of symbols) {
|
|
groups.set(ADVICE.get(symbol), [...(groups.get(ADVICE.get(symbol)) ?? []), symbol])
|
|
}
|
|
return [...groups].map(([advice, names]) => `${names.join(', ')}: ${advice}.`).join(' ')
|
|
}
|
|
|
|
export function collectSyncSpawnSources(root = ROOT) {
|
|
return new Map(
|
|
globSync(
|
|
SCAN_DIRECTORIES.map((directory) => `${directory}/**/*.{ts,tsx,mts,cts,js,mjs,cjs}`),
|
|
{ cwd: root, exclude: ['**/node_modules/**'] }
|
|
)
|
|
.map(normalized)
|
|
.filter(isRatchetedSourcePath)
|
|
.sort()
|
|
.map((file) => [file, readFileSync(path.join(root, file), 'utf8')])
|
|
)
|
|
}
|
|
|
|
export function main(root = ROOT) {
|
|
const { counts, symbols } = countSyncSpawnUses(collectSyncSpawnSources(root))
|
|
const { grown, shrunk } = diffCounts(
|
|
counts,
|
|
parseCountBaseline(readFileSync(path.join(root, BASELINE_PATH), 'utf8'))
|
|
)
|
|
for (const { file, now, allowed } of grown) {
|
|
console.error(
|
|
`::error file=${file}::${now} synchronous launch use(s), baseline allows ${allowed}. They block the main thread. ${adviceFor(symbols.get(file))}`
|
|
)
|
|
}
|
|
for (const { file, now, allowed } of shrunk) {
|
|
console.error(
|
|
`::error file=${file}::${now} synchronous launch use(s), baseline still allows ${allowed}. Run: pnpm check:main-sync-spawn-ratchet --prune`
|
|
)
|
|
}
|
|
if (grown.length + shrunk.length > 0) {
|
|
return 1
|
|
}
|
|
console.log(
|
|
`Main sync-spawn ratchet OK — ${totalCount(counts)} use(s) in ${counts.size} legacy file(s).`
|
|
)
|
|
return 0
|
|
}
|
|
|
|
export function prune(root = ROOT) {
|
|
const { counts } = countSyncSpawnUses(collectSyncSpawnSources(root))
|
|
const kept = pruneCountBaseline(root, BASELINE_PATH, BASELINE_HEADER, counts)
|
|
console.log(`Pruned ${BASELINE_PATH} to ${kept} use(s).`)
|
|
}
|
|
|
|
if (process.argv[1] && import.meta.url === pathToFileURL(path.resolve(process.argv[1])).href) {
|
|
if (process.argv[2] === '--prune') {
|
|
prune()
|
|
}
|
|
process.exitCode = main()
|
|
}
|