Files
orca/config/scripts/check-reliability-gates.mjs
T
OrcaWinandOrcaWin 7d6603aa17 [comment audit] Complete repository-wide comment cleanup (#33249)
* [comment audit] Align legacy failure-read counts with cached display

* [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci]

* [comment audit] Condense shared generation, path and preview comments [skip ci]

* [comment audit] Condense host, file and Git contract rationale [skip ci]

* [comment audit] Tighten Git lifecycle and provider contract comments [skip ci]

* [comment audit] Clarify shared host authority and launch isolation [skip ci]

* [comment audit] simplify local access mobile and native chat contracts [skip ci]

* [comment audit] simplify native chat presentation and state contracts [skip ci]

* [comment audit] simplify native runtime and provider contracts [skip ci]

* [comment audit] simplify migration and orchestration contracts [skip ci]

* [comment audit] simplify plugin trust and process capture rationale [skip ci]

* [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci]

* [comment audit] clarify remote recovery and launch wire rationale [skip ci]

* [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci]

* [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci]

* [comment audit] clarify sidebar, skill and SSH invariants [skip ci]

* [comment audit] condense structured chat delivery and timing rationale [skip ci]

* [comment audit] condense terminal replay and telemetry invariants [skip ci]

* [comment audit] clarify launch permission and terminal delivery rationale [skip ci]

* [comment audit] clarify workspace ownership and layout contracts [skip ci]

* [comment audit] wait for fitted and painted SSH terminal links

* [comment audit] clarify layout persistence and session ownership [skip ci]

* [comment audit] clarify host routing and workspace lifecycle contracts [skip ci]

* [comment audit] clarify startup persistence and app lifetime comments [skip ci]

* [comment audit] clarify recovery and activity boundaries [skip ci]

* [comment audit] condense activity and artifact invariants [skip ci]

* [comment audit] condense automation authority contracts [skip ci]

* [comment audit] simplify automation scheduling and history contracts [skip ci]

* [comment audit] clarify browser chrome and annotation lifecycles [skip ci]

* [comment audit] clarify browser routing and retained guest ownership [skip ci]

* [comment audit] clarify browser recovery and document ownership comments [skip ci]

* [comment audit] restore hosted runners required by native IME fixtures

* [comment audit] shorten preview, palette and dashboard invariants [skip ci]

* [comment audit] clarify terminal preview, dashboard and retention comments [skip ci]

* [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci]

* [comment audit] shorten rich-text and combined-diff ownership comments [skip ci]

* [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci]

* [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci]

* [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci]

* [comment audit] clarify rich Markdown source and selection safeguards [skip ci]

* [comment audit] clarify editor loading and emulator stream lifetimes [skip ci]

* [comment audit] trim emulator and feature tour narration [skip ci]

* [comment audit] clarify floating workspace and GitHub cache ownership [skip ci]

* [comment audit] trim provider controls and Linear filter explanations [skip ci]

* [comment audit] clarify pairing and chat resume lifetimes [skip ci]

* [comment audit] clarify chat delivery and transcript lifetimes [skip ci]

* [comment audit] clarify session options and host-owned status [skip ci]

* [comment audit] clarify draft durability and live-status precedence [skip ci]

* [comment audit] Trim chat send and model ownership explanations [skip ci]

* [comment audit] Shorten transcript ownership and send recovery comments [skip ci]

* [comment audit] Simplify native chat composer and transcript hook comments [skip ci]

* [comment audit] Shorten native chat scroll and structured session explanations [skip ci]

* [comment audit] Trim workspace picker and onboarding commentary [skip ci]

* [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci]

* [comment audit] Trim sidebar and session history explanations [skip ci]

* [comment audit] Condense session resume and review checks comments [skip ci]

* [comment audit] Shorten checks state and file explorer refresh comments [skip ci]

* [comment audit] Trim plugin bridge and source-control action rationale [skip ci]

* [comment audit] Trim source-control listing and review rationale [skip ci]

* [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci]

* [comment audit] Condense Settings account and appearance rationale [skip ci]

* [comment audit] Trim pairing and repository Settings explanations [skip ci]

* [comment audit] Condense Settings search SSH and terminal safeguards [skip ci]

* [comment audit] Shorten Settings voice and provider ownership comments [skip ci]

* [comment audit] Condense Settings draft persistence and host-state rationale [skip ci]

* [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci]

* [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci]

* [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci]

* [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci]

* [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci]

* [comment audit] Prune focus-read baseline after comment cleanup

* [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci]

* [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci]

* [comment audit] Clarify viewport geometry and skill update safeguards [skip ci]

* [comment audit] Tighten skill inventory, usage and host status comments [skip ci]

* [comment audit] Clarify usage ownership and resource kill safeguards [skip ci]

* [comment audit] Tighten tab selection, rename and search contracts [skip ci]

* [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci]

* [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci]

* [comment audit] Tighten provider loading and terminal recovery comments [skip ci]

* [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci]

* [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci]

* [comment audit] Tighten PTY startup and replay explanations [skip ci]

* [comment audit] Clarify PTY identity and delivery ownership [skip ci]

* [comment audit] Shorten remote reconnect and input replay rationale [skip ci]

* [comment audit] Condense terminal parking clipboard and file link comments [skip ci]

* [comment audit] Clarify IME ownership and trim trace history [skip ci]

* [comment audit] Shorten pane recovery and parked watcher explanations [skip ci]

* [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci]

* [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci]

* [comment audit] Trim renderer lifecycle and menu rationale [skip ci]

* [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci]

* [comment audit] Clarify renderer hook evidence and source ownership [skip ci]

* [comment audit] Tighten IPC ownership and reconnect explanations [skip ci]

* [comment audit] Trim renderer focus, paste and attention comments [skip ci]

* [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci]

* [comment audit] Trim agent launch, resume and ownership commentary [skip ci]

* [comment audit] Shorten account, browser and editor comments [skip ci]

* [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci]

* [comment audit] Condense launch recovery and editor tokenization comments [skip ci]

* [comment audit] Condense workspace selection and terminal pane rationale [skip ci]

* [comment audit] Condense terminal fitting and rendering recovery comments [skip ci]

* [comment audit] Condense terminal input and host routing explanations [skip ci]

* [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci]

* [comment audit] Condense structured launch and terminal link explanations [skip ci]

* [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci]

* [comment audit] Condense session persistence and workspace activation rationale [skip ci]

* [comment audit] Condense workspace routing and browser ownership rationale [skip ci]

* [comment audit] Condense mirror recovery and layout authority rationale [skip ci]

* [comment audit] Condense runtime transport and file safety rationale [skip ci]

* [comment audit] Condense runtime graph and structured session rationale [skip ci]

* [comment audit] Condense browser creation and remote tab recovery rationale [skip ci]

* [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci]

* [comment audit] Condense frame, startup and provider cache rationale [skip ci]

* [comment audit] Condense host twin and agent lifecycle rationale [skip ci]

* [comment audit] Condense browser authority and editor cleanup rationale [skip ci]

* [comment audit] Condense editor buffer identity and review cache rationale [skip ci]

* [comment audit] Condense provider lifetime and repository ownership rationale [skip ci]

* [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci]

* [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci]

* [comment audit] Condense cleanup ownership and listing admission rationale [skip ci]

* [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci]

* [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci]

* [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci]

* [comment audit] Condense cloud rollout and assignment safety rationale [skip ci]

* [comment audit] Condense relay session and database recovery rationale [skip ci]

* [comment audit] Condense relay placement and protocol compatibility rationale [skip ci]

* [comment audit] Condense build and packaging constraints [skip ci]

* [comment audit] Condense CI gates and validation isolation rationale [skip ci]

* [comment audit] Condense catalog identity and browser validation rationale [skip ci]

* [comment audit] Condense mobile browser and frame-budget rationale [skip ci]

* [comment audit] Shorten mobile route and browser test explanations [skip ci]

* [comment audit] Condense editor and session seam test rationale [skip ci]

* [comment audit] Trim session and terminal closure history [skip ci]

* [comment audit] Shorten terminal browser and census explanations [skip ci]

* [comment audit] Preserve root-only E2E diagnostic baseline

* [comment audit] Condense mobile seam and HTML preview test rationale [skip ci]

* [comment audit] Condense preview instrumentation and render harness rationale [skip ci]

* [comment audit] Condense bundle contracts and native-build constraints [skip ci]

* [comment audit] Shorten native packaging and CI routing rationale [skip ci]

* [comment audit] Condense release tooling and benchmark constraints [skip ci]

* [comment audit] Condense packaging and platform gate rationale [skip ci]

* [comment audit] Shorten mobile route and history rationale [skip ci]

* [comment audit] Condense mobile browser and component rationale [skip ci]

* [comment audit] Shorten drawer and workspace-form rationale [skip ci]

* [comment audit] Trim mobile review and editor-document explanations [skip ci]

* [comment audit] Condense editor lifecycle and Markdown explanations [skip ci]

* [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci]

* [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci]

* [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci]

* [comment audit] Condense bridge stream, native request and audio rationale [skip ci]

* [comment audit] Reduce bridge schema and page-client commentary [skip ci]

* [comment audit] Tighten mobile page bridge contracts [skip ci]

* [comment audit] Clarify mobile cache and session constraints [skip ci]

* [comment audit] Condense mobile route and lifecycle rationale [skip ci]

* [comment audit] Tighten mobile shell hook timing rationale [skip ci]

* [comment audit] Clarify route handoff and notification compatibility [skip ci]

* [comment audit] Clarify push registration and dictation cleanup constraints [skip ci]

* [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci]

* [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci]

* [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci]

* [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci]

* [comment audit] Tighten stream replay and queued session ownership rationale [skip ci]

* [comment audit] Condense mobile composer and reply-schema constraints [skip ci]

* [comment audit] Clarify mobile transcript recovery and session ownership [skip ci]

* [comment audit] Clarify mobile queue and source-control compatibility [skip ci]

* [comment audit] Condense storage and task launch constraints [skip ci]

* [comment audit] Clarify task schemas and terminal document ownership [skip ci]

* [comment audit] Tighten terminal input and viewport rationale [skip ci]

* [comment audit] Shorten terminal and RPC recorder contracts [skip ci]

* [comment audit] Condense recorder engine and connection contracts [skip ci]

* [comment audit] Shorten host credential and relay recovery comments [skip ci]

* [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci]

* [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci]

* [comment audit] Condense catalog and relay entry contracts [skip ci]

* [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci]

* [comment audit] Condense WSL relay and E2E regression rationale [skip ci]

* [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci]

* [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci]

* [comment audit] Shorten layout oracle and regression explanations [skip ci]

* [comment audit] Condense paired recovery and ownership regression contracts [skip ci]

* [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci]

* [comment audit] Condense terminal rendering and IME regression rationale [skip ci]

* [comment audit] Shorten terminal recovery and benchmark contracts [skip ci]

* [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci]

* [comment audit] Condense workflow routing and release rationale [skip ci]

* [comment audit] Condense mobile security and installer contracts [skip ci]

* [comment audit] Shorten native rationale and stylesheet workarounds [skip ci]

* [comment audit] Shorten Windows visibility probe rationale [skip ci]

* [comment audit] Condense embedded release and signing rationale [skip ci]

* [comment audit] Retain current main test behavior in final reconciliation [skip ci]

* [comment audit] Complete final comment review across current source inventory

* [comment audit] Handle consolidated audit reports before final CI

* [comment audit] Preserve credential storage census detail [skip ci]

* [comment audit] Scale broad changed E2E selections with verified timing shards

* [comment audit] Align E2E assertions with browser close and settled session metadata

* [comment audit] Match existing E2Es to current resource and windowing contracts

* [comment audit] Observe the shared server outage notice in reconnect coverage

* [comment audit] Make existing renderer probes measure settled tab and PTY work

* [comment audit] Align palette E2E selector with task search

* [comment audit] Refresh remaining palette search selectors

* [comment audit] Keep selector correction within selected audit specs

* [comment audit] Await emoji fixture settings inside renderer evaluation

* [comment audit] Cancel fixture fit retries between terminal tests

---------

Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-25 04:05:46 -07:00

435 lines
16 KiB
JavaScript

import fs from 'node:fs/promises'
import path from 'node:path'
import { pathToFileURL } from 'node:url'
import process from 'node:process'
import { parse, printParseErrorCode } from 'jsonc-parser'
const MANIFEST_PATH = path.join('config', 'reliability-gates.jsonc')
const RED_GREEN_STATUSES = new Set(['missing', 'partial', 'complete', 'not-required'])
const FLAKE_STATUSES = new Set(['not-started', 'unknown', 'soaking', 'stable', 'flaky'])
const PROTECTION_LEVELS = new Set(['none', 'partial', 'active'])
const EVIDENCE_RUN_RESULTS = new Set(['passed', 'failed', 'skipped'])
const EVIDENCE_RUNNERS = new Set(['local', 'ci', 'soak', 'manual'])
function isRecord(value) {
return value !== null && typeof value === 'object' && !Array.isArray(value)
}
function isNonEmptyString(value) {
return typeof value === 'string' && value.trim().length > 0
}
function hasNonEmptyStringArray(value) {
return Array.isArray(value) && value.length > 0 && value.every(isNonEmptyString)
}
function requireNonEmptyString(gate, field, failures) {
if (!isNonEmptyString(gate[field])) {
failures.push(`${gate.id ?? '<unknown>'}: ${field} must be a non-empty string`)
}
}
function requireStringArray(gate, field, failures) {
if (!hasNonEmptyStringArray(gate[field])) {
failures.push(`${gate.id ?? '<unknown>'}: ${field} must be a non-empty string array`)
}
}
function requireStringArrayAllowEmpty(gate, field, failures) {
if (!Array.isArray(gate[field]) || !gate[field].every(isNonEmptyString)) {
failures.push(`${gate.id ?? '<unknown>'}: ${field} must be an array of strings`)
}
}
function requireNonNegativeNumber(record, field, owner, failures) {
if (!Number.isFinite(record[field]) || record[field] < 0) {
failures.push(`${owner}.${field} must be a non-negative number`)
}
}
function validatePolicy(manifest, failures) {
if (!isRecord(manifest.policy)) {
failures.push('policy must be an object')
return new Set()
}
if (!hasNonEmptyStringArray(manifest.policy.maturityLevels)) {
failures.push('policy.maturityLevels must be a non-empty string array')
}
if (!isRecord(manifest.policy.blockingPromotion)) {
failures.push('policy.blockingPromotion must be an object')
} else {
for (const field of ['minimumSoakRuns', 'minimumSoakDays', 'maximumUnexplainedFlakes']) {
requireNonNegativeNumber(
manifest.policy.blockingPromotion,
field,
'policy.blockingPromotion',
failures
)
}
}
return new Set(
Array.isArray(manifest.policy.maturityLevels)
? manifest.policy.maturityLevels.filter(isNonEmptyString)
: []
)
}
function validateRuntimeBudget(gate, failures) {
if (!isRecord(gate.runtimeBudget)) {
failures.push(`${gate.id}: runtimeBudget must be an object`)
return
}
if (!Number.isFinite(gate.runtimeBudget.p95Seconds) || gate.runtimeBudget.p95Seconds <= 0) {
failures.push(`${gate.id}: runtimeBudget.p95Seconds must be a positive number`)
}
if (!isNonEmptyString(gate.runtimeBudget.scope)) {
failures.push(`${gate.id}: runtimeBudget.scope must be a non-empty string`)
}
}
function validateEvidence(gate, field, allowedStatuses, failures) {
const evidence = gate[field]
if (!isRecord(evidence)) {
failures.push(`${gate.id}: ${field} must be an object`)
return
}
if (!allowedStatuses.has(evidence.status)) {
failures.push(`${gate.id}: ${field}.status is invalid`)
}
if (!isNonEmptyString(evidence.evidence)) {
failures.push(`${gate.id}: ${field}.evidence must be a non-empty string`)
}
}
function validatePerformanceBudget(gate, failures) {
if (!isRecord(gate.performanceBudget)) {
failures.push(`${gate.id}: performanceBudget must be an object`)
return
}
if (typeof gate.performanceBudget.required !== 'boolean') {
failures.push(`${gate.id}: performanceBudget.required must be boolean`)
}
if (!isNonEmptyString(gate.performanceBudget.evidence)) {
failures.push(`${gate.id}: performanceBudget.evidence must be a non-empty string`)
}
}
function commandUsesBrittleTestSelector(command) {
return /(?:^|\s)(?:-t|--testNamePattern|--grep)(?:=|\s)/.test(command)
}
function validateCommandCoverage(gate, failures) {
if (!hasNonEmptyStringArray(gate.commands) || !hasNonEmptyStringArray(gate.testFiles)) {
return
}
for (const testFile of gate.testFiles) {
if (!gate.commands.some((command) => command.includes(testFile))) {
failures.push(`${gate.id}: test file is not referenced by any gate command: ${testFile}`)
}
}
}
function validateProtection(gate, failures) {
if (!PROTECTION_LEVELS.has(gate.protection)) {
failures.push(`${gate.id}: protection must be one of none, partial, or active`)
return
}
const hasCommands = hasNonEmptyStringArray(gate.commands)
const hasTestFiles = hasNonEmptyStringArray(gate.testFiles)
if (gate.protection === 'none' && (hasCommands || hasTestFiles)) {
failures.push(`${gate.id}: protection none gates must not declare commands or testFiles`)
}
if (gate.protection === 'partial' && (!hasCommands || !hasTestFiles)) {
failures.push(`${gate.id}: protection partial gates must declare commands and testFiles`)
}
if (gate.protection === 'active') {
if (gate.maturity !== 'blocking') {
failures.push(`${gate.id}: protection active is reserved for blocking gates`)
}
if (!hasCommands || !hasTestFiles) {
failures.push(`${gate.id}: protection active gates must declare commands and testFiles`)
}
if (gate.flakeHistory?.status !== 'stable') {
failures.push(`${gate.id}: protection active gates must have stable flakeHistory`)
}
if (!hasCompleteRedGreenEvidence(gate)) {
failures.push(`${gate.id}: protection active gates must have complete red/green evidence`)
}
}
if (!hasCommands && gate.protection !== 'none') {
failures.push(`${gate.id}: commandless gates must declare protection none`)
}
}
function isIsoDate(value) {
return typeof value === 'string' && /^\d{4}-\d{2}-\d{2}$/.test(value)
}
// Cross-field validators still run after type errors; coerce malformed input to report instead of throwing.
function asArray(value) {
return Array.isArray(value) ? value : []
}
function hasCompleteRedGreenEvidence(gate) {
return ['complete', 'not-required'].includes(gate.redGreenEvidence?.status)
}
function validateEvidenceRun(gate, run, index, failures) {
const owner = `${gate.id}: evidenceRuns[${index}]`
if (!isRecord(run)) {
failures.push(`${owner} must be an object`)
return
}
if (!isIsoDate(run.date)) {
failures.push(`${owner}.date must be YYYY-MM-DD`)
}
if (!EVIDENCE_RUNNERS.has(run.runner)) {
failures.push(`${owner}.runner must be one of local, ci, soak, or manual`)
}
if (!isNonEmptyString(run.platform)) {
failures.push(`${owner}.platform must be a non-empty string`)
}
if (!EVIDENCE_RUN_RESULTS.has(run.result)) {
failures.push(`${owner}.result must be one of passed, failed, or skipped`)
}
if (!isNonEmptyString(run.command)) {
failures.push(`${owner}.command must be a non-empty string`)
}
// Preserve the executed command when test roots move to a new gate command.
const commandField = run.currentCommand === undefined ? 'command' : 'currentCommand'
if (commandField === 'currentCommand' && !isNonEmptyString(run.currentCommand)) {
failures.push(`${owner}.currentCommand must be a non-empty string`)
} else if (isNonEmptyString(run.command) && !asArray(gate.commands).includes(run[commandField])) {
failures.push(`${owner}.${commandField} must match one of the gate commands`)
}
if (!Number.isFinite(run.durationSeconds) || run.durationSeconds < 0) {
failures.push(`${owner}.durationSeconds must be a non-negative number`)
}
if (!isNonEmptyString(run.summary)) {
failures.push(`${owner}.summary must be a non-empty string`)
}
}
function validateEvidenceRuns(gate, failures) {
if (!Array.isArray(gate.evidenceRuns)) {
failures.push(`${gate.id}: evidenceRuns must be an array`)
return
}
gate.evidenceRuns.forEach((run, index) => validateEvidenceRun(gate, run, index, failures))
if (
['partial', 'active'].includes(gate.protection) &&
!gate.evidenceRuns.some((run) => isRecord(run) && run.result === 'passed')
) {
failures.push(`${gate.id}: protection ${gate.protection} gates need a passed evidence run`)
}
if (gate.protection === 'none' && gate.evidenceRuns.length > 0) {
failures.push(`${gate.id}: protection none gates must not declare evidenceRuns`)
}
}
function validateAssertionRef(gate, ref, index, failures) {
const owner = `${gate.id}: assertionRefs[${index}]`
if (!isRecord(ref)) {
failures.push(`${owner} must be an object`)
return
}
if (!isNonEmptyString(ref.file)) {
failures.push(`${owner}.file must be a non-empty string`)
} else if (!asArray(gate.testFiles).includes(ref.file)) {
failures.push(`${owner}.file must be one of the gate testFiles`)
}
if (!hasNonEmptyStringArray(ref.assertions)) {
failures.push(`${owner}.assertions must be a non-empty string array`)
}
}
function validateAssertionRefs(gate, failures) {
if (!Array.isArray(gate.assertionRefs)) {
failures.push(`${gate.id}: assertionRefs must be an array`)
return
}
gate.assertionRefs.forEach((ref, index) => validateAssertionRef(gate, ref, index, failures))
if (['partial', 'active'].includes(gate.protection) && gate.assertionRefs.length === 0) {
failures.push(`${gate.id}: protection ${gate.protection} gates need assertionRefs`)
}
if (gate.protection === 'none' && gate.assertionRefs.length > 0) {
failures.push(`${gate.id}: protection none gates must not declare assertionRefs`)
}
}
function validateCoveredScope(gate, failures) {
requireStringArrayAllowEmpty(gate, 'coveredPlatforms', failures)
requireStringArrayAllowEmpty(gate, 'coveredProviders', failures)
requireNonEmptyString(gate, 'coverageNotes', failures)
if (!Array.isArray(gate.coveredPlatforms) || !Array.isArray(gate.coveredProviders)) {
return
}
for (const platform of gate.coveredPlatforms) {
if (!asArray(gate.platforms).includes(platform)) {
failures.push(`${gate.id}: covered platform is outside risk scope: ${platform}`)
}
}
for (const provider of gate.coveredProviders) {
if (!asArray(gate.providers).includes(provider)) {
failures.push(`${gate.id}: covered provider is outside risk scope: ${provider}`)
}
}
if (
['partial', 'active'].includes(gate.protection) &&
gate.evidenceRuns.some((run) => isRecord(run) && run.result === 'passed')
) {
const evidencePlatforms = new Set(
gate.evidenceRuns
.filter((run) => isRecord(run) && run.result === 'passed')
.map((run) => run.platform)
)
for (const platform of evidencePlatforms) {
if (!gate.coveredPlatforms.includes(platform)) {
failures.push(
`${gate.id}: coveredPlatforms must include passed evidence platform ${platform}`
)
}
}
}
if (
gate.protection === 'none' &&
(gate.coveredPlatforms.length > 0 || gate.coveredProviders.length > 0)
) {
failures.push(`${gate.id}: protection none gates must not declare covered scope`)
}
}
async function fileExists(root, filePath) {
try {
const stat = await fs.stat(path.join(root, filePath))
return stat.isFile()
} catch {
return false
}
}
async function validateGate(gate, maturities, root) {
const failures = []
if (!isRecord(gate)) {
return ['gate entry must be an object']
}
for (const field of ['id', 'title', 'owner', 'layer', 'invariant', 'oracle', 'demotionRule']) {
requireNonEmptyString(gate, field, failures)
}
if (!maturities.has(gate.maturity)) {
failures.push(`${gate.id ?? '<unknown>'}: maturity is invalid`)
}
for (const field of [
'surfaces',
'platforms',
'providers',
'motivatingLinks',
'promotionCriteria'
]) {
requireStringArray(gate, field, failures)
}
if (!Array.isArray(gate.commands) || !gate.commands.every(isNonEmptyString)) {
failures.push(`${gate.id}: commands must be an array of strings`)
} else if (gate.commands.some(commandUsesBrittleTestSelector)) {
failures.push(
`${gate.id}: commands must not rely on title selectors (-t, --grep, or --testNamePattern)`
)
}
if (!Array.isArray(gate.testFiles) || !gate.testFiles.every(isNonEmptyString)) {
failures.push(`${gate.id}: testFiles must be an array of strings`)
} else {
for (const testFile of gate.testFiles) {
if (!(await fileExists(root, testFile))) {
failures.push(`${gate.id}: test file does not exist: ${testFile}`)
}
}
}
validateCommandCoverage(gate, failures)
if (['soak', 'blocking'].includes(gate.maturity)) {
if (!hasNonEmptyStringArray(gate.commands)) {
failures.push(`${gate.id}: ${gate.maturity} gates must declare at least one command`)
}
if (!hasNonEmptyStringArray(gate.testFiles)) {
failures.push(`${gate.id}: ${gate.maturity} gates must declare at least one test file`)
}
if (!['soaking', 'stable'].includes(gate.flakeHistory?.status)) {
failures.push(`${gate.id}: ${gate.maturity} gates must have soaking or stable flakeHistory`)
}
if (!hasCompleteRedGreenEvidence(gate)) {
failures.push(`${gate.id}: ${gate.maturity} gates must have complete red/green evidence`)
}
}
validateRuntimeBudget(gate, failures)
validateEvidence(gate, 'flakeHistory', FLAKE_STATUSES, failures)
validateEvidence(gate, 'redGreenEvidence', RED_GREEN_STATUSES, failures)
validateProtection(gate, failures)
validateEvidenceRuns(gate, failures)
validateAssertionRefs(gate, failures)
validateCoveredScope(gate, failures)
validatePerformanceBudget(gate, failures)
if (!Array.isArray(gate.knownGaps) || !gate.knownGaps.every(isNonEmptyString)) {
failures.push(`${gate.id}: knownGaps must be an array of strings`)
}
return failures
}
export async function main(root = process.cwd()) {
const manifestPath = path.join(root, MANIFEST_PATH)
let raw
try {
raw = await fs.readFile(manifestPath, 'utf8')
} catch (error) {
const message = error instanceof Error ? error.message : String(error)
console.error(`${MANIFEST_PATH}: unable to read manifest (${message})`)
return 1
}
const parseErrors = []
const manifest = parse(raw, parseErrors, { allowTrailingComma: true })
if (parseErrors.length > 0) {
for (const error of parseErrors) {
console.error(
`${MANIFEST_PATH}: JSONC parse error ${printParseErrorCode(error.error)} at offset ${error.offset}`
)
}
return 1
}
const failures = []
if (!isRecord(manifest)) {
failures.push('manifest must be an object')
} else {
if (manifest.schemaVersion !== 1) {
failures.push('schemaVersion must be 1')
}
const maturities = validatePolicy(manifest, failures)
if (!Array.isArray(manifest.gates) || manifest.gates.length === 0) {
failures.push('gates must be a non-empty array')
} else {
const seenIds = new Set()
for (const gate of manifest.gates) {
if (isRecord(gate) && isNonEmptyString(gate.id)) {
if (seenIds.has(gate.id)) {
failures.push(`${gate.id}: duplicate gate id`)
}
seenIds.add(gate.id)
}
failures.push(...(await validateGate(gate, maturities, root)))
}
}
}
if (failures.length > 0) {
console.error(`Reliability gate manifest check failed with ${failures.length} issue(s):`)
for (const failure of failures) {
console.error(`- ${failure}`)
}
return 1
}
console.log(`Reliability gate manifest check passed for ${manifest.gates.length} gate(s).`)
return 0
}
if (process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href) {
process.exit(await main())
}