mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 17:17:38 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
344 lines
13 KiB
TypeScript
344 lines
13 KiB
TypeScript
import {
|
|
chmodSync,
|
|
existsSync,
|
|
mkdirSync,
|
|
mkdtempSync,
|
|
readFileSync,
|
|
readlinkSync,
|
|
rmSync,
|
|
statSync,
|
|
symlinkSync,
|
|
writeFileSync
|
|
} from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import path from 'node:path'
|
|
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
import {
|
|
copyPrivateTree,
|
|
hardlinkTree,
|
|
makeTreeReadOnly,
|
|
makeTreeReadOnlyAsync,
|
|
makeTreeWritable,
|
|
shareTree,
|
|
shareTreeAsync
|
|
} from './space-sharing-copy.mjs'
|
|
|
|
const roots: string[] = []
|
|
|
|
describe('asynchronous immutable sharing', () => {
|
|
it('preserves read-only source and relative symlinks on the execution host', async () => {
|
|
const { root, source } = makeTree()
|
|
await makeTreeReadOnlyAsync(source)
|
|
const destination = path.join(root, 'async-copy')
|
|
await shareTreeAsync(source, destination)
|
|
expect(readFileSync(path.join(destination, 'nested', 'file'), 'utf8')).toBe('contents')
|
|
expect(readlinkSync(path.join(destination, 'relative-link'))).toBe(path.join('nested', 'file'))
|
|
expect(statSync(path.join(destination, 'nested', 'file')).mode & 0o222).toBe(0)
|
|
})
|
|
|
|
it('removes partial copies before its Linux hardlink fallback', async () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'async-copy')
|
|
const reflink = async (_source: string, target: string) => {
|
|
mkdirSync(target)
|
|
writeFileSync(path.join(target, 'partial'), 'partial')
|
|
throw new Error('unsupported reflink')
|
|
}
|
|
expect(await shareTreeAsync(source, destination, { platform: 'linux', reflink })).toBe(
|
|
'hardlink'
|
|
)
|
|
expect(existsSync(path.join(destination, 'partial'))).toBe(false)
|
|
expect(statSync(path.join(destination, 'nested', 'file')).ino).toBe(
|
|
statSync(path.join(source, 'nested', 'file')).ino
|
|
)
|
|
expect(readlinkSync(path.join(destination, 'relative-link'))).toBe(path.join('nested', 'file'))
|
|
})
|
|
|
|
it('waits for the asynchronous sharing mechanism to finish', async () => {
|
|
const { root, source } = makeTree()
|
|
let finish!: () => void
|
|
const pending = new Promise<void>((resolve) => {
|
|
finish = resolve
|
|
})
|
|
let completed = false
|
|
const sharing = shareTreeAsync(source, path.join(root, 'async-copy'), {
|
|
platform: 'darwin',
|
|
clone: async () => {
|
|
await pending
|
|
}
|
|
}).then(() => {
|
|
completed = true
|
|
})
|
|
await new Promise<void>((resolve) => setImmediate(resolve))
|
|
expect(completed).toBe(false)
|
|
finish()
|
|
await sharing
|
|
expect(completed).toBe(true)
|
|
})
|
|
})
|
|
|
|
afterEach(() => {
|
|
while (roots.length > 0) {
|
|
rmSync(roots.pop()!, { recursive: true, force: true })
|
|
}
|
|
})
|
|
|
|
function makeTree(): { root: string; source: string } {
|
|
const root = mkdtempSync(path.join(tmpdir(), 'orca-share-'))
|
|
roots.push(root)
|
|
const source = path.join(root, 'source')
|
|
mkdirSync(path.join(source, 'nested'), { recursive: true })
|
|
writeFileSync(path.join(source, 'nested', 'file'), 'contents')
|
|
symlinkSync(path.join('nested', 'file'), path.join(source, 'relative-link'))
|
|
return { root, source }
|
|
}
|
|
|
|
describe('shareTree', () => {
|
|
// Stub mechanism selection: macOS cp -c and GNU reflink cannot both run on one host.
|
|
it('prefers the strongest isolation each platform offers', () => {
|
|
const stub = () =>
|
|
vi.fn((_source: string, target: string) => mkdirSync(target, { recursive: true }))
|
|
const stubs = { clone: stub(), reflink: stub(), hardlink: stub() }
|
|
const { root, source } = makeTree()
|
|
expect(shareTree(source, path.join(root, 'a'), { platform: 'darwin', ...stubs })).toBe('clone')
|
|
expect(shareTree(source, path.join(root, 'b'), { platform: 'linux', ...stubs })).toBe('reflink')
|
|
expect(shareTree(source, path.join(root, 'c'), { platform: 'win32', ...stubs })).toBe(
|
|
'hardlink'
|
|
)
|
|
})
|
|
|
|
it('keeps relative symlinks unresolved on whatever this host supports', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'shared')
|
|
expect(shareTree(source, destination)).toBeTruthy()
|
|
expect(readFileSync(path.join(destination, 'nested', 'file'), 'utf8')).toBe('contents')
|
|
expect(readlinkSync(path.join(destination, 'relative-link'))).toBe(path.join('nested', 'file'))
|
|
})
|
|
|
|
it('falls from reflink to hardlink on Linux, where ext4 has no reflinks', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'shared')
|
|
const reflink = vi.fn(() => {
|
|
throw new Error('failed to clone: Invalid cross-device link')
|
|
})
|
|
expect(shareTree(source, destination, { platform: 'linux', reflink })).toBe('hardlink')
|
|
expect(reflink).toHaveBeenCalledOnce()
|
|
expect(statSync(path.join(destination, 'nested', 'file')).ino).toBe(
|
|
statSync(path.join(source, 'nested', 'file')).ino
|
|
)
|
|
})
|
|
|
|
it('hardlinks on Windows, the only mechanism NTFS offers', () => {
|
|
const { root, source } = makeTree()
|
|
expect(shareTree(source, path.join(root, 'shared'), { platform: 'win32' })).toBe('hardlink')
|
|
})
|
|
|
|
it('clears a part-way tree before trying the next mechanism', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'shared')
|
|
const reflink = (_source: string, target: string) => {
|
|
mkdirSync(target, { recursive: true })
|
|
writeFileSync(path.join(target, 'half-written'), 'partial')
|
|
throw new Error('reflink failed midway')
|
|
}
|
|
expect(shareTree(source, destination, { platform: 'linux', reflink })).toBe('hardlink')
|
|
expect(existsSync(path.join(destination, 'half-written'))).toBe(false)
|
|
})
|
|
|
|
it('throws rather than silently paying for a second full copy', () => {
|
|
const { root, source } = makeTree()
|
|
expect(() => shareTree(source, path.join(root, 'shared'), { platform: 'freebsd' })).toThrow(
|
|
/Could not share storage/
|
|
)
|
|
})
|
|
|
|
it('uses strict native-copy arguments and handles their failures', async () => {
|
|
const nativeCopy = vi.fn(() => {
|
|
throw new Error('native storage sharing unavailable')
|
|
})
|
|
vi.doMock('node:child_process', () => ({ execFileSync: nativeCopy }))
|
|
vi.resetModules()
|
|
try {
|
|
const { shareTree: shareWithNativeCopy } = await import('./space-sharing-copy.mjs')
|
|
const { root, source } = makeTree()
|
|
const cloneDestination = path.join(root, 'clone')
|
|
expect(() => shareWithNativeCopy(source, cloneDestination, { platform: 'darwin' })).toThrow(
|
|
/Could not share storage/
|
|
)
|
|
expect(existsSync(cloneDestination)).toBe(false)
|
|
expect(nativeCopy).toHaveBeenNthCalledWith(
|
|
1,
|
|
'/bin/cp',
|
|
['-c', '-R', '-P', source, cloneDestination],
|
|
{ stdio: 'ignore' }
|
|
)
|
|
|
|
const reflinkDestination = path.join(root, 'reflink')
|
|
expect(shareWithNativeCopy(source, reflinkDestination, { platform: 'linux' })).toBe(
|
|
'hardlink'
|
|
)
|
|
expect(nativeCopy).toHaveBeenNthCalledWith(
|
|
2,
|
|
'cp',
|
|
['--reflink=always', '-a', source, reflinkDestination],
|
|
{ stdio: 'ignore' }
|
|
)
|
|
expect(statSync(path.join(reflinkDestination, 'nested', 'file')).ino).toBe(
|
|
statSync(path.join(source, 'nested', 'file')).ino
|
|
)
|
|
expect(readFileSync(path.join(reflinkDestination, 'nested', 'file'), 'utf8')).toBe('contents')
|
|
expect(readlinkSync(path.join(reflinkDestination, 'relative-link'))).toBe(
|
|
path.join('nested', 'file')
|
|
)
|
|
} finally {
|
|
vi.doUnmock('node:child_process')
|
|
vi.resetModules()
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('hardlinkTree', () => {
|
|
it('shares inodes for files but recreates symlinks as their own entries', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'linked')
|
|
hardlinkTree(source, destination)
|
|
expect(statSync(path.join(destination, 'nested', 'file')).ino).toBe(
|
|
statSync(path.join(source, 'nested', 'file')).ino
|
|
)
|
|
expect(readlinkSync(path.join(destination, 'relative-link'))).toBe(path.join('nested', 'file'))
|
|
})
|
|
|
|
it('propagates a write through the shared inode, which is why callers must protect it', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'linked')
|
|
hardlinkTree(source, destination)
|
|
writeFileSync(path.join(destination, 'nested', 'file'), 'mutated')
|
|
expect(readFileSync(path.join(source, 'nested', 'file'), 'utf8')).toBe('mutated')
|
|
})
|
|
})
|
|
|
|
describe('makeTreeReadOnly', () => {
|
|
it('drops write permission on files while leaving directories traversable and unlinkable', () => {
|
|
const { source } = makeTree()
|
|
makeTreeReadOnly(source)
|
|
expect(statSync(path.join(source, 'nested', 'file')).mode & 0o222).toBe(0)
|
|
// Assert rename/remove behavior, not mode bits: Windows chmod maps only read-only attribute and directories never report 0755.
|
|
expect(() => rmSync(path.join(source, 'nested'), { recursive: true })).not.toThrow()
|
|
})
|
|
|
|
it('turns an extract-over-dist write into an error instead of silent shared corruption', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'linked')
|
|
hardlinkTree(source, destination)
|
|
makeTreeReadOnly(destination)
|
|
expect(() => writeFileSync(path.join(destination, 'nested', 'file'), 'mutated')).toThrow()
|
|
expect(readFileSync(path.join(source, 'nested', 'file'), 'utf8')).toBe('contents')
|
|
})
|
|
|
|
it.runIf(process.platform !== 'win32')('preserves setuid, which chrome-sandbox needs', () => {
|
|
const { source } = makeTree()
|
|
const sandbox = path.join(source, 'chrome-sandbox')
|
|
writeFileSync(sandbox, 'binary')
|
|
chmodSync(sandbox, 0o4755)
|
|
makeTreeReadOnly(source)
|
|
expect(statSync(sandbox).mode & 0o4000).toBe(0o4000)
|
|
expect(statSync(sandbox).mode & 0o222).toBe(0)
|
|
})
|
|
|
|
it.runIf(process.platform !== 'win32')(
|
|
'keeps the executable bit, which Electron needs to launch',
|
|
() => {
|
|
const { source } = makeTree()
|
|
const executable = path.join(source, 'electron')
|
|
writeFileSync(executable, 'binary', { mode: 0o755 })
|
|
chmodSync(executable, 0o755)
|
|
makeTreeReadOnly(source)
|
|
// ext4 reports 0555; Windows read-only attribute does not prevent hardlinked executable from running on NTFS.
|
|
expect(statSync(executable).mode & 0o111).toBe(0o111)
|
|
}
|
|
)
|
|
})
|
|
|
|
describe('makeTreeWritable', () => {
|
|
it.runIf(process.platform !== 'win32')('undoes makeTreeReadOnly for the owner', () => {
|
|
const { source } = makeTree()
|
|
makeTreeReadOnly(source)
|
|
makeTreeWritable(source)
|
|
const file = path.join(source, 'nested', 'file')
|
|
expect(statSync(file).mode & 0o200).toBe(0o200)
|
|
expect(() => writeFileSync(file, 'mutated')).not.toThrow()
|
|
})
|
|
|
|
it.runIf(process.platform !== 'win32')('adds no write permission beyond the owner', () => {
|
|
const { source } = makeTree()
|
|
const executable = path.join(source, 'electron')
|
|
writeFileSync(executable, 'binary')
|
|
chmodSync(executable, 0o555)
|
|
makeTreeWritable(source)
|
|
expect(statSync(executable).mode & 0o777).toBe(0o755)
|
|
})
|
|
})
|
|
|
|
describe('copyPrivateTree', () => {
|
|
it.runIf(process.platform !== 'win32')(
|
|
'hands back a tree the caller can patch, even from a write-protected source',
|
|
() => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'private')
|
|
makeTreeReadOnly(source)
|
|
copyPrivateTree(source, destination)
|
|
// Private copy inherits shared-cache read-only modes; restore owner write or dev Info.plist patch fails.
|
|
expect(() => writeFileSync(path.join(destination, 'nested', 'file'), 'patched')).not.toThrow()
|
|
expect(readFileSync(path.join(source, 'nested', 'file'), 'utf8')).toBe('contents')
|
|
}
|
|
)
|
|
|
|
it('never hardlinks, because the caller patches what it gets back', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'private')
|
|
const hardlink = vi.fn()
|
|
const result = copyPrivateTree(source, destination, { platform: 'linux', hardlink })
|
|
expect(hardlink).not.toHaveBeenCalled()
|
|
expect(statSync(path.join(destination, 'nested', 'file')).ino).not.toBe(
|
|
statSync(path.join(source, 'nested', 'file')).ino
|
|
)
|
|
expect(result.mechanism === 'reflink' || result.mechanism === null).toBe(true)
|
|
})
|
|
|
|
it('copies bytes on a platform with no private mechanism at all', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'private')
|
|
const hardlink = vi.fn()
|
|
expect(copyPrivateTree(source, destination, { platform: 'win32', hardlink })).toEqual({
|
|
mechanism: null,
|
|
copyError: null
|
|
})
|
|
expect(hardlink).not.toHaveBeenCalled()
|
|
expect(readFileSync(path.join(destination, 'nested', 'file'), 'utf8')).toBe('contents')
|
|
expect(readlinkSync(path.join(destination, 'relative-link'))).toBe(path.join('nested', 'file'))
|
|
})
|
|
|
|
it('reports the private mechanism it used', () => {
|
|
const { root, source } = makeTree()
|
|
const clone = vi.fn((_source: string, target: string) => mkdirSync(target, { recursive: true }))
|
|
expect(
|
|
copyPrivateTree(source, path.join(root, 'private'), { platform: 'darwin', clone })
|
|
).toEqual({
|
|
mechanism: 'clone',
|
|
copyError: null
|
|
})
|
|
})
|
|
|
|
it('falls back to a byte copy when the private mechanism fails', () => {
|
|
const { root, source } = makeTree()
|
|
const destination = path.join(root, 'private')
|
|
const clone = () => {
|
|
throw new Error('clonefile unsupported')
|
|
}
|
|
const result = copyPrivateTree(source, destination, { platform: 'darwin', clone })
|
|
expect(result.mechanism).toBeNull()
|
|
expect(result.copyError).toBeInstanceOf(Error)
|
|
expect(readFileSync(path.join(destination, 'nested', 'file'), 'utf8')).toBe('contents')
|
|
})
|
|
})
|