Files
orca/src/main/plugins/plugin-install.ts
T
89acf1e1fa fix(plugins): release diagnostic logs after successful uninstall (#21185)
* fix(plugins): retire log owners after successful uninstall

* fix: address memory PR review regressions and withdraw false positives

* fix(plugins): fence stale activation after uninstall

* chore: allow durable plugin uninstall audit evidence

---------

Co-authored-by: m4air <m4air@Mac.localdomain>
Co-authored-by: Neil <neil@stably.ai>
2026-09-19 14:53:28 -07:00

324 lines
11 KiB
TypeScript

import { mkdtemp, readdir, realpath, rm } from 'node:fs/promises'
import { existsSync } from 'node:fs'
import { tmpdir } from 'node:os'
import { isAbsolute, join, relative, resolve, sep } from 'node:path'
import {
PLUGIN_MANIFEST_FILENAME,
isQualifiedPluginKey
} from '../../shared/plugins/plugin-manifest'
import {
isAllowedPluginGitUrl,
PLUGIN_COMMIT_PATTERN,
PLUGIN_CONTENT_HASH_PATTERN,
pluginInstallSourceSchema,
removePluginLock
} from '../../shared/plugins/plugin-install-lockfile'
import { readPluginLockfile, writePluginLockfile } from './plugin-install-lockfile-store'
import {
inspectPluginInstallTree,
installStagedPluginTree,
type PluginInstallResult
} from './plugin-install-staging'
import { checkoutPluginGitSource } from './plugin-git-repository'
import { readPluginCurrentPointer } from './plugin-current-pointer'
import { readPluginInstallProvenance } from './plugin-install-provenance'
import { publishPluginInstall } from './plugin-install-publication'
export type { PluginInstallResult } from './plugin-install-staging'
export {
PLUGIN_LOCKFILE_MAX_BYTES,
pluginLockfilePath,
readPluginLockfile
} from './plugin-install-lockfile-store'
/**
* Plugin installer, v0 sources: local path + git URL `#ref`. Git operations
* shell out to SYSTEM git (execFile, argv arrays — never a shell string, and
* never a vendored checkout: private repos must work with the user's
* existing credential helpers and SSH remotes). No script execution during
* install, ever — the installer copies files, nothing more.
*
* Installs land in immutable hash-addressed dirs behind an atomic pointer
* swap; the previous version dir is kept for one-step rollback.
*/
const pluginMutationChains = new Map<string, Promise<void>>()
async function serializePluginMutation<T>(
pluginsDir: string,
operation: () => Promise<T>
): Promise<T> {
const previous = pluginMutationChains.get(pluginsDir) ?? Promise.resolve()
const run = previous.catch(() => undefined).then(operation)
const settled = run.then(
() => undefined,
() => undefined
)
pluginMutationChains.set(pluginsDir, settled)
try {
return await run
} finally {
if (pluginMutationChains.get(pluginsDir) === settled) {
pluginMutationChains.delete(pluginsDir)
}
}
}
export async function installPluginFromLocalPath(input: {
pluginsDir: string
sourcePath: string
hostVersion: string
blockedPluginReason?: (pluginKey: string) => string | null
}): Promise<PluginInstallResult> {
return serializePluginMutation(input.pluginsDir, async () => {
if (!existsSync(join(input.sourcePath, PLUGIN_MANIFEST_FILENAME))) {
return { ok: false, error: `no ${PLUGIN_MANIFEST_FILENAME} found in ${input.sourcePath}` }
}
return installStagedPluginTree({
pluginsDir: input.pluginsDir,
stagingDir: input.sourcePath,
hostVersion: input.hostVersion,
source: { kind: 'local-path', path: input.sourcePath },
resolvedCommit: null,
blockedPluginReason: input.blockedPluginReason
})
})
}
export async function installBundledPlugin(input: {
pluginsDir: string
sourcePath: string
hostVersion: string
expectedPluginKey: string
blockedPluginReason?: (pluginKey: string) => string | null
}): Promise<PluginInstallResult> {
return serializePluginMutation(input.pluginsDir, () =>
installStagedPluginTree({
pluginsDir: input.pluginsDir,
stagingDir: input.sourcePath,
hostVersion: input.hostVersion,
source: { kind: 'bundled', bundleId: input.expectedPluginKey },
resolvedCommit: null,
expectedPluginKey: input.expectedPluginKey,
repairCorruptedVersion: true,
blockedPluginReason: input.blockedPluginReason
})
)
}
export async function installPluginFromGit(input: {
pluginsDir: string
url: string
/** `#ref` suffix: branch, tag, or full commit SHA. Empty = default branch. */
ref: string
hostVersion: string
blockedPluginReason?: (pluginKey: string) => string | null
}): Promise<PluginInstallResult> {
if (!isAllowedPluginGitUrl(input.url)) {
return { ok: false, error: 'plugin Git URL must use HTTPS or SSH' }
}
return serializePluginMutation(input.pluginsDir, async () => {
const stagingDir = await mkdtemp(join(tmpdir(), 'orca-plugin-install-'))
try {
const ref = input.ref.trim()
const resolvedCommit = await checkoutPluginGitSource({
url: input.url,
ref,
destination: stagingDir,
workingDirectory: tmpdir()
})
return await installStagedPluginTree({
pluginsDir: input.pluginsDir,
stagingDir,
hostVersion: input.hostVersion,
source: { kind: 'git', url: input.url, ref },
resolvedCommit,
blockedPluginReason: input.blockedPluginReason
})
} catch (error) {
return { ok: false, error: error instanceof Error ? error.message : String(error) }
} finally {
await rm(stagingDir, { recursive: true, force: true })
}
})
}
export async function installPluginFromMarketplace(input: {
pluginsDir: string
hostVersion: string
expectedPluginKey: string
expectedResolvedCommit: string
marketplace: { url: string; ref: string; resolvedCommit: string }
plugin: { url: string; ref: string }
blockedPluginReason?: (pluginKey: string) => string | null
}): Promise<PluginInstallResult> {
const source = pluginInstallSourceSchema.parse({
kind: 'marketplace',
marketplace: input.marketplace,
plugin: input.plugin
})
if (!isQualifiedPluginKey(input.expectedPluginKey)) {
return { ok: false, error: 'invalid marketplace plugin identity' }
}
if (!PLUGIN_COMMIT_PATTERN.test(input.expectedResolvedCommit)) {
return { ok: false, error: 'invalid previewed plugin commit' }
}
return serializePluginMutation(input.pluginsDir, async () => {
const stagingDir = await mkdtemp(join(tmpdir(), 'orca-plugin-marketplace-install-'))
try {
const resolvedCommit = await checkoutPluginGitSource({
url: input.plugin.url,
ref: input.plugin.ref,
destination: stagingDir,
workingDirectory: tmpdir()
})
if (resolvedCommit !== input.expectedResolvedCommit) {
return { ok: false, error: 'plugin source changed after preview; review the update again' }
}
return await installStagedPluginTree({
pluginsDir: input.pluginsDir,
stagingDir,
hostVersion: input.hostVersion,
source,
resolvedCommit,
expectedPluginKey: input.expectedPluginKey,
blockedPluginReason: input.blockedPluginReason
})
} catch (error) {
return { ok: false, error: error instanceof Error ? error.message : String(error) }
} finally {
await rm(stagingDir, { recursive: true, force: true })
}
})
}
/** Restores the single retained immutable predecessor. The old consent
* fingerprint becomes current again, so enablement still fails closed until
* the user has approved those exact bytes. */
export async function rollbackInstalledPlugin(input: {
pluginsDir: string
pluginKey: string
hostVersion: string
blockedPluginReason?: (pluginKey: string) => string | null
}): Promise<PluginInstallResult> {
if (!isQualifiedPluginKey(input.pluginKey)) {
return { ok: false, error: 'invalid qualified plugin key' }
}
const blockedReason = input.blockedPluginReason?.(input.pluginKey)
if (blockedReason) {
return { ok: false, error: `plugin is blocked by Orca's safety list: ${blockedReason}` }
}
return serializePluginMutation(input.pluginsDir, async () => {
const pluginDir = join(input.pluginsDir, input.pluginKey)
const currentContentHash = await readPluginCurrentPointer(pluginDir).catch(() => null)
if (!currentContentHash) {
return { ok: false, error: 'installed plugin has no current version' }
}
const candidates = (await readdir(pluginDir, { withFileTypes: true }).catch(() => []))
.filter(
(entry) =>
entry.isDirectory() &&
PLUGIN_CONTENT_HASH_PATTERN.test(entry.name) &&
entry.name !== currentContentHash
)
.map((entry) => entry.name)
if (candidates.length !== 1) {
return {
ok: false,
error:
candidates.length === 0
? 'no rollback version is available'
: 'rollback state is ambiguous'
}
}
const contentHash = candidates[0]!
const provenance = await readPluginInstallProvenance(pluginDir, contentHash)
if (
!provenance ||
provenance.pluginKey !== input.pluginKey ||
provenance.contentHash !== contentHash
) {
return { ok: false, error: 'rollback version has no valid install provenance' }
}
const inspection = await inspectPluginInstallTree({
rootDir: join(pluginDir, contentHash),
hostVersion: input.hostVersion,
expectedPluginKey: input.pluginKey
})
if (!inspection.ok || inspection.contentHash !== contentHash) {
return {
ok: false,
error: inspection.ok ? 'rollback version failed integrity verification' : inspection.error
}
}
try {
await publishPluginInstall({ pluginsDir: input.pluginsDir, pluginDir, entry: provenance })
} catch (error) {
return { ok: false, error: error instanceof Error ? error.message : String(error) }
}
return {
ok: true,
pluginKey: input.pluginKey,
version: inspection.manifest.version,
contentHash,
consentFingerprint: provenance.consentFingerprint,
resolvedCommit: provenance.resolvedCommit
}
})
}
/** Removes the install dir, the plugin's data dir, and the lock entry. */
export async function removeInstalledPlugin(input: {
pluginsDir: string
pluginsDataDir: string
pluginKey: string
}): Promise<void> {
await serializePluginMutation(input.pluginsDir, async () => {
if (!isQualifiedPluginKey(input.pluginKey)) {
throw new Error(`invalid qualified plugin key: ${input.pluginKey}`)
}
const lock = await readPluginLockfile(input.pluginsDir)
if (lock.plugins[input.pluginKey]?.source.kind === 'bundled') {
throw new Error(`cannot remove protected plugin ${input.pluginKey}`)
}
await removeResolvedPluginDirectory(input.pluginsDir, input.pluginKey)
await removeResolvedPluginDirectory(input.pluginsDataDir, input.pluginKey)
await writePluginLockfile(
input.pluginsDir,
removePluginLock(await readPluginLockfile(input.pluginsDir), input.pluginKey)
)
})
}
async function removeResolvedPluginDirectory(rootDir: string, pluginKey: string): Promise<void> {
let rootReal: string
let targetReal: string
try {
rootReal = await realpath(resolve(rootDir))
} catch (error) {
if ((error as NodeJS.ErrnoException).code === 'ENOENT') {
return
}
throw error
}
try {
targetReal = await realpath(resolve(rootDir, pluginKey))
} catch (error) {
if ((error as NodeJS.ErrnoException).code === 'ENOENT') {
return
}
throw error
}
const fromRoot = relative(rootReal, targetReal)
if (
fromRoot.length === 0 ||
isAbsolute(fromRoot) ||
fromRoot === '..' ||
fromRoot.startsWith(`..${sep}`)
) {
throw new Error(`refusing to remove plugin path outside ${rootReal}`)
}
await rm(resolve(rootDir, pluginKey), { recursive: true, force: true })
}