mirror of
https://github.com/stablyai/orca.git
synced 2026-11-01 17:47:40 +00:00
* chore(lint): remove disable directives that suppress nothing
Each was reported unused by the oxlint config that owns its rule (root,
casting, react-doctor, anti-slop, native-plugins), including 17 file-level
react-doctor blanket disables whose rule no longer fires. An unused
react-hooks disable was masking a react/purity finding in
useAgentBucketCounts (compiler rules skip functions with hook
suppressions); suppress that one explicitly where the code explains it.
* test(tab-bar): use typed tab/file fixtures instead of @ts-expect-error partials
* chore(lint): fix misc suppressed lint violations instead of disabling
- consistent-type-imports: the "vi.importActual requires inline import()"
rationale was wrong; use typed vi.mock(import(...), importOriginal) or a
type-only namespace import.
- no-control-regex: source-control commit/push failure summaries, shell PATH
hydration, and ipynb ANSI parsing reuse the shared ansi-escape-sequences
stripper and control-character pattern instead of private copies.
- no-explicit-any / no-useless-spread / no-this-alias: typed `this` in
bridge test mocks, drop blanket file-level disables, drop a this-alias.
* refactor(main): replace avoidable type assertions with checked narrowing
17 production cast suppressions in main/wsl-guest removed: untrusted IPC
and RPC payloads (Jira issue update, WSL guest plugin install, handshake
type) now narrow through isRecord/type guards and build typed results;
redundant casts dropped; hand-rolled object checks and errno casts use the
existing isRecord / hasErrorCode helpers.
* refactor(renderer,mobile): replace avoidable type assertions with checked types
13 production cast suppressions removed: RPC failures read through the
`ok` discriminant instead of casting to RpcFailure; react-native-web host
refs narrowed with instanceof HTMLElement; redundant reply/diff casts
become checked annotations; the TUI agent param uses z.custom(isTuiAgent)
like its sibling schemas; the agent-status slice cast that hid missing
actions is gone so the creator's return type checks the whole slice.
* chore(lint): drop dead tiptap wrapper; scope anti-slop mocking rule to test support
- safe-react-node-view-renderer patched handleSelectionUpdate, which
@tiptap/react 3.31.3 no longer has, so it always returned early. Use the
stock ReactNodeViewRenderer.
- The anti-slop test override only matched *.test.{ts,tsx}, forcing
file-level no-module-mocking disables in test harnesses and fixtures.
Match *-test-harness, *-test-fixture(s), .test-fixture and *.test.mjs,
then drop those disables and the now-redundant per-file exemptions.
* test: replace repeated cast suppressions with typed fixtures (main/shared/e2e)
Net -119 cast directives. Typed fixtures replace recurring casts:
unusedSshConnection/unusedOrcadHostTransport placeholders, a typed
readPersistedState harness read (exposed a test treating optional
httpProxyUrl as always set), real Response objects in fetch spies, an
updater main-window fixture, a CDP webContents adapter, one shared
releaseModuleExport for cross-version tests, and requireOverlayDir in
place of `as string` on possibly-undefined overlay paths.
* fix(runtime): validate loaded device rows and host scope instead of casting
Two cast suppressions claimed checks that did not happen:
- device-registry-file-read: "normalizeLoadedDeviceRow re-validates every
field" was false; deviceId, token, name and timestamps were never
checked. Rows without an identity are now dropped and the file is set
aside through the existing corrupt-file path (registry reads as
doubtful, so no revocation verdicts); a non-string token is stripped
so the row stays listed but cannot authenticate.
- client-ui: "only optionality differs" was false; any string reached
persisted workspaceHostScope. Narrow it with isWorkspaceHostScope and
ignore unknown scopes (wire schema unchanged for mixed versions). The
remaining cast now states what it actually covers.
* test(runtime,ipc): drop redundant cast suppressions; typed runtime store fixture
-98 cast directives across runtime/ipc tests: 61 casts that typecheck
without the assertion; a typed vi.fn for scoped invalidation; a
partialRuntimeStore fixture in place of `store as never` for
OrcaRuntimeService; typed worker terminal/authority builders in the
incarnation-fallback suite (the old stub lacked runtimeId, ptyId,
worktreeId and launchTokenHash) plus removal of stacked duplicate
directives there.
* chore(lint): typed vi.mock imports and explicit listener snapshot in shared-bucket tests
Remaining files from the misc-rule pass that overlapped other buckets:
codex-accounts mocks use the typed vi.mock(import(...)) form instead of
a consistent-type-imports disable; the daemon late-exit fixture copies
its listener set with Array.from instead of a no-useless-spread disable.
* refactor(github,mobile): narrow routing settings type; drop remaining avoidable casts
- work-item-routing cast a one-field object to AppState['settings'] under
a claim that readers only consume activeRuntimeEnvironmentId. Return the
existing RuntimeFocusSettings pick instead and narrow the cache-key
chain's parameters, so the compiler enforces that claim.
- mobile file preview reads refusals through the RpcResponse `ok`
discriminant rather than a cast.
- terminal document host-notify accepts `unknown` errors, removing the
message-bridge cast.
- native chat readability drops a redundant repo-list cast.
* test(renderer): replace repeated cast suppressions with typed fixtures
-140 cast directives (and ~150 unsuppressed casts of the same shapes):
- mockPanePtyArgs owns the connectPanePty fixture casts, so a wrong
argument order or fixture is now a type error; drop binding casts for
members PanePtyBinding already declares.
- Seed AppState tab rows with the typed makeTerminalTab; this exposed a
split direction 'row' that is not a TerminalPaneSplitDirection.
- Partial GlobalSettings use getDefaultSettings overrides; Jira-only
stores use createTestStore; runtime environment rows/statuses come from
a typed paired-runtime-environment fixture.
* chore(lint): drop no-module-mocking disable now covered by the test-fixture glob
* test(e2e): fix all 221 grandfathered e2e type errors; baseline to zero
The e2e typecheck baseline grandfathered 221 errors in 119 files. About a
third were tests drifted from the current API, several of which would
fail or mislead at runtime:
- terminal-shortcuts called a nonexistent xterm buffer method;
- the daemon-lifecycle fake lacked terminateOwnedTree, hidden by importing
its type from a module that does not export it;
- arguments in the wrong position (listProcesses(hostId, opts), a dropped
pty.write inputKind, an extra toWebTerminalSurfaceTabId argument);
- removed enum values ('drawer', 'idle', 'editor',
'session-insecure-origin') and a launch_source the telemetry schema
rejects;
- missing required fields (turnScope, childWorkOpen, providerIdentity,
reviewLookupOutcome, runtimeServiceAccount behind an `as RelayConfig`);
- dead reads (tab.customTitle, bucket.targets, changedPixels).
Also lifts variables that narrowed to `never` after poll-callback
assignment, and adds a typed xterm render-dimensions accessor. Includes
the cross-version suites' shared releaseModuleExport adoption.
* chore(typecheck): gate the now-clean e2e typecheck in local lint
The e2e baseline is empty, so the ratchet now rejects any tests/ type
error. CI already runs it via run-ratchets; add it to pnpm lint's
explicit ratchet list and replace the stale 'not yet clean' note.
* test(mobile): typecheck every mobile test; baseline 105 files -> 0
mobile/tests-typecheck-baseline.txt grandfathered 105 test files (531
errors) whose types CI never checked. Contract changes had landed without
these tests following, and type pins in them silently checked nothing.
- Root cause: salvagedOptional (src/shared/zod-salvage.ts) cast away
zod's optional marker, so every reply type built on it claimed
salvaged fields were always present. Return a real ZodOptional;
runtime is unchanged (the outer optional short-circuits undefined).
- Production now takes the port it uses: RpcOperationSender instead of
RpcClient for send-only callers, a narrow fetch signature, and only the
request fields push-receive reads.
- findAllByHostType/findByHostType replace `'Text' as never` lookups;
stubRpcClient gives tests a typed RpcClient.
- Real test bugs: settings-host-client-lifecycle "relay" hosts were
direct hosts (relayHostId no longer exists); two toEqualTypeOf pins
could never hold; a recovery hook ran with an undefined scope key;
a create-PR test cast to a never-imported type; "no URL" assertions
passed on null; plus stale required props, args and enum values.
* test(e2e): parse workerStart result instead of casting it
* test(runtime): typed partial runtime stores with production-shaped fixture data
Route every partial store passed to OrcaRuntimeService through
partialRuntimeStore with typed row builders, removing 60 cast directives
that hid fixture data production never produces:
- paired-client-navigation-test-harness keyed setWorktreeMeta writes by
`[object Object]` (it took an id where the store takes a target), so
reads never saw them;
- invalid worktree lineage origin/capture and incomplete workspace lineage;
- getWorkspaceSession returning null where the store returns the default
session; getGitHubCache returning undefined;
- orcad migration states missing migrationId/manifest/receipt, with a
toEqual pinned to that incomplete shape;
- partial repos, metadata, folders, project groups and notification rows.
* refactor(renderer): resolve suppressed React hook lint instead of disabling it
109 of 187 react-hooks/react-doctor suppressions fixed:
- ~95 exhaustive-deps disables only hid stable refs and setters passed
through controller objects; list them (identity never changes, so
nothing re-runs), plus a few real stale closures (tabId/worktreeId).
- Effects keyed on one value that read the latest props now use
useEffectEvent (WebConnect, skill freshness, Bitbucket dialog seeding,
Landing preflight, automation catalog, structured-session recovery,
file explorer).
- The conditional layout-owner hook is selected once at module load from
the build constant instead of a rules-of-hooks disable that also hid
the whole controller from compiler and react-doctor rules.
- A hook disable was masking a react/purity Date.now() in the palette's
recent-tabs memo; sample it when the snapshot is captured.
- Three identical debounced-search effects share
useTaskSearchDebouncedApply; layout snapshot merge helpers move out to
stay under max-lines.
Remaining suppressions are mount-once resources, invalidation epochs,
deliberately keyed fields, and test harnesses that mock the dispatcher.
* chore(ratchet): exempt test harnesses and fixtures from the focus-read ratchet
The ratchet skipped *.test-fixture.ts but scanned *-test-harness,
*-test-fixture(s) and *.test-support files. Those seed settings with
getDefaultSettings (which the ratchet discovers as a focus reader) and
never route host work, so 17 baseline entries were false positives, and
replacing a test's `settings: {...} as never` with typed defaults tripped
it. Match the repo's test-support names and prune (which also drops one
stale entry), and rename the frame-ordering harness to *-test-harness like
its siblings. A blanket "-harness" match would also exempt
e2e-terminal-pty-harness, which production imports, so the names stay
explicit.
* test: merge duplicate shared/constants imports
* revert(file-explorer): restore original tree load effects pending SSH e2e investigation
* test(runtime): drop RuntimeStore cast now that the fixture is typed
---------
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
224 lines
6.8 KiB
TypeScript
224 lines
6.8 KiB
TypeScript
import { createElement, startTransition, Suspense, useRef, useState } from 'react'
|
|
import { act, create, type ReactTestRenderer } from 'react-test-renderer'
|
|
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
import type { MobileGenerateCommitMessageResult } from './mobile-commit-message-ai'
|
|
|
|
vi.mock('../platform/haptics', () => ({ triggerError: vi.fn(), triggerSuccess: vi.fn() }))
|
|
const reply = vi.hoisted(() => {
|
|
const held: {
|
|
resolve: ((result: MobileGenerateCommitMessageResult) => void) | null
|
|
reject: ((error: Error) => void) | null
|
|
cancel: () => Promise<void>
|
|
} = { resolve: null, reject: null, cancel: async () => {} }
|
|
return held
|
|
})
|
|
vi.mock('./mobile-commit-message-ai', () => ({
|
|
requestMobileCommitMessage: () =>
|
|
new Promise<MobileGenerateCommitMessageResult>((resolve, reject) => {
|
|
reply.resolve = resolve
|
|
reply.reject = reject
|
|
}),
|
|
cancelMobileCommitMessage: () => reply.cancel()
|
|
}))
|
|
|
|
import { useMobileCommitMessageGeneration } from './use-mobile-commit-message-generation'
|
|
import { stubRpcClient } from '../transport/rpc-client-test-stub'
|
|
|
|
const client = stubRpcClient()
|
|
const view: {
|
|
generating: boolean
|
|
message: string
|
|
error: string | null
|
|
type: ((next: string) => void) | null
|
|
generate: (() => Promise<void>) | null
|
|
cancel: (() => void) | null
|
|
} = { generating: false, message: '', error: null, type: null, generate: null, cancel: null }
|
|
|
|
const suspended = new Promise<void>(() => {})
|
|
const suspendedRender = vi.fn()
|
|
|
|
function Harness({
|
|
worktreeId = 'wt-1',
|
|
suspend
|
|
}: {
|
|
worktreeId?: string
|
|
suspend?: boolean
|
|
}): null {
|
|
const [message, setMessage] = useState('')
|
|
const [generating, setGenerating] = useState(false)
|
|
const [error, setError] = useState<string | null>(null)
|
|
const mountedRef = useRef(true)
|
|
const busyActionRef = useRef<string | null>(null)
|
|
const { generateCommitMessage, cancelGenerateCommitMessage } = useMobileCommitMessageGeneration({
|
|
client,
|
|
worktreeId,
|
|
generatingMessage: generating,
|
|
mountedRef,
|
|
busyActionRef,
|
|
setGeneratingMessage: setGenerating,
|
|
setCommitMessage: setMessage,
|
|
setActionError: setError
|
|
})
|
|
if (suspend) {
|
|
suspendedRender()
|
|
throw suspended
|
|
}
|
|
view.generating = generating
|
|
view.message = message
|
|
view.error = error
|
|
view.cancel = cancelGenerateCommitMessage
|
|
view.type = setMessage
|
|
view.generate = generateCommitMessage
|
|
return null
|
|
}
|
|
|
|
let renderer: ReactTestRenderer | null = null
|
|
|
|
afterEach(() => {
|
|
act(() => renderer?.unmount())
|
|
renderer = null
|
|
reply.resolve = null
|
|
reply.reject = null
|
|
reply.cancel = async () => {}
|
|
})
|
|
|
|
async function generateThen(typed: string | null): Promise<void> {
|
|
act(() => {
|
|
renderer = create(createElement(Harness))
|
|
})
|
|
let pending: Promise<void> | undefined
|
|
act(() => {
|
|
pending = view.generate?.()
|
|
})
|
|
if (typed !== null) {
|
|
act(() => view.type?.(typed))
|
|
}
|
|
await act(async () => {
|
|
reply.resolve?.({ success: true, message: 'feat: generated' })
|
|
await pending
|
|
})
|
|
}
|
|
|
|
describe('useMobileCommitMessageGeneration', () => {
|
|
it('keeps what the user typed while the agent ran, as desktop does', async () => {
|
|
await generateThen('fix: my own words')
|
|
expect(view.message).toBe('fix: my own words')
|
|
})
|
|
|
|
it('fills an empty box with the generated message', async () => {
|
|
await generateThen(null)
|
|
expect(view.message).toBe('feat: generated')
|
|
})
|
|
|
|
it.each(['success', 'failure'])(
|
|
'does not publish the previous workspace generation %s into the new workspace',
|
|
async (outcome) => {
|
|
act(() => {
|
|
renderer = create(createElement(Harness))
|
|
})
|
|
let oldPending: Promise<void> | undefined
|
|
act(() => {
|
|
oldPending = view.generate?.()
|
|
})
|
|
const settleOld = reply.resolve
|
|
act(() => renderer?.update(createElement(Harness, { worktreeId: 'wt-2' })))
|
|
expect(view.generating).toBe(false)
|
|
let newPending: Promise<void> | undefined
|
|
act(() => {
|
|
newPending = view.generate?.()
|
|
})
|
|
const settleNew = reply.resolve
|
|
await act(async () => {
|
|
settleOld?.(
|
|
outcome === 'success'
|
|
? { success: true, message: 'old workspace' }
|
|
: { success: false, canceled: false, error: 'old error' }
|
|
)
|
|
await oldPending
|
|
})
|
|
expect(view.message).toBe('')
|
|
expect(view.error).toBeNull()
|
|
expect(view.generating).toBe(true)
|
|
await act(async () => {
|
|
settleNew?.({ success: true, message: 'new workspace' })
|
|
await newPending
|
|
})
|
|
expect(view.message).toBe('new workspace')
|
|
expect(view.generating).toBe(false)
|
|
}
|
|
)
|
|
|
|
it('admits only one generation before React has rendered the loading state', async () => {
|
|
act(() => {
|
|
renderer = create(createElement(Harness))
|
|
})
|
|
let first: Promise<void> | undefined
|
|
let second: Promise<void> | undefined
|
|
let settleFirst: typeof reply.resolve = null
|
|
act(() => {
|
|
first = view.generate?.()
|
|
settleFirst = reply.resolve
|
|
second = view.generate?.()
|
|
})
|
|
expect(reply.resolve).toBe(settleFirst)
|
|
await act(async () => {
|
|
reply.resolve?.({ success: true, message: 'one generation' })
|
|
await Promise.all([first, second])
|
|
})
|
|
expect(view.message).toBe('one generation')
|
|
})
|
|
|
|
it('keeps the current generation when a workspace transition suspends before commit', async () => {
|
|
const render = (suspend?: boolean) =>
|
|
createElement(
|
|
Suspense,
|
|
{ fallback: null },
|
|
createElement(Harness, {
|
|
worktreeId: suspend ? 'wt-2' : 'wt-1',
|
|
suspend
|
|
})
|
|
)
|
|
act(() => {
|
|
renderer = create(render())
|
|
})
|
|
let pending: Promise<void> | undefined
|
|
act(() => {
|
|
pending = view.generate?.()
|
|
})
|
|
suspendedRender.mockClear()
|
|
act(() => {
|
|
startTransition(() => renderer?.update(render(true)))
|
|
})
|
|
expect(suspendedRender).toHaveBeenCalled()
|
|
expect(view.generating).toBe(true)
|
|
await act(async () => {
|
|
reply.resolve?.({ success: true, message: 'current workspace' })
|
|
await pending
|
|
})
|
|
expect(view.message).toBe('current workspace')
|
|
expect(view.generating).toBe(false)
|
|
})
|
|
|
|
it('shows no error from a run that was stopped and then failed', async () => {
|
|
reply.cancel = () => Promise.reject(new Error('transport closed'))
|
|
const unhandled = vi.fn()
|
|
process.on('unhandledRejection', unhandled)
|
|
act(() => {
|
|
renderer = create(createElement(Harness))
|
|
})
|
|
let pending: Promise<void> | undefined
|
|
act(() => {
|
|
pending = view.generate?.()
|
|
})
|
|
act(() => view.cancel?.())
|
|
await act(async () => {
|
|
reply.reject?.(new Error('transport closed'))
|
|
await pending
|
|
await new Promise((resolve) => setTimeout(resolve, 0))
|
|
})
|
|
process.off('unhandledRejection', unhandled)
|
|
expect(view.error).toBeNull()
|
|
expect(unhandled).not.toHaveBeenCalled()
|
|
})
|
|
})
|