mirror of
https://github.com/stablyai/orca.git
synced 2026-09-25 16:02:38 +00:00
* feat(mobile): start a workspace from a branch, issue/PR, or Linear ticket Unify mobile workspace creation with desktop. The "+" Create Workspace modal now has a primary "Start from" field that opens a tabbed search drawer (Branch · GitHub · GitLab · Linear), letting a user start a workspace from an existing/new git branch, a GitHub issue/PR, a GitLab issue/MR, or a Linear ticket — in addition to the default blank workspace. No new backend is required: the search RPCs (github.listWorkItems, gitlab.listWorkItems, linear.searchIssues/listIssues, repo.searchRefs) and the worktree.create linked-item params were already used by the mobile Tasks screen. This surfaces them in the create flow, reusing the existing pure modules (buildTaskWorkspaceCreateParams, shouldResolveHostedReviewStartPoint, filterAvailableTaskProviders). Details: - New pure modules: workspace-source-selection, use-workspace-source-search, source-workspace-create, worktree-create-retry, blank-workspace-create (the blank/retry path extracted from the modal for reuse + line budget). - New UI: WorkspaceSourcePickerDrawer (+ row) and SetupHookTrustDrawer (extracted from the modal). - Older paired desktops (missing the mobile.tasks.v1 capability) degrade to Branch + Blank only; GitLab/Linear tabs appear only when available. - GitHub/GitLab sources pin their repo; switching repos resets the source. PR/MR sources resolve their base branch at create time; SSH repos gate search until connected (Linear search is repo/SSH-independent). * fix(mobile): hydrate settings/trust before availability probes settle Review fixes for #7985: setTrustedOrcaHooks/setRuntimeSettings no longer wait on status.get/preflight.check/linear.status (a first-open preflight.check can take seconds, widening the spurious setup-trust re-prompt window). Also adds param-parity tests for createBlankWorkspace and a GitLab MR base-resolve test. * feat(mobile): match desktop's Smart source picker exactly Rework the mobile create-workspace source picker to be a faithful port of desktop's Smart picker instead of the earlier divergent "Start from" drawer. The mobile field is now the workspace-name input AND the source search, with the exact desktop tabs — Smart · GitHub · Linear · GitLab · Branch · Name. "Smart" fans out across GitHub + GitLab + Linear + branches, prepends a "Use '<name>'" row, and resolves pasted URLs / #123 / STA-42 to exact items (with a cross-repo switch prompt). Selecting a source shows a pill and moves the editable name into Advanced. The invented "Blank workspace" concept is removed — the neutral state is just a typed/empty name (blank submit still yields a creature name). DRY: the pure desktop logic (smart-workspace-source-results, -command-value, github-links, gitlab-links, work-item-link-query-bounds, github-work-item-identity) moves to src/shared/new-workspace/ with re-export shims at the old renderer paths, so both renderer and mobile share one implementation. composer-branch-selection and workspace-name were already shared and are reused directly. Two read-only lookup RPCs are allowlisted for mobile so pasted GitLab URLs and cross-repo GitHub URLs resolve to exact items (github.workItemByOwnerRepo, gitlab.workItemByPath). New mobile modules are split for max-lines: use-mobile-composer-source (selection state + desktop-parity handlers, PR/MR base resolve), use-smart-workspace-source + smart-source-fan-out/-search-requests/-paste-intent (RPC orchestration), composer-linked-work-item / work-item-lookup-text / mobile-smart-source-modes (pure logic), and SmartWorkspaceSourceField/Drawer/Row + SmartWorkspaceAdvancedFields. Replaces WorkspaceSourcePickerDrawer/Row, workspace-source-selection, use-workspace-source-search, and MobileWorkspaceNameInput. Reviewed by three adversarial agents + re-reviewed after fixes: GitHub search now returns issues AND PRs (not issues-only), Linear defaults to assigned, create-branch preserves slashy names, cross-repo PR base resolves against the item's own repo, displayName is suppressed for user-edited names, and the smart-mode GitHub fan-out respects availability. tsc/oxlint/max-lines-ratchet clean; 1328 mobile tests pass. * fix(mobile): keep smart source drawer fully visible * refactor: share workspace creation behavior across clients * fix: address workspace creation review findings --------- Co-authored-by: Brennan Benson <brennanbenson@Brennans-MacBook-Pro.local>
139 lines
4.1 KiB
TypeScript
139 lines
4.1 KiB
TypeScript
import { isWorkItemLinkQueryTooLarge } from './work-item-link-query-bounds'
|
|
|
|
// Why: GitLab project paths can include nested groups, and the host may
|
|
// be self-hosted (gitlab.example.com), so the URL pattern uses the
|
|
// project-internal `/-/` separator as the GitLab-specific signal rather
|
|
// than locking to gitlab.com. Anything matching `/<path>/-/(issues|
|
|
// work_items|merge_requests)/<digits>` is treated as a GitLab item URL
|
|
// regardless of host. Modern GitLab emits issue URLs as
|
|
// `/-/work_items/<iid>`; treat that as an issue work item, same as the
|
|
// legacy `/-/issues/<iid>` form.
|
|
const GL_ITEM_PATH_RE = /\/(?:issues|work_items|merge_requests)\/(\d+)(?:\/.*)?$/i
|
|
const GL_ITEM_PATH_FULL_RE = /^\/(.+)\/-\/(issues|work_items|merge_requests)\/(\d+)(?:\/.*)?$/i
|
|
|
|
export type ProjectSlug = {
|
|
/** GitLab hostname, preserving self-hosted instances from pasted URLs. */
|
|
host: string
|
|
/** Full GitLab project path including any nested groups. */
|
|
path: string
|
|
}
|
|
|
|
export type GitLabLinkQuery = {
|
|
query: string
|
|
directNumber: number | null
|
|
tooLarge?: boolean
|
|
}
|
|
|
|
/**
|
|
* Parse a GitLab issue or MR reference from plain input. Accepts:
|
|
* - bare numbers ("42")
|
|
* - hash-prefixed numbers ("#42")
|
|
* - exclamation-prefixed numbers ("!42") — GitLab convention for MRs
|
|
* - full GitLab URLs (any host) for issues or merge_requests
|
|
*/
|
|
export function parseGitLabIssueOrMRNumber(input: string): number | null {
|
|
const trimmed = input.trim()
|
|
if (!trimmed) {
|
|
return null
|
|
}
|
|
|
|
// Why: GitLab references issues with `#` and MRs with `!` in markdown
|
|
// and copy-paste contexts. Accept both prefixes so users can drop in
|
|
// either form.
|
|
const numeric = trimmed.startsWith('#') || trimmed.startsWith('!') ? trimmed.slice(1) : trimmed
|
|
if (/^\d+$/.test(numeric)) {
|
|
return Number.parseInt(numeric, 10)
|
|
}
|
|
|
|
let url: URL
|
|
try {
|
|
url = new URL(trimmed)
|
|
} catch {
|
|
return null
|
|
}
|
|
|
|
const match = GL_ITEM_PATH_RE.exec(url.pathname)
|
|
if (!match) {
|
|
return null
|
|
}
|
|
// Why: the basic pattern matches plain GitHub URLs too (e.g.
|
|
// /owner/repo/issues/123). Require the `/-/` separator that's
|
|
// unique to GitLab to avoid mis-classifying a GitHub URL.
|
|
if (!url.pathname.includes('/-/')) {
|
|
return null
|
|
}
|
|
return Number.parseInt(match[1], 10)
|
|
}
|
|
|
|
/**
|
|
* Parse a GitLab URL into project path + iid + type. Returns null for
|
|
* anything that isn't a recognizable GitLab issue or merge-request URL.
|
|
*/
|
|
export function parseGitLabIssueOrMRLink(input: string): {
|
|
slug: ProjectSlug
|
|
number: number
|
|
type: 'issue' | 'mr'
|
|
} | null {
|
|
const trimmed = input.trim()
|
|
if (!trimmed) {
|
|
return null
|
|
}
|
|
|
|
let url: URL
|
|
try {
|
|
url = new URL(trimmed)
|
|
} catch {
|
|
return null
|
|
}
|
|
|
|
const match = GL_ITEM_PATH_FULL_RE.exec(url.pathname)
|
|
if (!match) {
|
|
return null
|
|
}
|
|
|
|
const path = match[1]
|
|
// Why: a project path needs at least one slash (group/project). A
|
|
// single-segment path is the user/group root, not a project.
|
|
if (!path.includes('/')) {
|
|
return null
|
|
}
|
|
|
|
return {
|
|
slug: { host: url.host, path },
|
|
type: match[2].toLowerCase() === 'merge_requests' ? 'mr' : 'issue',
|
|
number: Number.parseInt(match[3], 10)
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Normalize link-picker input so both raw issue/MR numbers and full
|
|
* GitLab URLs resolve to a usable query + direct-number lookup.
|
|
*/
|
|
export function normalizeGitLabLinkQuery(raw: string): GitLabLinkQuery {
|
|
if (isWorkItemLinkQueryTooLarge(raw)) {
|
|
return { query: '', directNumber: null, tooLarge: true }
|
|
}
|
|
const trimmed = raw.trim()
|
|
if (!trimmed) {
|
|
return { query: '', directNumber: null }
|
|
}
|
|
|
|
const direct = parseGitLabIssueOrMRNumber(trimmed)
|
|
if (direct !== null && !trimmed.startsWith('http')) {
|
|
return { query: trimmed, directNumber: direct }
|
|
}
|
|
|
|
const link = parseGitLabIssueOrMRLink(trimmed)
|
|
if (!link) {
|
|
return { query: trimmed, directNumber: null }
|
|
}
|
|
|
|
// Why: any GitLab issue/MR URL is accepted by number regardless of
|
|
// project slug, mirroring the GitHub-side behavior — fork checkouts
|
|
// can legitimately target an upstream's issue numbers.
|
|
return {
|
|
query: trimmed,
|
|
directNumber: link.number
|
|
}
|
|
}
|