mirror of
https://github.com/stablyai/orca.git
synced 2026-09-25 00:02:35 +00:00
Neil
0096e47850
* fix(windows): keep windows-process-tree gyp paths absolute under pnpm Hourly Windows builds have failed since #16598 at `build-windows-process-tree-relay-addon`: `require('node-addon-api').targets` is cwd-relative, so node-gyp evaluates it from the pnpm store realpath and then loads it from the `node_modules` symlink. That resolves `node_addon_api.gyp` outside the repo. Use `require.resolve` for an absolute path, matching the node-pty patch. * i18n: keep ja skill-filter labels on the catalog's Agent brand #16682 merged with a failing localization catalog: ja used エージェント in three new skill-filter strings, and repair-locale-catalog rewrites those to Agent. Match the rest of ja.json so static analysis can pass.
39 lines
1.5 KiB
JavaScript
39 lines
1.5 KiB
JavaScript
import { execFileSync } from 'node:child_process'
|
|
import { existsSync, readFileSync } from 'node:fs'
|
|
import { isAbsolute, join, resolve } from 'node:path'
|
|
import { describe, expect, it } from 'vitest'
|
|
|
|
const projectDir = resolve(import.meta.dirname, '../..')
|
|
const PATCH = readFileSync(
|
|
join(projectDir, 'config/patches/@vscode__windows-process-tree@0.8.0.patch'),
|
|
'utf8'
|
|
)
|
|
const PACKAGE_DIR = join(projectDir, 'node_modules', '@vscode', 'windows-process-tree')
|
|
const ABSOLUTE_GYP = "require.resolve('node-addon-api/node_addon_api.gyp')"
|
|
|
|
describe('windows-process-tree node-addon-api gyp path', () => {
|
|
it('keeps the gyp project path absolute so pnpm Windows source builds find it', () => {
|
|
expect(PATCH).toContain(
|
|
`+ "<!(node -p \\"require.resolve('node-addon-api/node_addon_api.gyp')\\"):node_addon_api_except"`
|
|
)
|
|
const bindingGyp = readFileSync(join(PACKAGE_DIR, 'binding.gyp'), 'utf8')
|
|
expect(bindingGyp).toContain(ABSOLUTE_GYP)
|
|
expect(bindingGyp).not.toContain("require('node-addon-api').targets")
|
|
expect(
|
|
readFileSync(
|
|
join(projectDir, 'config/scripts/build-windows-process-tree-relay-addon.mjs'),
|
|
'utf8'
|
|
)
|
|
).toContain(ABSOLUTE_GYP)
|
|
})
|
|
|
|
it('resolves node_addon_api.gyp to a real file from the package directory', () => {
|
|
const resolved = execFileSync(process.execPath, ['-p', ABSOLUTE_GYP], {
|
|
cwd: PACKAGE_DIR,
|
|
encoding: 'utf8'
|
|
}).trim()
|
|
expect(isAbsolute(resolved)).toBe(true)
|
|
expect(existsSync(resolved)).toBe(true)
|
|
})
|
|
})
|