mirror of
https://github.com/stablyai/orca.git
synced 2026-09-22 08:02:28 +00:00
* Add worktree labels for localhost ports * Fix localhost label test fixtures * Extend localhost worktree labels to agents * Address localhost label review feedback * Remove localhost label page injection; stream responses untouched Drop the title/favicon HTML injection from the localhost label proxy. The proxy now only relabels the hostname and pipes responses straight through, so app CSP/cookies/bodies are preserved and large/streamed responses are no longer buffered in memory. - Normalize wildcard bind hosts (0.0.0.0 -> 127.0.0.1, :: -> ::1) before using them as a proxy connect target. - Delete the favicon SVG generator and dead repoIcon/badgeColor plumbing. - Remove orphaned LocalhostLabelMock i18n keys. Co-authored-by: Orca <help@stably.ai> * Harden localhost label proxy from review - IPC register: restrict proxy target to loopback or a matching scanned workspace port (close open-proxy/SSRF surface from untrusted renderer). - Proxy: guard against ERR_HTTP_HEADERS_SENT on mid-stream upstream error; add error/cleanup listeners on client request/response and upgrade socket. - labelLocalhostUrl: fall back to the raw URL when the proxy rejects a target (e.g. https) instead of throwing. - Port label route: include worktreePath so button-open and terminal/CLI paths produce the same label. - Terminal OSC link hover: discard stale async tooltip results via a hover token, matching the WebLinks path. Co-authored-by: Orca <help@stably.ai> * Match default-port advertised hosts in localhost label target check Co-authored-by: Orca <help@stably.ai> * Consolidate duplicated localhost label helpers - Move the loopback host set, loopback-URL parser, and wildcard connect-host normalizer into shared/localhost-worktree-labels.ts; proxy, runtime, terminal link routing, and the IPC guard now share one copy. - Extract the port -> repo -> worktree -> project label-route lookup into workspace-port-localhost-label-selector.ts (a hook plus an imperative resolver), replacing the block triplicated across the ports surfaces. Co-authored-by: Orca <help@stably.ai> * Extract command-code prompt-status seed to its own module Keeps launch-agent-in-new-tab.ts under the max-lines limit after the localhost-hint additions, without a lint disable. Co-authored-by: Orca <help@stably.ai> * Remove agent-facing localhost mechanism Orca does not mutate user prompts or inject prompt snippets, so drop the localhost-open agent hint entirely: - Remove appendLocalhostOpeningHint / includeLocalhostOpeningHint and the hint constant from tui-agent-startup; agent prompts are no longer rewritten. - Remove the ORCA_LOCALHOST_OPEN env var from local agent terminals (it was only discoverable via the now-removed hint). - Remove the orca localhost label|open CLI commands, their workspacePorts RPC methods, and the runtime labelLocalhostUrl/openLocalhostUrl methods. The feature is now purely structural: the loopback label proxy plus the ports-panel and terminal-link 'Open in Browser' paths, which surface a clickable labeled URL without touching agent prompts. Co-authored-by: Orca <help@stably.ai> * Make localhost worktree labels opt-in (default off) Serving a dev app under a different host than localhost:<port> can break apps that bind cookies/sessions to localhost, so the feature should not change existing users' Open-in-Browser behavior on upgrade. - Default localhostWorktreeLabelsEnabled to false. - Flip the gates to enable only when explicitly true (=== true / !== true) instead of treating undefined as enabled. - Update the setting switch to checked only when explicitly enabled. - Drop the now-unused runtime store settings field. Co-authored-by: Orca <help@stably.ai> --------- Co-authored-by: Jinwoo-H <jinwoo0825@gmail.com> Co-authored-by: Orca <help@stably.ai>
62 lines
1.6 KiB
TypeScript
62 lines
1.6 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import {
|
|
getLocalhostWorktreeHostLabel,
|
|
getLocalhostWorktreeRouteKey,
|
|
slugifyLocalhostWorktreeLabel
|
|
} from './localhost-worktree-labels'
|
|
|
|
describe('localhost worktree labels', () => {
|
|
it('uses project-main for the primary worktree', () => {
|
|
expect(
|
|
getLocalhostWorktreeHostLabel({
|
|
projectName: 'Snap Studio',
|
|
worktreeName: 'main'
|
|
})
|
|
).toBe('snap-studio-main')
|
|
})
|
|
|
|
it('keeps non-main worktree labels short', () => {
|
|
expect(
|
|
getLocalhostWorktreeHostLabel({
|
|
projectName: 'Snap Studio',
|
|
worktreeName: 'analytics'
|
|
})
|
|
).toBe('analytics')
|
|
})
|
|
|
|
it('uses the worktree folder name over branch owner prefixes for non-main labels', () => {
|
|
expect(
|
|
getLocalhostWorktreeHostLabel({
|
|
projectName: 'Snap Studio',
|
|
worktreeName: 'gatsby74/table-summary',
|
|
worktreePath: '/Users/example/orca/workspaces/snapstudio/ui-auth'
|
|
})
|
|
).toBe('ui-auth')
|
|
})
|
|
|
|
it('normalizes labels for localhost hostnames', () => {
|
|
expect(slugifyLocalhostWorktreeLabel(' Drive DB Mismatch! ')).toBe('drive-db-mismatch')
|
|
})
|
|
|
|
it('keeps route keys unique for different ports in the same worktree', () => {
|
|
const route = {
|
|
projectName: 'Snap Studio',
|
|
worktreeName: 'analytics',
|
|
repoId: 'repo-1',
|
|
worktreeId: 'wt-analytics'
|
|
}
|
|
|
|
expect(
|
|
getLocalhostWorktreeRouteKey({
|
|
...route,
|
|
targetUrl: 'http://localhost:5173/'
|
|
})
|
|
).not.toBe(
|
|
getLocalhostWorktreeRouteKey({
|
|
...route,
|
|
targetUrl: 'http://localhost:7777/'
|
|
})
|
|
)
|
|
})
|
|
})
|