mirror of
https://github.com/stablyai/orca.git
synced 2026-11-05 03:27:44 +00:00
* feat(ci): ratchet raw repo connectionId host reads; one drop-in resolver Codex review 6 class fix (#4/#6/#7): host decisions read off a repo row's legacy connectionId miss rows that name SSH only as executionHostId. - getRepoRoutingConnectionId (shared/execution-host.ts): drop-in for a raw repo.connectionId routing check that also finds executionHostId-only SSH. - check-repo-host-read-ratchet: per-file count of raw repo connectionId reads in src/main, src/shared, src/cli; counts may only shrink. - Migrated 66 cheap reads: runtime GitHub/GitLab commands, PR/MR head ref fetches, preserved-branch cleanup, ref queries, base-ref IPC, worktree preparation, trash sweep, scan cache TTL, usage metadata. * fix(ipc): PR base IPC routes executionHostId-only SSH rows; ratchet is a stated lower bound Review follow-up (Opus on #31096): - worktrees:resolvePrBase decided git/gh routing on the raw connectionId while its head-ref fetches already used the resolver; one resolved connectionId now drives all of it (test fails on main). - getRepoRoutingConnectionId's contract is stated exactly: never local when the raw field is set; on a contradictory ssh row executionHostId wins. - The ratchet regex no longer matches report.connectionId; header and docs say it is a lower bound. - Regression tests for a runtime GitHub and GitLab command site. * test(ci): pin the repo host-read ratchet step to the static phase * fix(ci): repo host-read ratchet skips verbatim field copies into projected rows A copy of connectionId into a projected row decides nothing; migrating it to the resolver would change what the projection publishes. The sidebar feed catalog's copy (added after the baseline) and two older projections no longer count; baseline pruned to 91.
109 lines
3.2 KiB
TypeScript
109 lines
3.2 KiB
TypeScript
import type { GitHubOwnerRepo, GitHubPRFile } from '../../shared/github/pull-request-types'
|
|
import type { Repo } from '../../shared/repo-types'
|
|
import type { LocalProjectGhExecOptions } from '../project-runtime-git-options'
|
|
import { getIssue, getPRCheckDetails, getPRChecks, getPRComments } from '../github/client'
|
|
import { getPRFileContents } from '../github/work-item-details'
|
|
import { getRepoRoutingConnectionId } from '../../shared/execution-host'
|
|
|
|
type LocalGitArgs = [] | [LocalProjectGhExecOptions]
|
|
|
|
type RuntimeGitHubReviewQueryCommandsDeps = {
|
|
resolveRepo: (selector: string) => Promise<Repo>
|
|
getLocalGitArgs: (repo: Repo) => LocalGitArgs
|
|
}
|
|
|
|
export class RuntimeGitHubReviewQueryCommands {
|
|
constructor(private readonly deps: RuntimeGitHubReviewQueryCommandsDeps) {}
|
|
|
|
async getRepoIssue(
|
|
repoSelector: string,
|
|
number: number
|
|
): Promise<Awaited<ReturnType<typeof getIssue>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return getIssue(
|
|
repo.path,
|
|
number,
|
|
getRepoRoutingConnectionId(repo),
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
|
|
async getRepoPRChecks(
|
|
repoSelector: string,
|
|
prNumber: number,
|
|
headSha?: string,
|
|
prRepo?: GitHubOwnerRepo | null,
|
|
options?: { noCache?: boolean }
|
|
): Promise<Awaited<ReturnType<typeof getPRChecks>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return getPRChecks(
|
|
repo.path,
|
|
prNumber,
|
|
headSha,
|
|
prRepo ?? null,
|
|
options,
|
|
getRepoRoutingConnectionId(repo),
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
|
|
async getRepoPRCheckDetails(
|
|
repoSelector: string,
|
|
args: {
|
|
checkRunId?: number
|
|
workflowRunId?: number
|
|
checkName?: string
|
|
url?: string | null
|
|
prRepo?: GitHubOwnerRepo | null
|
|
},
|
|
signal?: AbortSignal
|
|
): Promise<Awaited<ReturnType<typeof getPRCheckDetails>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
const localGitOptions = this.deps.getLocalGitArgs(repo)[0] ?? {}
|
|
return getPRCheckDetails(
|
|
repo.path,
|
|
{ ...args, prRepo: args.prRepo ?? null },
|
|
getRepoRoutingConnectionId(repo),
|
|
localGitOptions,
|
|
signal
|
|
)
|
|
}
|
|
|
|
async getRepoPRComments(
|
|
repoSelector: string,
|
|
prNumber: number,
|
|
prRepo?: GitHubOwnerRepo | null,
|
|
options?: { noCache?: boolean }
|
|
): Promise<Awaited<ReturnType<typeof getPRComments>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return getPRComments(
|
|
repo.path,
|
|
prNumber,
|
|
{ ...options, prRepo: prRepo ?? null },
|
|
getRepoRoutingConnectionId(repo),
|
|
...this.deps.getLocalGitArgs(repo)
|
|
)
|
|
}
|
|
|
|
async getRepoPRFileContents(
|
|
repoSelector: string,
|
|
args: {
|
|
prNumber: number
|
|
prRepo?: GitHubOwnerRepo | null
|
|
path: string
|
|
oldPath?: string
|
|
status: GitHubPRFile['status']
|
|
headSha: string
|
|
baseSha: string
|
|
}
|
|
): Promise<Awaited<ReturnType<typeof getPRFileContents>>> {
|
|
const repo = await this.deps.resolveRepo(repoSelector)
|
|
return getPRFileContents({
|
|
repoPath: repo.path,
|
|
connectionId: getRepoRoutingConnectionId(repo),
|
|
localGitOptions: this.deps.getLocalGitArgs(repo)[0],
|
|
...args
|
|
})
|
|
}
|
|
}
|