mirror of
https://github.com/stablyai/orca.git
synced 2026-10-30 00:27:39 +00:00
#14397 split `shared/types.ts` into 46 per-domain modules but kept the path as a re-export barrel so the import sites did not have to change. This removes the barrel: every consumer now imports from the module that actually declares the type, and `src/shared/types.ts` is deleted. Barrels hide where a type lives, make every consumer look like it depends on the whole domain, and let an unrelated edit invalidate a module that ~2,000 files transitively import. 2,323 import declarations across 2,321 files. Rewritten mechanically: each specifier was resolved to an absolute path via the TypeScript AST and recomputed, rather than string-substituted, so alias forms (`@/../../shared/ types`) and per-specifier `type` modifiers survive. Four cases the mechanical pass had to handle, each found by a gate rather than by reading the diff: - Modules inside `src/shared` import the barrel as `./types`, not `shared/types`. A pre-filter on the latter string skipped 176 of them and left imports dangling at a deleted file, which surfaced as confusing `Property 'x' is optional in type 'Repo' but required in Pick<Repo, ...>` errors rather than "module not found". - The barrel RENAMED one type on the way through (`WorkspaceSource as WorkspaceCreateTelemetrySource`), so the original name in the owning module has to be re-aliased at each consumer. - Three test files put `;(globalThis as ...)` on the line after the import. TypeScript parses that `;` as the import statement's terminator, so replacing through `statement.getEnd()` deletes it and breaks ASI. The rewrite now stops at the module specifier. - A file that already imported directly from a module got a SECOND import from it, because the barrel re-exported those same names — which trips `import/no-duplicates` under `--deny-warnings`. A post-pass merges declarations sharing a specifier and type-only-ness; the `import type` plus `import` pair from one module is left alone, since that form is allowed. Splitting one barrel import into several genuinely adds lines, which pushed `terminal-layout-pty-ownership.ts` to 301 counted lines: its 107-character import must wrap, and neither local type collapses onto one line (101 and 116 characters). Rather than contort a type declaration to fit a line budget, `collectLeafIds` and `pruneLeaves` move to `terminal-pane-layout-tree.ts` — they are pure structural operations on the layout tree and independent of PTY ownership. `visible-worktrees.ts` similarly loses its own mini-barrel re-export of `isDefaultBranchWorkspace`, with the four real consumers repointed at the declaring module. No `max-lines` bypass added. Verified: cold `tsc --noEmit` green on node, cli, and web (buildinfo deleted first — these projects are `composite: true` and reuse stale caches); the full `pnpm lint` green, not just bare oxlint — the narrower local check is what let the duplicate imports reach CI; max-lines ratchet OK at 344.
197 lines
6.4 KiB
TypeScript
197 lines
6.4 KiB
TypeScript
import type { GitPushTarget } from './worktree/types'
|
|
|
|
export type ComposerBranchSelection = {
|
|
baseBranch: string
|
|
branchNameOverride: string | undefined
|
|
branchAutoName: string
|
|
name: string | undefined
|
|
lastAutoName: string | undefined
|
|
}
|
|
|
|
export function resolveComposerBranchSelection(args: {
|
|
refName: string
|
|
localBranchName: string
|
|
currentName: string
|
|
lastAutoName: string
|
|
}): ComposerBranchSelection {
|
|
const trimmedCurrentName = args.currentName.trim()
|
|
const shouldAutoName =
|
|
!trimmedCurrentName ||
|
|
args.currentName === args.lastAutoName ||
|
|
args.localBranchName.startsWith(trimmedCurrentName) ||
|
|
args.refName.startsWith(trimmedCurrentName)
|
|
if (!shouldAutoName) {
|
|
return {
|
|
baseBranch: args.refName,
|
|
branchNameOverride: undefined,
|
|
branchAutoName: '',
|
|
name: undefined,
|
|
lastAutoName: undefined
|
|
}
|
|
}
|
|
return {
|
|
baseBranch: args.refName,
|
|
branchNameOverride: args.localBranchName,
|
|
branchAutoName: args.localBranchName,
|
|
name: args.localBranchName,
|
|
lastAutoName: args.localBranchName
|
|
}
|
|
}
|
|
|
|
/**
|
|
* True when `branchName` is already checked out in one of the given worktree
|
|
* branch refs (which may be `refs/heads/foo` or short `foo`). Git refuses to
|
|
* check out a branch in two worktrees, so such a branch cannot be reused.
|
|
*/
|
|
export function isBranchCheckedOutInWorktrees(
|
|
branchName: string,
|
|
worktreeBranches: readonly string[]
|
|
): boolean {
|
|
return worktreeBranches.some((ref) => ref.replace(/^refs\/heads\//, '') === branchName)
|
|
}
|
|
|
|
export function getComposerRepoWorktreeBranches(
|
|
worktrees: readonly { repoId: string; branch: string }[],
|
|
repoId: string | null
|
|
): string[] {
|
|
return repoId
|
|
? worktrees.filter((worktree) => worktree.repoId === repoId).map((worktree) => worktree.branch)
|
|
: []
|
|
}
|
|
|
|
/**
|
|
* Issue #5181: decide whether a picked branch row is an existing LOCAL branch
|
|
* that can be reused (checked out) instead of branched off, and whether reuse
|
|
* should default ON.
|
|
*
|
|
* Reuse is only possible for a LOCAL branch (ref === local name; remote-only
|
|
* refs carry an `origin/`-style prefix) that is NOT already checked out in
|
|
* another worktree — git allows a branch in only one worktree at a time. Reuse
|
|
* defaults ON only when the worktree name was auto-derived from the branch (the
|
|
* selection produced a branch-name override); a user who typed a custom
|
|
* worktree name first is branching off the ref, so reuse stays OFF unless they
|
|
* opt in.
|
|
*/
|
|
export function resolveComposerBranchReuse(args: {
|
|
refName: string
|
|
localBranchName: string
|
|
selectionProducedOverride: boolean
|
|
branchCheckedOutElsewhere: boolean
|
|
}): { reuseEligibleBranch: string | null; defaultReuse: boolean } {
|
|
const reuseEligibleBranch =
|
|
args.refName === args.localBranchName && !args.branchCheckedOutElsewhere
|
|
? args.localBranchName
|
|
: null
|
|
return {
|
|
reuseEligibleBranch,
|
|
defaultReuse: reuseEligibleBranch !== null && args.selectionProducedOverride
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Issue #5181: the branch-name override to apply for a picked branch. A local
|
|
* branch already checked out in another worktree can't be reused, so it must
|
|
* NOT be pinned as the override — pinning it would collide and silently produce
|
|
* a suffixed branch. In that case fall back to letting the worktree name derive
|
|
* a fresh branch from the selected ref as base; otherwise use the selection's
|
|
* override unchanged.
|
|
*/
|
|
export function resolveComposerReuseOverride(args: {
|
|
refName: string
|
|
localBranchName: string
|
|
branchNameOverride: string | undefined
|
|
branchCheckedOutElsewhere: boolean
|
|
}): string | undefined {
|
|
if (args.branchCheckedOutElsewhere && args.refName === args.localBranchName) {
|
|
return undefined
|
|
}
|
|
return args.branchNameOverride
|
|
}
|
|
|
|
export type ComposerBranchPick = ComposerBranchSelection & {
|
|
reuseEligibleBranch: string | null
|
|
defaultReuse: boolean
|
|
}
|
|
|
|
export function resolveComposerBranchPick(args: {
|
|
refName: string
|
|
localBranchName: string
|
|
currentName: string
|
|
lastAutoName: string
|
|
worktreeBranches: readonly string[]
|
|
}): ComposerBranchPick {
|
|
const selection = resolveComposerBranchSelection(args)
|
|
const branchCheckedOutElsewhere = isBranchCheckedOutInWorktrees(
|
|
args.localBranchName,
|
|
args.worktreeBranches
|
|
)
|
|
const reuse = resolveComposerBranchReuse({
|
|
refName: args.refName,
|
|
localBranchName: args.localBranchName,
|
|
selectionProducedOverride: selection.branchNameOverride !== undefined,
|
|
branchCheckedOutElsewhere
|
|
})
|
|
return {
|
|
...selection,
|
|
branchNameOverride: resolveComposerReuseOverride({
|
|
refName: args.refName,
|
|
localBranchName: args.localBranchName,
|
|
branchNameOverride: selection.branchNameOverride,
|
|
branchCheckedOutElsewhere
|
|
}),
|
|
...reuse
|
|
}
|
|
}
|
|
|
|
/**
|
|
* The branch-name override to apply when creating a worktree from the composer.
|
|
*
|
|
* With no resolver-provided override, branch mode (#6721) keeps a
|
|
* slash-containing typed name as the git branch — validated downstream by
|
|
* `git check-ref-format` — while the worktree folder name is sanitized
|
|
* separately; every other mode leaves the branch to be derived from the
|
|
* sanitized name. With an override, keep it verbatim when the workspace name is
|
|
* user-edited (`preserveWorkspaceNameEdits`) or still matches the auto-name.
|
|
*/
|
|
export function resolveComposerBranchNameOverrideForCreate(args: {
|
|
branchNameOverride: string | undefined
|
|
branchAutoName: string
|
|
workspaceName: string
|
|
preserveWorkspaceNameEdits: boolean
|
|
createBranchFromWorkspaceName?: boolean
|
|
}): string | undefined {
|
|
if (!args.branchNameOverride) {
|
|
return args.createBranchFromWorkspaceName && args.workspaceName.includes('/')
|
|
? args.workspaceName
|
|
: undefined
|
|
}
|
|
if (args.preserveWorkspaceNameEdits) {
|
|
return args.branchNameOverride
|
|
}
|
|
return args.workspaceName === args.branchAutoName ? args.branchNameOverride : undefined
|
|
}
|
|
|
|
export function resolveComposerManualBranchNameChange(args: {
|
|
value: string | undefined
|
|
pushTarget: GitPushTarget | undefined
|
|
forkPushWarning: string | null
|
|
}): {
|
|
branchNameOverride: string | undefined
|
|
pushTarget: GitPushTarget | undefined
|
|
forkPushWarning: string | null
|
|
} {
|
|
const branchNameOverride = args.value?.trim() || undefined
|
|
if (args.pushTarget && args.pushTarget.branchName !== branchNameOverride) {
|
|
return {
|
|
branchNameOverride,
|
|
pushTarget: undefined,
|
|
forkPushWarning: null
|
|
}
|
|
}
|
|
return {
|
|
branchNameOverride,
|
|
pushTarget: args.pushTarget,
|
|
forkPushWarning: args.forkPushWarning
|
|
}
|
|
}
|