Files
orca/src
NeilandOrca fb290efa58 review(r2): restrict display downgrade to macOS; fix blocker-swap leak
Adversarial review round 2 (agent-awake):
- MAJOR/disputed (Linux): reviewers split on whether prevent-app-suspension
  reliably inhibits system idle-suspend on Linux (logind IdleAction/inhibitor
  semantics vary by distro). Rather than ship on a debatable cross-platform
  guarantee, restrict the display downgrade to macOS only, where caffeinate
  -i -s is a canonical, always-present idle-sleep floor. Windows AND Linux now
  keep prevent-display-sleep unchanged. Copy is now display-behavior-neutral so
  it stays accurate on every platform.
- minor (leak): if a display->system blocker swap can't stop the old blocker
  (stop throws, Electron still reports it started), don't stack a second
  assertion — keep the current one and retry next refresh. Added a test.
- test: the no-downgrade case now covers both win32 and linux.

Co-authored-by: Orca <help@stably.ai>
2026-07-13 18:47:39 -07:00
..
2026-07-13 12:42:55 -07:00