Files
orca/config/scripts/client-hosted-browser-package-coverage.test.mjs
T
Neil 6e1b7e7fa3 test: remove junk tests that assert source text instead of behavior (#23815)
Deletes 101 test files and trims 112 more, all matching documented junk
patterns: exact source/import/string greps, copied inventories and export
lists, duplicate invocations of a contract another test already owns,
typeof-shape checks TypeScript already enforces, and self-comparisons.

The largest group read a production `.ts` file and asserted on its text —
for example a TaskPage test that required the source to contain
`selectedRepos.find((r) => r.id === newIssueRepoId) ?? selectedRepos[0] ?? null`.
Any behavior-preserving rename broke it; no behavior change ever did.

Production-side follow-through: exports that only these tests imported are
de-exported or deleted, stale comments pointing at removed censuses are
dropped, and the reliability-gate registry, `cloud/package.json` test lists,
and orphaned source-reading helpers are updated so nothing references a
deleted file.

Two files kept their real coverage and lost only the census scaffolding:
`agent-status-producer-census.test.ts` now drives all five producers end to
end instead of grepping the source tree, and `config-toml-trust-stale-writes`
replaces an export-list parity check.
2026-09-29 01:21:53 -07:00

59 lines
2.6 KiB
JavaScript

import { readFileSync } from 'node:fs'
import { join, resolve } from 'node:path'
import { describe, expect, it } from 'vitest'
import { parse } from 'yaml'
const projectDir = resolve(import.meta.dirname, '../..')
describe('client-hosted browser package coverage', () => {
it('finishes the installer process probe before concurrent native boundaries', () => {
const workflow = parse(readFileSync(join(projectDir, '.github/workflows/pr.yml'), 'utf8'))
const steps = workflow.jobs.package_windows.steps
const probe = steps.findIndex((step) => step.name === 'Test Windows installer process probe')
const boundaries = steps.findIndex((step) => step.name === 'Test Windows-specific boundaries')
const file = 'config/scripts/nsis-process-check.test.mjs'
expect(probe).toBeGreaterThanOrEqual(0)
expect(probe).toBeLessThan(boundaries)
expect(steps[probe].background).toBeUndefined()
expect(steps[probe].run).toContain(file)
expect(steps[boundaries].run).not.toContain(file)
})
it('runs client-hosted Electron lifecycle coverage on native package hosts', () => {
const prWorkflow = readFileSync(join(projectDir, '.github/workflows/pr.yml'), 'utf8')
const parsedWorkflow = parse(prWorkflow)
const linuxStep = parsedWorkflow.jobs.package.steps.find(
(step) => step.name === 'Test Linux Electron lifecycle boundary'
)
const windowsStep = parsedWorkflow.jobs.package_windows.steps.find(
(step) => step.name === 'Test Windows-specific boundaries'
)
const required = [
'browser-client-page-renderer-lifecycle',
'browser-route-webrtc-egress',
'browser-route-tcp-egress',
'browser-route-h3-egress',
'browser-route-dns-prefetch'
].map((name) => `src/main/browser/${name}.electron.test.ts`)
expect(linuxStep.run).toContain('xvfb-run --auto-servernum')
for (const file of required) {
expect(linuxStep.run).toContain(file)
expect(windowsStep.run).toContain(file)
}
})
// Why pinned: each of those files launches a full Electron stack twice under its own in-process
// deadline. Letting the runner interleave four of them starved the probes past those deadlines,
// which is the only way this step has ever failed.
it('gives each Linux Electron probe the runner to itself', () => {
const parsedWorkflow = parse(readFileSync(join(projectDir, '.github/workflows/pr.yml'), 'utf8'))
const linuxStep = parsedWorkflow.jobs.package.steps.find(
(step) => step.name === 'Test Linux Electron lifecycle boundary'
)
expect(linuxStep.run).toContain('--no-file-parallelism')
})
})