mirror of
https://github.com/stablyai/orca.git
synced 2026-10-31 09:07:40 +00:00
* [comment audit] Align legacy failure-read counts with cached display * [comment audit] Condense shared provider lifecycle and browser recovery comments [skip ci] * [comment audit] Condense shared generation, path and preview comments [skip ci] * [comment audit] Condense host, file and Git contract rationale [skip ci] * [comment audit] Tighten Git lifecycle and provider contract comments [skip ci] * [comment audit] Clarify shared host authority and launch isolation [skip ci] * [comment audit] simplify local access mobile and native chat contracts [skip ci] * [comment audit] simplify native chat presentation and state contracts [skip ci] * [comment audit] simplify native runtime and provider contracts [skip ci] * [comment audit] simplify migration and orchestration contracts [skip ci] * [comment audit] simplify plugin trust and process capture rationale [skip ci] * [comment audit] simplify terminal delivery and remote compatibility rationale [skip ci] * [comment audit] clarify remote recovery and launch wire rationale [skip ci] * [comment audit] shorten shared RPC compatibility and runtime evidence comments [skip ci] * [comment audit] simplify secure storage shell startup and sidebar rationale [skip ci] * [comment audit] clarify sidebar, skill and SSH invariants [skip ci] * [comment audit] condense structured chat delivery and timing rationale [skip ci] * [comment audit] condense terminal replay and telemetry invariants [skip ci] * [comment audit] clarify launch permission and terminal delivery rationale [skip ci] * [comment audit] clarify workspace ownership and layout contracts [skip ci] * [comment audit] wait for fitted and painted SSH terminal links * [comment audit] clarify layout persistence and session ownership [skip ci] * [comment audit] clarify host routing and workspace lifecycle contracts [skip ci] * [comment audit] clarify startup persistence and app lifetime comments [skip ci] * [comment audit] clarify recovery and activity boundaries [skip ci] * [comment audit] condense activity and artifact invariants [skip ci] * [comment audit] condense automation authority contracts [skip ci] * [comment audit] simplify automation scheduling and history contracts [skip ci] * [comment audit] clarify browser chrome and annotation lifecycles [skip ci] * [comment audit] clarify browser routing and retained guest ownership [skip ci] * [comment audit] clarify browser recovery and document ownership comments [skip ci] * [comment audit] restore hosted runners required by native IME fixtures * [comment audit] shorten preview, palette and dashboard invariants [skip ci] * [comment audit] clarify terminal preview, dashboard and retention comments [skip ci] * [comment audit] clarify diff-note recovery and editor lifecycle comments [skip ci] * [comment audit] shorten rich-text and combined-diff ownership comments [skip ci] * [comment audit] shorten autosave, draft recovery and model ownership comments [skip ci] * [comment audit] shorten save-queue, notebook and Markdown constraints [skip ci] * [comment audit] shorten Monaco, PDF and rich Markdown safeguards [skip ci] * [comment audit] clarify rich Markdown source and selection safeguards [skip ci] * [comment audit] clarify editor loading and emulator stream lifetimes [skip ci] * [comment audit] trim emulator and feature tour narration [skip ci] * [comment audit] clarify floating workspace and GitHub cache ownership [skip ci] * [comment audit] trim provider controls and Linear filter explanations [skip ci] * [comment audit] clarify pairing and chat resume lifetimes [skip ci] * [comment audit] clarify chat delivery and transcript lifetimes [skip ci] * [comment audit] clarify session options and host-owned status [skip ci] * [comment audit] clarify draft durability and live-status precedence [skip ci] * [comment audit] Trim chat send and model ownership explanations [skip ci] * [comment audit] Shorten transcript ownership and send recovery comments [skip ci] * [comment audit] Simplify native chat composer and transcript hook comments [skip ci] * [comment audit] Shorten native chat scroll and structured session explanations [skip ci] * [comment audit] Trim workspace picker and onboarding commentary [skip ci] * [comment audit] Simplify pet rendering, review cache and quick open comments [skip ci] * [comment audit] Trim sidebar and session history explanations [skip ci] * [comment audit] Condense session resume and review checks comments [skip ci] * [comment audit] Shorten checks state and file explorer refresh comments [skip ci] * [comment audit] Trim plugin bridge and source-control action rationale [skip ci] * [comment audit] Trim source-control listing and review rationale [skip ci] * [comment audit] Shorten sidebar lifecycle and explorer safeguards [skip ci] * [comment audit] Condense Settings account and appearance rationale [skip ci] * [comment audit] Trim pairing and repository Settings explanations [skip ci] * [comment audit] Condense Settings search SSH and terminal safeguards [skip ci] * [comment audit] Shorten Settings voice and provider ownership comments [skip ci] * [comment audit] Condense Settings draft persistence and host-state rationale [skip ci] * [comment audit] Trim Settings hooks and sidebar setup rationale [skip ci] * [comment audit] Condense sidebar deletion and board-filter safeguards [skip ci] * [comment audit] Condense worktree cards, host ownership and Markdown contracts [skip ci] * [comment audit] Condense sidebar drag, folder and filtering contracts [skip ci] * [comment audit] Condense sidebar parity, sleep and host ownership contracts [skip ci] * [comment audit] Prune focus-read baseline after comment cleanup * [comment audit] Clarify sidebar visibility, board drops and agent evidence [skip ci] * [comment audit] Tighten sidebar listing, drag and reveal contracts [skip ci] * [comment audit] Clarify viewport geometry and skill update safeguards [skip ci] * [comment audit] Tighten skill inventory, usage and host status comments [skip ci] * [comment audit] Clarify usage ownership and resource kill safeguards [skip ci] * [comment audit] Tighten tab selection, rename and search contracts [skip ci] * [comment audit] Tighten tab-strip geometry and drag ownership comments [skip ci] * [comment audit] Tighten Tasks recovery, pagination and mutation comments [skip ci] * [comment audit] Tighten provider loading and terminal recovery comments [skip ci] * [comment audit] Tighten completion, cadence and PTY ownership comments [skip ci] * [comment audit] Clarify terminal restore and parked-pane boundaries [skip ci] * [comment audit] Tighten PTY startup and replay explanations [skip ci] * [comment audit] Clarify PTY identity and delivery ownership [skip ci] * [comment audit] Shorten remote reconnect and input replay rationale [skip ci] * [comment audit] Condense terminal parking clipboard and file link comments [skip ci] * [comment audit] Clarify IME ownership and trim trace history [skip ci] * [comment audit] Shorten pane recovery and parked watcher explanations [skip ci] * [comment audit] Condense snapshot replay and visibility recovery rationale [skip ci] * [comment audit] Shorten terminal parking and keyboard ownership rationale [skip ci] * [comment audit] Trim renderer lifecycle and menu rationale [skip ci] * [comment audit] Condense workspace cleanup ownership and settlement notes [skip ci] * [comment audit] Clarify renderer hook evidence and source ownership [skip ci] * [comment audit] Tighten IPC ownership and reconnect explanations [skip ci] * [comment audit] Trim renderer focus, paste and attention comments [skip ci] * [comment audit] Shorten scroll, locale and agent lifecycle comments [skip ci] * [comment audit] Trim agent launch, resume and ownership commentary [skip ci] * [comment audit] Shorten account, browser and editor comments [skip ci] * [comment audit] Clarify host-mirror waits, previews and input ownership [skip ci] * [comment audit] Condense launch recovery and editor tokenization comments [skip ci] * [comment audit] Condense workspace selection and terminal pane rationale [skip ci] * [comment audit] Condense terminal fitting and rendering recovery comments [skip ci] * [comment audit] Condense terminal input and host routing explanations [skip ci] * [comment audit] Condense ownership and sleeping-session recovery rationale [skip ci] * [comment audit] Condense structured launch and terminal link explanations [skip ci] * [comment audit] Condense terminal ownership and workspace file routing rationale [skip ci] * [comment audit] Condense session persistence and workspace activation rationale [skip ci] * [comment audit] Condense workspace routing and browser ownership rationale [skip ci] * [comment audit] Condense mirror recovery and layout authority rationale [skip ci] * [comment audit] Condense runtime transport and file safety rationale [skip ci] * [comment audit] Condense runtime graph and structured session rationale [skip ci] * [comment audit] Condense browser creation and remote tab recovery rationale [skip ci] * [comment audit] Condense snapshot authority and publisher recovery rationale [skip ci] * [comment audit] Condense frame, startup and provider cache rationale [skip ci] * [comment audit] Condense host twin and agent lifecycle rationale [skip ci] * [comment audit] Condense browser authority and editor cleanup rationale [skip ci] * [comment audit] Condense editor buffer identity and review cache rationale [skip ci] * [comment audit] Condense provider lifetime and repository ownership rationale [skip ci] * [comment audit] Condense reconnect, hydration and terminal retirement rationale [skip ci] * [comment audit] Condense recovery, reconciliation and persistence rationale [skip ci] * [comment audit] Condense cleanup ownership and listing admission rationale [skip ci] * [comment audit] Condense teardown ordering and terminal ownership rationale [skip ci] * [comment audit] Condense recovery ledger and web host-boundary rationale [skip ci] * [comment audit] Condense web reconnect and credential lifecycle rationale [skip ci] * [comment audit] Condense cloud rollout and assignment safety rationale [skip ci] * [comment audit] Condense relay session and database recovery rationale [skip ci] * [comment audit] Condense relay placement and protocol compatibility rationale [skip ci] * [comment audit] Condense build and packaging constraints [skip ci] * [comment audit] Condense CI gates and validation isolation rationale [skip ci] * [comment audit] Condense catalog identity and browser validation rationale [skip ci] * [comment audit] Condense mobile browser and frame-budget rationale [skip ci] * [comment audit] Shorten mobile route and browser test explanations [skip ci] * [comment audit] Condense editor and session seam test rationale [skip ci] * [comment audit] Trim session and terminal closure history [skip ci] * [comment audit] Shorten terminal browser and census explanations [skip ci] * [comment audit] Preserve root-only E2E diagnostic baseline * [comment audit] Condense mobile seam and HTML preview test rationale [skip ci] * [comment audit] Condense preview instrumentation and render harness rationale [skip ci] * [comment audit] Condense bundle contracts and native-build constraints [skip ci] * [comment audit] Shorten native packaging and CI routing rationale [skip ci] * [comment audit] Condense release tooling and benchmark constraints [skip ci] * [comment audit] Condense packaging and platform gate rationale [skip ci] * [comment audit] Shorten mobile route and history rationale [skip ci] * [comment audit] Condense mobile browser and component rationale [skip ci] * [comment audit] Shorten drawer and workspace-form rationale [skip ci] * [comment audit] Trim mobile review and editor-document explanations [skip ci] * [comment audit] Condense editor lifecycle and Markdown explanations [skip ci] * [comment audit] Trim mobile file, diagnostics and dictation commentary [skip ci] * [comment audit] Simplify mobile host-list and workspace-view explanations [skip ci] * [comment audit] Clarify mobile shell lifetime and bridge delivery constraints [skip ci] * [comment audit] Condense bridge stream, native request and audio rationale [skip ci] * [comment audit] Reduce bridge schema and page-client commentary [skip ci] * [comment audit] Tighten mobile page bridge contracts [skip ci] * [comment audit] Clarify mobile cache and session constraints [skip ci] * [comment audit] Condense mobile route and lifecycle rationale [skip ci] * [comment audit] Tighten mobile shell hook timing rationale [skip ci] * [comment audit] Clarify route handoff and notification compatibility [skip ci] * [comment audit] Clarify push registration and dictation cleanup constraints [skip ci] * [comment audit] Condense keyboard geometry and native media ownership rationale [skip ci] * [comment audit] Tighten mobile chat scroll and composer concurrency rationale [skip ci] * [comment audit] Condense mobile reply compatibility and upload ownership rationale [skip ci] * [comment audit] Condense optimistic echo and scroll ownership rationale [skip ci] * [comment audit] Tighten stream replay and queued session ownership rationale [skip ci] * [comment audit] Condense mobile composer and reply-schema constraints [skip ci] * [comment audit] Clarify mobile transcript recovery and session ownership [skip ci] * [comment audit] Clarify mobile queue and source-control compatibility [skip ci] * [comment audit] Condense storage and task launch constraints [skip ci] * [comment audit] Clarify task schemas and terminal document ownership [skip ci] * [comment audit] Tighten terminal input and viewport rationale [skip ci] * [comment audit] Shorten terminal and RPC recorder contracts [skip ci] * [comment audit] Condense recorder engine and connection contracts [skip ci] * [comment audit] Shorten host credential and relay recovery comments [skip ci] * [comment audit] Tighten pairing recovery and bundle transport rationale [skip ci] * [comment audit] Clarify RPC delivery and workspace catalog boundaries [skip ci] * [comment audit] Condense catalog and relay entry contracts [skip ci] * [comment audit] Shorten shutdown and SSH relay delivery contracts [skip ci] * [comment audit] Condense WSL relay and E2E regression rationale [skip ci] * [comment audit] Shorten cross-version harness and renderer fixture explanations [skip ci] * [comment audit] Condense paired-host and E2E lifecycle rationale [skip ci] * [comment audit] Shorten layout oracle and regression explanations [skip ci] * [comment audit] Condense paired recovery and ownership regression contracts [skip ci] * [comment audit] Shorten restart, sidebar and SSH lifecycle contracts [skip ci] * [comment audit] Condense terminal rendering and IME regression rationale [skip ci] * [comment audit] Shorten terminal recovery and benchmark contracts [skip ci] * [comment audit] Condense tooling and Windows lifecycle proof rationale [skip ci] * [comment audit] Condense workflow routing and release rationale [skip ci] * [comment audit] Condense mobile security and installer contracts [skip ci] * [comment audit] Shorten native rationale and stylesheet workarounds [skip ci] * [comment audit] Shorten Windows visibility probe rationale [skip ci] * [comment audit] Condense embedded release and signing rationale [skip ci] * [comment audit] Retain current main test behavior in final reconciliation [skip ci] * [comment audit] Complete final comment review across current source inventory * [comment audit] Handle consolidated audit reports before final CI * [comment audit] Preserve credential storage census detail [skip ci] * [comment audit] Scale broad changed E2E selections with verified timing shards * [comment audit] Align E2E assertions with browser close and settled session metadata * [comment audit] Match existing E2Es to current resource and windowing contracts * [comment audit] Observe the shared server outage notice in reconnect coverage * [comment audit] Make existing renderer probes measure settled tab and PTY work * [comment audit] Align palette E2E selector with task search * [comment audit] Refresh remaining palette search selectors * [comment audit] Keep selector correction within selected audit specs * [comment audit] Await emoji fixture settings inside renderer evaluation * [comment audit] Cancel fixture fit retries between terminal tests --------- Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
201 lines
7.5 KiB
TypeScript
201 lines
7.5 KiB
TypeScript
import { catalogObjectPresence, type SchemaCatalogQuery } from './catalog-object-precheck.js'
|
||
import {
|
||
requireSchemaLockTarget,
|
||
sqlWithoutComments,
|
||
type SchemaLockTarget
|
||
} from './schema-lock-target.js'
|
||
|
||
const RETRYABLE_SCHEMA_CODES = new Set(['57014'])
|
||
const LOCK_NOT_AVAILABLE = '55P03'
|
||
const DEFAULT_RETRY_DEADLINE_MS = 30_000
|
||
const RETRY_BASE_DELAY_MS = 250
|
||
const RETRY_MAX_DELAY_MS = 2_000
|
||
const DEFAULT_EVENT_PREFIX = 'orca_relay_postgres_schema'
|
||
|
||
export type SchemaStartupOptions = {
|
||
// Enables the catalog pre-check. Without it every lock-taking statement is sent as before.
|
||
catalogQuery?: SchemaCatalogQuery
|
||
eventPrefix?: string
|
||
now?: () => number
|
||
random?: () => number
|
||
retryDeadlineMs?: number
|
||
// Only for a caller with no catalog pre-check, where a lock timeout still says nothing about
|
||
// whether the object exists.
|
||
retryLockTimeout?: boolean
|
||
wait?: (delayMs: number) => Promise<void>
|
||
}
|
||
|
||
export type SchemaApplySummary = { ran: number; skipped: number; deferred: number }
|
||
|
||
function retryDelayMs(attempt: number, random: () => number): number {
|
||
const ceiling = Math.min(RETRY_BASE_DELAY_MS * 2 ** (attempt - 1), RETRY_MAX_DELAY_MS)
|
||
return Math.ceil(ceiling * (0.5 + random() * 0.5))
|
||
}
|
||
|
||
function wait(delayMs: number): Promise<void> {
|
||
return new Promise((resolve) => setTimeout(resolve, delayMs))
|
||
}
|
||
|
||
const CREATE_TABLE_IF_NOT_EXISTS = /^CREATE\s+TABLE\s+IF\s+NOT\s+EXISTS\b/i
|
||
const CREATE_INDEX_IF_NOT_EXISTS = /^CREATE\s+(?:UNIQUE\s+)?INDEX\s+IF\s+NOT\s+EXISTS\b/i
|
||
const ALTER_TABLE_ADD_CONSTRAINT = /^ALTER\s+TABLE\s+\S+\s+ADD\s+CONSTRAINT\b/i
|
||
const DROP_INDEX_IF_EXISTS = /^DROP\s+INDEX\s+(?:CONCURRENTLY\s+)?IF\s+EXISTS\b/i
|
||
|
||
// Leading schema-deferrable marker permits deferral only for idempotent DDL with no later boot dependency.
|
||
// Read raw text because classification strips comments; next boot retries unapplied work.
|
||
const DEFERRABLE = /^\s*--[^\n]*\bschema-deferrable\b/
|
||
|
||
export function schemaDeferrable(statement: string): boolean {
|
||
return DEFERRABLE.test(statement)
|
||
}
|
||
|
||
// Concurrent CREATE losers can hit catalog 23505 or repeated name-check 42710/42P07; the next attempt is a no-op.
|
||
function concurrentCreateCollision(
|
||
value: { code?: unknown; constraint?: unknown },
|
||
sql: string
|
||
): boolean {
|
||
if (CREATE_TABLE_IF_NOT_EXISTS.test(sql)) {
|
||
return (
|
||
(value.code === '23505' && value.constraint === 'pg_type_typname_nsp_index') ||
|
||
value.code === '42710' ||
|
||
value.code === '42P07'
|
||
)
|
||
}
|
||
if (CREATE_INDEX_IF_NOT_EXISTS.test(sql)) {
|
||
return (
|
||
(value.code === '23505' && value.constraint === 'pg_class_relname_nsp_index') ||
|
||
value.code === '42P07'
|
||
)
|
||
}
|
||
return false
|
||
}
|
||
|
||
function constraintAlreadyApplied(error: unknown, sql: string): boolean {
|
||
return (
|
||
ALTER_TABLE_ADD_CONSTRAINT.test(sql) && (error as { code?: unknown } | null)?.code === '42710'
|
||
)
|
||
}
|
||
|
||
// IF EXISTS resolves before locking; another director’s DROP can commit between them and produce benign 42704.
|
||
function dropAlreadyApplied(error: unknown, sql: string): boolean {
|
||
return DROP_INDEX_IF_EXISTS.test(sql) && (error as { code?: unknown } | null)?.code === '42704'
|
||
}
|
||
|
||
function retryableSchemaError(error: unknown, sql: string): boolean {
|
||
const value = (error as { code?: unknown; constraint?: unknown } | null) ?? {}
|
||
return RETRYABLE_SCHEMA_CODES.has(String(value.code)) || concurrentCreateCollision(value, sql)
|
||
}
|
||
|
||
// Precheck immediately before each statement so prior creates in this boot are visible.
|
||
async function nothingToDo(
|
||
target: SchemaLockTarget | undefined,
|
||
options: SchemaStartupOptions,
|
||
eventPrefix: string
|
||
): Promise<boolean> {
|
||
const catalogQuery = options.catalogQuery
|
||
if (!catalogQuery || !target) return false
|
||
const presence = await catalogObjectPresence(catalogQuery, target)
|
||
if (presence.present !== (target.skipWhen === 'present')) return false
|
||
console.log(
|
||
JSON.stringify({
|
||
event: `${eventPrefix}_object_${target.skipWhen}`,
|
||
kind: target.kind,
|
||
table: target.kind === 'index-by-name' ? undefined : target.table,
|
||
name: target.name,
|
||
indisvalid: presence.indisvalid
|
||
})
|
||
)
|
||
return true
|
||
}
|
||
|
||
export async function applyPostgresSchema(
|
||
statements: string[],
|
||
query: (statement: string) => Promise<unknown>,
|
||
options: SchemaStartupOptions = {}
|
||
): Promise<SchemaApplySummary> {
|
||
const eventPrefix = options.eventPrefix ?? DEFAULT_EVENT_PREFIX
|
||
const now = options.now ?? Date.now
|
||
const random = options.random ?? Math.random
|
||
const pause = options.wait ?? wait
|
||
const deadlineAt = now() + (options.retryDeadlineMs ?? DEFAULT_RETRY_DEADLINE_MS)
|
||
const summary: SchemaApplySummary = { ran: 0, skipped: 0, deferred: 0 }
|
||
|
||
for (const statement of statements) {
|
||
// Throws when an index or column statement's target cannot be read, rather than sending it
|
||
// unchecked into the lock queue.
|
||
const target = requireSchemaLockTarget(statement)
|
||
if (await nothingToDo(target, options, eventPrefix)) {
|
||
summary.skipped += 1
|
||
continue
|
||
}
|
||
const sql = sqlWithoutComments(statement)
|
||
let attempt = 1
|
||
while (true) {
|
||
try {
|
||
await query(statement)
|
||
summary.ran += 1
|
||
break
|
||
} catch (error) {
|
||
if (constraintAlreadyApplied(error, sql) || dropAlreadyApplied(error, sql)) {
|
||
summary.skipped += 1
|
||
break
|
||
}
|
||
const code = String((error as { code?: unknown } | null)?.code)
|
||
// Prechecked missing objects lost the lock queue; retries would park writers for another timeout, so fail once.
|
||
if (code === LOCK_NOT_AVAILABLE && !options.retryLockTimeout) {
|
||
// Deferrable DDL yields instead of restarting every director into the same continuously written table’s lock queue.
|
||
if (schemaDeferrable(statement)) {
|
||
console.warn(
|
||
JSON.stringify({
|
||
event: `${eventPrefix}_object_deferred`,
|
||
code,
|
||
kind: target?.kind,
|
||
name: target?.name,
|
||
statement: sql.split('\n')[0],
|
||
detail: 'could not take its lock; left unapplied for the next boot to retry'
|
||
})
|
||
)
|
||
summary.deferred += 1
|
||
break
|
||
}
|
||
console.error(
|
||
JSON.stringify({
|
||
event: `${eventPrefix}_lock_timeout`,
|
||
code,
|
||
statement: sql.split('\n')[0],
|
||
detail: 'boot-time DDL could not take its lock; retrying would requeue every writer'
|
||
})
|
||
)
|
||
throw error
|
||
}
|
||
// Re-ask catalog after concurrent creation; retrying CREATE INDEX re-takes SHARE for an existing object.
|
||
if (
|
||
concurrentCreateCollision((error as { code?: unknown; constraint?: unknown }) ?? {}, sql) &&
|
||
(await nothingToDo(target, options, eventPrefix))
|
||
) {
|
||
summary.skipped += 1
|
||
break
|
||
}
|
||
const remainingMs = deadlineAt - now()
|
||
const retryable =
|
||
retryableSchemaError(error, sql) ||
|
||
(code === LOCK_NOT_AVAILABLE && options.retryLockTimeout === true)
|
||
if (!retryable || remainingMs <= 0) {
|
||
if (retryable) {
|
||
console.warn(
|
||
JSON.stringify({ event: `${eventPrefix}_retry_exhausted`, code, attempts: attempt })
|
||
)
|
||
}
|
||
throw error
|
||
}
|
||
const delayMs = Math.min(remainingMs, retryDelayMs(attempt, random))
|
||
console.warn(JSON.stringify({ event: `${eventPrefix}_retry`, code, attempt, delayMs }))
|
||
await pause(delayMs)
|
||
attempt += 1
|
||
}
|
||
}
|
||
}
|
||
console.log(JSON.stringify({ event: `${eventPrefix}_applied`, ...summary }))
|
||
return summary
|
||
}
|