Files
orca/tests/e2e/helpers
Jinwoo Hong 9b46c3f0f2 fix(terminal): let unselected Cmd+C reach apps that own their selection (#23597)
* fix(terminal): let unselected Cmd+C reach apps that negotiated kitty keyboard

On macOS Orca swallowed an unselected Cmd+C as a no-op copy, so a full-screen
TUI like Codex, which captures the mouse and keeps its highlight out of xterm's
selection, never received its own copy chord.

- isAppOwnedCopyChord (xterm-bypass-policy) is the one rule: macOS, no xterm
  selection, and non-zero kitty flags from the pane's mirror. The pane's xterm
  bypass and the dashboard popout's key handler both use it.
- A selection copy stays claimed through its repeats and release, including
  custom copy bindings, so kitty event reporting cannot leak them to the PTY.
- Plain shells keep sending nothing; Linux and Windows are unchanged.
- The e2e kitty helpers move to helpers/terminal-kitty-keyboard.ts so the
  shortcut spec stays under the line limit.

* fix(terminal): popout copy ownership reads xterm's selection like the pane

A highlight of blank cells trims to empty text but is still a selection, so the
popout must not hand that Cmd+C to a kitty app while the pane withholds it.

* test(terminal): keep the held-copy binding test beside the copy dispatch tests

The shortcut-policy suite is at its line limit.

* test(terminal): stub a blank-cell selection without widening the preview harness type

* style(terminal): tighten the app-owned copy comment and read the popout selection after the early return
2026-09-28 15:49:22 -04:00
..