From 07fcbdb0ba44616759f0699e4e98b69fcaad4052 Mon Sep 17 00:00:00 2001 From: l0ng-ai <24760907+l0ng-ai@users.noreply.github.com> Date: Sun, 23 Aug 2026 19:41:00 +0800 Subject: [PATCH] docs(test): note which bash the pty test covers on which machine MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The rcfile installs its hook into PROMPT_COMMAND as an array only on bash 5.1 and up, and appends to a string below that — a version check inherited from bash-preexec. macOS still ships 3.2.57, so a developer run takes the older branch and a Linux CI runner takes the newer one. Neither machine covers both, which is worth saying in the test rather than leaving for someone to work out from a passing run. --- crates/tty7-core/src/daemon/shell_integration.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/crates/tty7-core/src/daemon/shell_integration.rs b/crates/tty7-core/src/daemon/shell_integration.rs index 138fc67b..9e3504ed 100644 --- a/crates/tty7-core/src/daemon/shell_integration.rs +++ b/crates/tty7-core/src/daemon/shell_integration.rs @@ -2130,6 +2130,13 @@ mod tests { /// `zsh_reports_the_full_prompt_cycle_over_a_real_pty` gives: the empty /// sentinel is what stops the injected rc guarding itself off inside a /// tty7 pane. + /// + /// Worth knowing what this covers where: the rcfile installs its hook into + /// `PROMPT_COMMAND` as an array only on bash 5.1 and up, and appends to a + /// string below that. macOS still ships 3.2.57, so a developer run here + /// exercises the older branch and a Linux CI runner exercises the newer + /// one — between them both halves of that version check are run, which + /// neither machine does alone. #[cfg(unix)] #[test] fn bash_reports_the_full_prompt_cycle_over_a_real_pty() {