From 2a276d10414b8d126e38261bb0fe2a539662834b Mon Sep 17 00:00:00 2001 From: l0ng-ai <24760907+l0ng-ai@users.noreply.github.com> Date: Sat, 8 Aug 2026 20:13:02 +0700 Subject: [PATCH] fix(sftp): make the cancel button match the one beside it MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The transfer row draws its reveal button as an IconName::Close-family icon inside a 24px hit target with a tooltip; the cancel button next to it was a bare "✕" text label with neither. It is the only glyph-as-label button in the app — every other close in this file and the eight others across the UI use IconName::Close. Verified by matching the sibling's construction, not on screen: showing it needs a transfer in flight against a live SSH host. --- src/ui/sftp.rs | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/ui/sftp.rs b/src/ui/sftp.rs index 003fb820..9471d7f5 100644 --- a/src/ui/sftp.rs +++ b/src/ui/sftp.rs @@ -1650,13 +1650,18 @@ impl Tty7App { }) .when(running, |this| { this.child( - Button::new(("sftp-cancel-job", job_id as usize)) - .label("✕") - .xsmall() - .ghost() - .on_click(cx.listener(move |this, _, _w, cx| { + crate::ui::tab_strip::hit_target( + Button::new(("sftp-cancel-job", job_id as usize)) + .icon(IconName::Close) + .xsmall() + .ghost(), + ) + .tooltip(t(L10nKey::Cancel)) + .on_click( + cx.listener(move |this, _, _w, cx| { this.sftp_cancel_job(job_id, cx) - })), + }), + ), ) }), )