From e17bebb7e2f2e50e6f71aa6bfd9ca398e7ebe841 Mon Sep 17 00:00:00 2001 From: l0ng-ai <24760907+l0ng-ai@users.noreply.github.com> Date: Sat, 8 Aug 2026 08:35:50 +0700 Subject: [PATCH] fix(chrome): give the last icon-only buttons the tooltips their twins have MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Every icon-only control in the chrome names itself on hover — except the settings close, the two SSH ellipsis menus, the switcher row menu, and the tab close in both the strip and the sidebar. Same glyphs, same jobs, same words as the buttons beside them. --- src/ui/settings.rs | 3 +++ src/ui/switcher.rs | 1 + src/ui/tab_sidebar.rs | 1 + src/ui/tab_strip.rs | 1 + 4 files changed, 6 insertions(+) diff --git a/src/ui/settings.rs b/src/ui/settings.rs index 8eb6a30e..ac5de705 100644 --- a/src/ui/settings.rs +++ b/src/ui/settings.rs @@ -977,6 +977,7 @@ impl Tty7App { .w(px(TILE_SIZE)) .h(px(TILE_SIZE)) .rounded_lg() + .tooltip(t(L10nKey::Close)) .on_click(cx.listener(|this, _, window, cx| { this.close_settings_checked(window, cx) })), @@ -1710,6 +1711,7 @@ impl Tty7App { .icon(Icon::empty().path("stock/icons/ellipsis.svg")) .ghost() .small() + .tooltip(t(L10nKey::TabTooltipMore)) .dropdown_menu_with_anchor( gpui::Anchor::TopRight, move |menu, _window, _cx| { @@ -2001,6 +2003,7 @@ impl Tty7App { .icon(Icon::empty().path("stock/icons/ellipsis.svg")) .ghost() .small() + .tooltip(t(L10nKey::TabTooltipMore)) .dropdown_menu_with_anchor( gpui::Anchor::TopRight, move |menu, _window, cx| { diff --git a/src/ui/switcher.rs b/src/ui/switcher.rs index 8d414da8..068361b9 100644 --- a/src/ui/switcher.rs +++ b/src/ui/switcher.rs @@ -1740,6 +1740,7 @@ impl Tty7App { .ghost() .xsmall(), ) + .tooltip(t(L10nKey::TabTooltipMore)) .dropdown_menu(move |menu, _window, _cx| { row_menu(menu, &menu_ref, app.clone()) }), diff --git a/src/ui/tab_sidebar.rs b/src/ui/tab_sidebar.rs index 140f7177..13cffdbf 100644 --- a/src/ui/tab_sidebar.rs +++ b/src/ui/tab_sidebar.rs @@ -370,6 +370,7 @@ impl Tty7App { .ghost() .xsmall(), ) + .tooltip(t(L10nKey::TabContextCloseTab)) .on_click( cx.listener(move |this, _, window, cx| { this.close_tab(i, window, cx); diff --git a/src/ui/tab_strip.rs b/src/ui/tab_strip.rs index a4f09b11..67654ea1 100644 --- a/src/ui/tab_strip.rs +++ b/src/ui/tab_strip.rs @@ -1043,6 +1043,7 @@ impl Tty7App { .ghost() .xsmall(), ) + .tooltip(t(L10nKey::TabContextCloseTab)) .on_click(cx.listener( move |this, _, window, cx| { this.close_tab(i, window, cx);