From eb6c7ca3b39f87dd9033ed6f58b8d0abe8be33ae Mon Sep 17 00:00:00 2001 From: l0ng-ai <24760907+l0ng-ai@users.noreply.github.com> Date: Tue, 14 Jul 2026 17:38:10 +0800 Subject: [PATCH] fix(release): stop {tmp} from closing the Windows installer [Code] comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The [Code] block comment used Pascal { } braces, but {tmp} inside it closed the comment early, so ISCC parsed the trailing prose as code and aborted with "'BEGIN' expected" — no Windows installer was produced. Switch the comment to (* *) so brace-form constants stay literal. --- .github/scripts/windows-installer.iss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/scripts/windows-installer.iss b/.github/scripts/windows-installer.iss index d4099f31..1303603c 100644 --- a/.github/scripts/windows-installer.iss +++ b/.github/scripts/windows-installer.iss @@ -75,13 +75,13 @@ Filename: "{app}\tty7.exe"; Description: "{cm:LaunchProgram,tty7}"; Flags: nowai Filename: "{app}\tty7.exe"; Parameters: "--stop-daemon"; Flags: runhidden waituntilterminated; RunOnceId: "StopDaemon" [Code] -{ Gracefully stop the persistent daemon before we overwrite tty7.exe. We can't +(* Gracefully stop the persistent daemon before we overwrite tty7.exe. We can't run the *installed* binary here — on an upgrade from an older build it may not understand --stop-daemon and would launch the GUI instead — so we extract the *new* tty7.exe to {tmp} and run that. It connects to the running daemon, hangs up every shell, waits for it to exit (releasing the file lock), then returns without opening a window. Best effort: any failure falls through to the Restart - Manager backstop, and a fresh install simply has no daemon to stop. } + Manager backstop, and a fresh install simply has no daemon to stop. *) function PrepareToInstall(var NeedsRestart: Boolean): String; var ResultCode: Integer;