mirror of
https://github.com/l0ng-ai/tty7.git
synced 2026-09-22 08:02:24 +00:00
l0ng-aiandl0ng-ai
0df604054d
* fix(daemon): keep a lingering daemon findable and reapable after quit-and-stop Quit-and-stop could strand a daemon that had already unlinked daemon.sock and deleted daemon.pid but never finished exiting: libc exit() runs atexit handlers and static destructors beside dozens of live threads, and a finalizer that blocks leaves the process holding the singleton lock with no name on disk. Every later launch then spawns a daemon that stands down against the lock and times out red, forever. Three changes, each a fallback for the others: - on_shutdown keeps the pidfile: once the endpoint is unlinked it is the only handle anything has on a process that is not gone yet. A pidfile that outlives a clean exit was already handled by recorded_daemon_is_dead and the reap path. - The daemon exits through _exit(2) (after flushing the logger), skipping the atexit/destructor window entirely; everything owed to disk is flushed explicitly in on_shutdown. - spawn::stop reaps with the pid it captured before asking the daemon to die, instead of re-reading a pidfile an old build's shutdown may have wiped mid-stop; reap_recorded_daemon keeps the pidfile when the process survives even SIGKILL, so the next attempt still has someone to reap. * review: fix stale stop() comment, pin the mid-stop pidfile-vanish ordering in the test The comment at the top of stop() still claimed a clean shutdown removes the pidfile, which this branch just made untrue; it now states the real reasons the pid is captured early. The vanishing-pidfile test now asserts the sweeper's delete actually landed while stop() was waiting, so a future shrink of PROCESS_EXIT_TIMEOUT cannot silently turn it into a weaker scenario. --------- Co-authored-by: l0ng-ai <24760907+l0ng-ai@users.noreply.github.com>
35 lines
1.3 KiB
TOML
35 lines
1.3 KiB
TOML
[package]
|
|
name = "tty7-server"
|
|
version.workspace = true
|
|
edition.workspace = true
|
|
description = "tty7's headless session server: the persistent terminal daemon, with no GUI attached"
|
|
repository = "https://github.com/l0ng-ai/tty7"
|
|
license = "Apache-2.0"
|
|
publish = false
|
|
|
|
[[bin]]
|
|
name = "tty7-server"
|
|
path = "src/main.rs"
|
|
|
|
# One dependency, on purpose. This binary exists to prove — and keep proving —
|
|
# that everything a tty7 session needs runs without gpui: if it ever grows a
|
|
# second dependency that the GUI also needs, that dependency belongs in
|
|
# `tty7-core` instead.
|
|
[dependencies]
|
|
tty7-core = { path = "../tty7-core" }
|
|
|
|
# The end-to-end proof (`tests/stdio_conformance.rs`) runs `tty7-core`'s shared
|
|
# `Host` conformance suite against a *real* `tty7-server --stdio` child process.
|
|
# It has to live in this crate because that is the crate that owns the binary —
|
|
# `CARGO_BIN_EXE_tty7-server` only exists for its own tests.
|
|
[dev-dependencies]
|
|
# Sandboxes for the suite: an empty directory per case, removed on drop. The
|
|
# server is on this machine, so a local temp dir is a path in its namespace.
|
|
tempfile = "3"
|
|
# `tests/daemon_stop.rs` probes and, on failure, kills the daemon it spawned;
|
|
# a pid needs `kill(2)`, which `Child` cannot express once ownership has moved
|
|
# to the thread collecting the exit.
|
|
libc = "0.2"
|
|
[lints]
|
|
workspace = true
|