mirror of
https://github.com/l0ng-ai/tty7.git
synced 2026-09-21 16:02:20 +00:00
l0ng-ai
b559ae658d
A restored pane came back with the killed program's mouse reporting still on, so every pointer move over it was typed into the new shell's line as an SGR report and the line grew for as long as the pointer stayed there. The chain is short and each link is deliberate. A snapshot is a raw byte stream, not a rendered grid, and `scrollback.rs` says so in its own module doc. `ReplayRing::seeded` puts those bytes into the restored pane's ring verbatim, and the client hands them straight to its parser at `DaemonMsg::Snapshot`. So the dead program's `?1002h` is not a description of a screen, it is an instruction, and it is executed a second time against a shell that never asked for it. There is nothing after it to undo it: `DaemonPane::kill` is a hangup with no grace period, so the program never emitted its own `?1002l`, and the snapshot was photographed before the kill anyway. `restore_preamble` already exists to keep exactly this kind of leftover away from the incoming shell — it resets the alternate screen, the cursor, autowrap and the graphic rendition — and it simply stopped short of the modes that make the terminal talk back. It now also turns off mouse reporting and its encodings, focus reporting, bracketed paste, application cursor keys and the kitty keyboard flags. Unconditionally, which was the choice worth making. The alternative was to fold the snapshot's bytes through a mode tracker and clear only what the fold says is still on, which is what #828 does for the neighbouring re-attach path. That precision is essential there and buys nothing here: there the pane is alive and re-sending a mode it had turned off would be wrong, whereas here the target state is a constant. The incoming shell is brand new, it has not written a byte when the preamble is appended, and it asked for none of these modes, so there is nothing to preserve and no mode whose value has to be discovered. The risk is not symmetric either. Switching off a mode that is already off is a no-op in every emulator, so the blunt version cannot fail; a fold that misparses one sequence leaves the mode on and the bug exactly as it is today, silently. The blunt version also needs nothing from #828, so this can merge in either order. Left alone on purpose: `?1007` alternate scroll, which a default terminal has on, so clearing it would walk away from the default rather than back to it; `?2026` synchronised update, which the client's processor already closes out when a replayed frame ends inside one; and `stale_mode_resets` in the client, whose conditional shape is right for the live pane at a prompt that it serves. Scrolling regions and origin mode are a different failure with no report behind them and are not touched. The test that locked in the short reset list now locks in the long one, and asserts the `?1007` omission so it stays deliberate. A second test runs the real chain — a snapshot ending inside a full-screen program, `ReplayRing::seeded`, the preamble — and asserts that the ring a client would replay has `l` as its last word on every reporting mode. Both fail on the previous preamble. Claude-Session: https://claude.ai/code/session_01UUyWQXzcBAoBzaSX8pc7nU