From 0d143dcfccf20da7eefe15360aa58906212ec41b Mon Sep 17 00:00:00 2001 From: Matthew Meszaros Date: Sat, 23 May 2026 16:48:45 +0000 Subject: [PATCH] ci: golangci-lint disable-all + explicit enable so errcheck stays off `linters: enable: [...]` doesn't suppress the default lint set; errcheck was still running and failing on legacy tx.Rollback() etc. Flip to disable-all + explicit enable for a deterministic active set. --- .golangci.yml | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 98a9dfd1..c5ded0cb 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -3,14 +3,11 @@ run: modules-download-mode: readonly linters: - # Curated set focused on real bugs, not stylistic churn. errcheck, - # unparam, prealloc, gosec, exportloopref are intentionally - # disabled — the legacy codebase has thousands of unchecked - # `tx.Rollback()` calls (which is idiomatic — Rollback after a - # successful Commit is a no-op), preallocation suggestions on hot - # paths the author chose not to follow, gosec rules that don't - # apply to our control-plane code, and exportloopref's check is - # already covered by govet's loopclosure in modern Go. + # disable-all + explicit enable list so we don't accidentally + # inherit golangci-lint's defaults (which include errcheck — the + # legacy codebase has thousands of unchecked tx.Rollback() calls + # that aren't worth fixing in this PR). + disable-all: true enable: - gosimple - govet