Commit Graph
2009 Commits
Author SHA1 Message Date
Matthew Meszaros 8e419fc2cf feat: walk campaign sending windows by calendar date in nextScheduleSlot so 23- and 25-hour DST days are stepped correctly, fail closed when no window is found, resolve window starts in skipped or repeated hours, step the other scheduler 'tomorrow' helpers by calendar day, and add time zone sweep tests 2026-10-24 18:04:05 +02:00
Matthew Meszaros d205d8c227 feat: record the defaulted tls_unverified and tls_pin SMTP/IMAP credential fields in the published worker command Avro schema in eventschemas testdata 2026-10-24 12:44:45 +02:00
Matthew Meszaros 88e4370f1f feat: merge main into the mailbox, session and input validation branch, move the resolved MAIL_ALLOW_PRIVATE_HOSTS and MAIL_TLS_INSECURE node env lines into fleetnode.RenderEnv, renumber the mailbox TLS pin migration to 000324, and keep both sides of the configuration reference 2026-10-24 12:20:12 +02:00
Matthew Meszaros b3d8c5acfd Merge pull request #1045 from warmbly/feat/release-auto-deploy
feat: release auto-deploy to AWS, fleet canary waves, in-AWS key rotation and Terraform CI
2026-10-24 07:53:36 +00:00
Matthew Meszaros 21acf00257 feat: resume a key rotation stage that died part way from its saved intent with per-phase state tokens, deploy all to only the ECS services an install runs, fail updater --check-env while another update holds the lock, keep the running image when adopting a node, judge rollout liveness on the service clock, deny the CI roles changes to their own permissions, and validate the Terraform plan class before acting on it 2026-10-24 09:34:01 +02:00
Matthew Meszaros c7247e4da1 feat: list send holds with no recorded send as task_missing instead of failing the scan, count unverified send results only once a send is ten minutes past reservation, treat a later legacy-confirmed warmup send as recovery in the 24h failure count, and say the Holds tab offers resolve only on eligible holds 2026-10-24 09:27:12 +02:00
Matthew Meszaros 98e4b10141 feat: add an admin Sends > Holds tab and POST /admin/sends/holds/:id/resolve for recording provider-checked outcomes on held mailboxes, count send holds only on switched-on mailboxes past the in-progress window, narrow failed-send monitoring to mailbox failures without a later confirmed send, and show broker lag as a measurement instead of an attention signal 2026-10-24 09:14:02 +02:00
Matthew Meszaros 9c2cffae58 feat: deploy stable releases to AWS automatically with provenance checks, a migration gate, alarm-watched waves and reverse rollback, move worker and consumer hosts in canary rollouts with host-side health rollback and opt-in env refresh, rotate instance keys inside AWS through a rotator task and the rotate-keys workflow, plan and apply the AWS Terraform from CI with approval for replacements, and add the admin Keys tab and the matching runbooks 2026-10-24 09:10:52 +02:00
Matthew Meszaros c93c88dd36 feat: retire queued warmup work when a mailbox update pauses warmup alongside explicit participation flags, label a warmup-on receive-only mailbox as receiving only in the mailbox drawer, and say in the warmup guide that resuming restores receiving only when participation allows it 2026-10-23 22:29:05 +02:00
Matthew Meszaros 12c87181e7 feat: stop delivering warmup mail to a mailbox whose warmup is paused or never started by requiring warmup on in the recipient predicate behind partner candidates, dispatch authorization, reservation and reply-back eligibility, and retire queued sends to it when warmup is paused 2026-10-23 21:59:05 +02:00
Matthew Meszaros 05f9f6a3cd feat: report a Cloud pool link enrollment refused on a revoked link as pool_link_revoked from every enroll path (adopt, managed sign-in, SMTP association and enroll) and say in the Warmbly Cloud guide that the detached-link stop keeps retrying mailboxes it could not stop past its rollout window 2026-10-23 21:19:52 +02:00
Matthew Meszaros 9ef0f04efc feat: stop Cloud warmup sending and receiving once for mailboxes of pool links revoked before revocation stopped them, found through their managed sign-in and adoption records and skipped when a live link holds them, from a backend job that repeats through the rollout and then records completion in admin_settings 2026-10-23 20:47:06 +02:00
Matthew Meszaros 99197f3455 feat: commit Cloud pool link enrollments under the instance lock that revocation holds and refuse an enrollment on a revoked link in the insert itself, so every mailbox of a revoked link is stopped or never enrolled, with race and live tests and the Cloud version that applies the disconnect stop in the docs 2026-10-23 20:00:58 +02:00
Matthew Meszaros 9be5c8a3c3 feat: give API refusals stable codes and actionable messages (attempt_check_unavailable and code_lookup_limited with Retry-After, account and workspace standing codes, session_ended, reset_link_invalid, sessions_not_ended, api_credentials_revoke_unsupported, invitation_expired, image_unreadable and the other image upload codes, own-domain redirects naming the allowed domains, Pipedrive reload guidance, duplicate parameters, structured forms service errors), and show them in the dashboard, admin panel and warmbly CLI 2026-10-23 19:53:03 +02:00
Matthew Meszaros cc1dc2f64c feat: answer refused realtime handshakes with a JSON code and reason, name a reused ws ticket or signed-out session, use the not_a_member slug on org joins, warn at boot when REALTIME_ALLOW_QUERY_CREDENTIALS is on, stop the admin socket reconnecting on admin_mfa_required, not_an_admin and jwt_required with a clear message, and have the seeder, updater, webhook and notification URL checks, instance health, fleet join and log mail transport say which setting applies and what to do 2026-10-23 19:53:03 +02:00
Matthew Meszaros 3532039037 feat: explain each refused mailbox connection in plain words with what to do (a host on a private network address, sign-in offered only unencrypted, no STARTTLS, no supported AUTH mechanism, an unverified or unpinned certificate, a send whose content could not be decrypted) in the connection test, stored mailbox errors and import causes, add an optional reason to API error responses with certificate_untrusted on mailbox_tls_failed for the dashboard's trust option, and treat tls_unverified and tls_pin as post-fixture fields in the Avro envelope test 2026-10-23 19:52:54 +02:00
Matthew Meszaros f60dddb1f3 feat: stop Cloud warmup sending and receiving for every mailbox a revoked pool link enrolled before the link ends, so a detached instance's mailboxes receive no new, reply-back or queued diagnostic mail, with retryable revoke, live recipient-gate tests and Warmbly Cloud docs 2026-10-23 19:51:10 +02:00
Matthew Meszaros fdc611c806 feat: scope the AI switch step's newest-reply lookup (GetBySender) to the campaign's organization instead of the campaign owner's user id, so replies that reach a teammate's mailbox are seen, and drop the unused unibox Incoming service method 2026-10-23 19:08:32 +02:00
Matthew Meszaros 77a64b4d86 Merge pull request #1020 from thejdubb02/fix/1015-getbysender-display-name
feat: match a bare contact address against from_addr entries that carry a display name in GetBySender, so an AI switch step sees the contact's reply, with a live test run in CI
2026-10-23 16:42:40 +00:00
Matthew Meszaros dbfb46614f feat: read the sender's address from the last angle-bracketed address or a bare address before a comment in bareAddrSQL, never from one written inside the display name or the comment, and use it in LatestThreadIDForContact too 2026-10-23 18:22:44 +02:00
Matthew Meszaros 79c334487d Merge pull request #1023 from NathanielLLally/fix/send-time-subsecond
fix(scheduler): keep a send already inside a preferred hour
2026-10-23 16:19:12 +00:00
Matthew Meszaros 4ba69b9b1a Merge pull request #1032 from 555aaditya/fix/leadsync-columns-past-z
feat: read every column of a Google Sheets lead-sync tab instead of stopping at column Z
2026-10-23 15:48:48 +00:00
Matthew Meszaros 911ed27b86 Merge pull request #1033 from 555aaditya/fix/audit-oauth-applications
feat: audit workspace OAuth app writes and refresh teammates' app lists through the realtime audit spine
2026-10-23 15:48:45 +00:00
Nathaniel Lally 896d12b8c1 feat: keep a campaign send already inside a send-time optimization preferred hour in snapToPreferredHour instead of rebuilding it with time.Date, which dropped its nanoseconds and deferred every lead to the next preferred hour forever 2026-10-23 17:48:17 +02:00
Matthew Meszaros e29593501e feat: refuse a manual send in emailsend when the sender's ban scope or the workspace's sending suspension cannot be read, failing closed with a fixed internal error 2026-10-23 16:22:38 +02:00
Matthew Meszaros 03fd30f9bc feat: merge decoded-byte image validation with download-safe serving, own-domain form and domain redirects, TLS-only SMTP AUTH negotiation and pinned per-server certificate opt-outs, with MAIL_TLS_INSECURE honoured on self-hosted and development instances and resolved by the control plane for joining nodes 2026-10-23 16:20:30 +02:00
Matthew Meszaros 920013807c feat: offer a plain-words option to trust a mail server's own certificate in the SMTP/IMAP connect and reconnect forms after a test fails on its certificate, add a Server certificates section to the mailbox drawer's Settings tab showing each server's certificate authority or pinned SHA-256 fingerprint with a Re-confirm action that tests the servers and pins what they present after an in-app confirmation, and point the certificate error texts at that section 2026-10-23 16:15:55 +02:00
Matthew Meszaros 573e79ce8e feat: store each SMTP/IMAP server's certificate opt-out and pinned SPKI SHA-256 on email_accounts_smtp_imap (migration 000326, expand-only), carry tls_unverified and tls_pin in ADD_EMAIL, Cloud enrolment and vendor reconnect, keep an opt-out only for a certificate that fails CA verification and pin it to what the connection test saw, keep it across a credential change for the same host, name the presented certificate in a TLS refusal, and add GET /emails/:id/certificates plus session-only check and confirm endpoints that pin the fingerprints the owner confirmed 2026-10-23 16:15:55 +02:00
Matthew Meszaros 4624cc4a74 feat: negotiate mailbox SMTP AUTH by link (LOGIN then PLAIN only over TLS or loopback, CRAM-MD5 last, never a password mechanism in cleartext) for the send path, the connection test and the platform relay, honour MAIL_TLS_INSECURE only under APP_ENV=dev, and trust a mailbox server whose owner opted out of CA verification only on its pinned SPKI SHA-256 via VerifyConnection, reporting TLS_CERTIFICATE_CHANGED or TLS_CERTIFICATE_UNCONFIRMED as retryable connection errors 2026-10-23 16:15:55 +02:00
Matthew Meszaros 94095b9512 feat: merge context-escaped html/template campaign bodies, bounded template execution, uniform fail-closed decryption on the send path and counted legacy plaintext secret reads with instance-mode resealing 2026-10-23 16:08:49 +02:00
Matthew Meszaros 61cf65fde1 feat: count every read of a mailbox credential, webhook signing secret or OAuth app webhook secret still stored in plaintext through internal/observability/legacysecret without logging the value, log reseal seal and write failures by class, and have the consumer reseal job seal plaintext OAuth tokens under CREDENTIALS_ENCRYPTION_KEY when MAILBOX_CREDENTIALS_SEALING=instance 2026-10-23 16:07:57 +02:00
Matthew Meszaros 60cef7bcdc feat: return one uniform decrypt error from the org cipher and the instance encrypter for malformed, short, tampered or foreign-key ciphertext, and answer a send whose subject or body cannot be decrypted or whose workspace key cannot be loaded with EMAIL_FAILED and a fixed reason through failSend, logging only the failure class and never sending 2026-10-23 16:07:55 +02:00
Matthew Meszaros 54e6910bb1 feat: render campaign, placement and preview HTML bodies through html/template so every contact, custom-field, AI and sender value is escaped for its context (text, attribute, URL scheme), keep the mailbox signature and Outlook conditional comments as written, escape the plain-substitution fallback with a context scanner under the 1 MB cap, and leave subject and plain text unescaped 2026-10-23 16:07:48 +02:00
Matthew Meszaros 1a77dbbd2b feat: bound template execution in tmplfuncs by refusing call, capping printf/print/println/html/js/urlquery/join output, metering range steps, limiting variables to 64 and function arguments to 32, adding a context-escaping CompileHTML, and make the integration fallback a single non-rescanning pass under the same output cap 2026-10-23 16:07:43 +02:00
Matthew Meszaros dba87e8d74 feat: merge fail-closed ban and attempt-budget reads, 48-hour invitations and tester passwords with one-click resend, transactional invitation consumption, development-only seeding and redacted log mail links 2026-10-23 16:06:29 +02:00
Matthew Meszaros f2f42792f5 feat: redact link query strings in the log mail transport unless APP_ENV names development, log warmup arrivals by task id rather than token, and name the matched route instead of the URI in tracking request spans, with the installer, boot warnings and self-host docs saying where codes and links can be read 2026-10-23 16:06:00 +02:00
Matthew Meszaros 68c87cb751 feat: merge resolved-peer address checks on every mail dial, strict bounded autoconfig XML, shell-free updater commands and refusal of repeated single-valued query parameters and credential headers 2026-10-23 16:04:08 +02:00
Matthew Meszaros 9bb0a39e96 feat: answer a repeated single-valued query parameter with 400 duplicate_query_parameter and a repeated Authorization, X-Warmbly-Token, Idempotency-Key or Origin header with 400 duplicate_header on the API and forms service, keep the documented list parameters repeatable, fold X-Forwarded-For lines and read the last line of the other forwarding headers there and in the tracking service 2026-10-23 16:03:06 +02:00
Matthew Meszaros d1a4097658 feat: run the updater's UPDATER_COMMAND as an argv of an absolute executable and plain arguments without a shell, pass the self-recreate compose arguments to a constant script positionally, and validate the compose project, profiles and git remote names at updater start 2026-10-23 16:03:02 +02:00
Matthew Meszaros 976c99b4aa feat: decode mail autoconfig and ISPDB XML in strict mode with a 64 KiB bound, refusing any document that carries a DTD or other directive before it is parsed 2026-10-23 16:02:59 +02:00
Matthew Meszaros d7bacf6112 feat: check every mailbox SMTP and IMAP dial against its resolved peer address in netbind, refusing loopback, private, link-local, CGNAT, multicast and metadata addresses on hosted production and wherever MAIL_ALLOW_PRIVATE_HOSTS=false, render that resolved policy into each joining node's env, and honour WARMBLY_ALLOW_UNSAFE_WEBHOOK_URLS only on self-hosted or development instances 2026-10-23 16:02:52 +02:00
Matthew Meszaros 0d76f81a3f feat: cap workspace invitations and reviewer tester passwords at 48 hours, quote each invitation's real remaining lifetime in its email, list recently expired invitations behind include_expired on GET /organization/invitations, and add a one-click Resend for expired invitations on the members settings page 2026-10-23 15:57:22 +02:00
Matthew Meszaros 28277cad5c feat: send form redirects and sending-domain root redirects only to the workspace's own domains (mailbox domains, verified tracking hosts and the verified forms domain, via internal/app/owndomain), refusing others with redirect_target_not_own_domain at save, falling back to the success message or no redirect at serve time, releasing Cloud-served ones that no longer qualify, and flagging saved destinations not in use in the dashboard and docs 2026-10-23 15:53:32 +02:00
Matthew Meszaros 123965fb81 feat: merge absolute session expiry, revoke-before-write password changes with optional API credential revocation, bounded Pipedrive tokens, always-Secure broker cookie, body-carried reset sessions and atomic Slack state 2026-10-23 15:52:51 +02:00
Matthew Meszaros 107bd854ca feat: consume Sign in with Slack verification state and held link-code questions with one atomic read-and-delete in Redis (and under the guard mutex without Redis) so each state completes at most one verification 2026-10-23 15:51:13 +02:00
Matthew Meszaros b4c7067174 feat: mark the brokered mailbox sign-in's browser-binding cookie Secure in every environment except plain-http development, and post the binding value from the consent page in a form body to POST /addresses/connect/continue while still accepting the query form from pages the previous release rendered 2026-10-23 15:50:13 +02:00
Matthew Meszaros 0c40e53e02 feat: bind each realtime ws ticket to the session that minted it and accept it once while that session is live, require a second-factor session to join admin:platform, confine API key and OAuth sockets to their own workspace with member permissions narrowed to their read scopes, and refuse those credentials in the socket URL unless REALTIME_ALLOW_QUERY_CREDENTIALS=true 2026-10-23 15:48:00 +02:00
Matthew Meszaros a786d26fa3 feat: require every Pipedrive panel and modal token to carry an issued-at within 15 minutes or an expiry within 24 hours and refuse one with neither, and answer the Pipedrive app routes with Referrer-Policy no-referrer and no-store so the signed query token is never passed on 2026-10-23 15:47:31 +02:00
Matthew Meszaros 31aadd0304 feat: run the dev seeder and the sandbox seed and simulator only when APP_ENV is explicitly dev, development or local, refusing an unset or production APP_ENV before anything is written, and document the guard on the first-run and sandbox pages 2026-10-23 15:46:52 +02:00
Matthew Meszaros e0a97ef520 feat: end other sessions before a signed-in password change is stored and refuse the change when that fails, add an optional revoke_api_credentials to the change and reset that also revokes the user's OAuth grants and the API keys they created, exchange the emailed reset link for an opaque reset session through POST /auth/reset-password/session so the confirm step carries no token in its URL, and add the sign-out-apps checkbox to the dashboard's change-password dialog 2026-10-23 15:45:51 +02:00