Commit Graph
3 Commits
Author SHA1 Message Date
Matthew Meszaros c8c4440b50 fix: confirm dialog z + theme, persist folders/tags across reload
User: "when I click on delete the confirm appears behind the form and
it looks really bad, doesn't fit in the theme; and also after I reload
the page, nothing appears after creation".

Two distinct bugs:

1) Confirm dialog stacking + styling
   FoldersModal/TagsModal render at z-[110]. ConfirmProvider rendered
   the confirm overlay at z-101 with bg-black/30 + scale animation +
   poppins styling — visually it landed BEHIND the folders modal and
   clicks went through to the backdrop instead.
   Rewrote ConfirmProvider in the brae chrome:
   - z-[200] so it stacks above page-level overlays AND nested
     dialogs.
   - Hairline-bordered card, 48px header (red alert tile + "Confirm"
     eyebrow), prose body, slate-900 footer (Cancel / red Confirm).
   - Escape closes; backdrop closes (both gated on !loading).
   - Spinner inside Confirm during the awaited action.

2) Created folders/tags disappeared after page reload
   POST /folders + /tags persisted to Postgres fine. The frontend
   optimistic-updated the cached user via setQueryData. But
   /auth/me did not return folders/tags/categories — the User payload
   omitted them entirely. On reload the cache refetched /auth/me,
   got missing fields, defaulted to [], and the items vanished from
   the UI.

   Backend fix:
   - models.User now carries Folders/Tags/Categories ([]Group),
     always serialized as arrays.
   - GroupRepository + GroupService gained a List(ctx, userID)
     method; ordered by position then created_at.
   - /auth/me handler now calls List on FolderService, TagService,
     CategoryService and attaches them to the user before responding.

Verified end-to-end:
  GET /auth/me → 200 with full folders/tags arrays populated.
  Create a folder, reload the page → folder still in the list.
2026-05-23 09:38:20 +00:00
Matthew Meszaros abf73d168b fix: dropdowns + folder/tag create (server-side + client-side)
Two real bugs surfaced from "All folders / Newest dropdowns don't open"
and "hex color must be a valid string":

1) Dropdowns silently no-op (broken across the whole dashboard)
   PopoverMenuTrigger asChild uses React.cloneElement to inject
   onClick / ref / aria-expanded onto the trigger child. SelectButton
   was a plain function component that destructured a fixed prop set
   and rendered its own <button> — so the injected props were
   dropped on the floor. Click did nothing.

   Fix: SelectButton is now React.forwardRef + spreads {...rest} onto
   the inner button. The injected click handler reaches the real
   element, the dropdown opens, the menu renders, and selection
   actually applies state.

   Every PopoverMenu trigger using SelectButton was affected — that's
   campaigns (folders + sort), emails (tag filter), contacts (sort +
   filters page rows). All now work.

2) Adding a folder/tag failed with "hex color must be a valid string"
   The /folders + /tags POST landed on groupRepository.Create with
   an empty color and the validator rejected. Even before the color
   check, the INSERT used tx.QueryRow + Scan against an INSERT with
   no RETURNING clause, which always errored with
   "sql: no rows in result set" once it got past validation.

   API improvements (kept the design but made it forgiving):
   - Color defaults: if the request omits color, the server picks one
     from an 8-swatch palette based on the new item's position. Two
     consecutive creates won't end up identical. Non-empty but
     invalid still 400s — that's a client bug worth surfacing.
   - Title min length 3 → 1. "Q1", "VIP", short names are common
     and shouldn't fail. Trimmed before validation so " " doesn't
     pass.
   - INSERT now uses tx.Exec instead of QueryRow.Scan — the broken
     code would never reach success even when validation passed.

   Verified end-to-end:
     POST /folders {"title":"Q1"} → 200, color=#94a3b8 (default).
     POST /folders {"title":"Q2","color":"#38bdf8"} → 200.
     POST /tags    {"title":"VIP","color":"#10b981"} → 200.

   Frontend:
   - createFolder / createTag clients accept an optional color param.
   - LabelListModal now picks a default palette color when entering
     add-row mode (rotating with item count) and offers a swatch
     popover to override before submitting. Selected color is sent to
     the backend.
2026-05-23 09:18:45 +00:00
Matthew Meszaros 772c19820d New Repository: Add Backend Code 2026-01-17 14:11:14 +00:00