From 0b3d74aa0b4abaf70b52d348bdafbeec9b8b951b Mon Sep 17 00:00:00 2001 From: Linus Rath <139418639+rathlinus@users.noreply.github.com> Date: Wed, 28 Oct 2026 04:30:32 +0100 Subject: [PATCH] fix: resume the version check when third-party traffic is allowed again #903 --- lib/version-check/sender.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/version-check/sender.ts b/lib/version-check/sender.ts index d2b692ae4..ec05be376 100644 --- a/lib/version-check/sender.ts +++ b/lib/version-check/sender.ts @@ -70,7 +70,10 @@ async function scheduleNext(delayMs: number): Promise { async function tick(): Promise { const result = await checkOnce({ reason: 'scheduled' }); - const delay = result.ok ? jitteredDelay(HOUR_MS) : FAILURE_BACKOFF_MS; + // The scheduler keeps running while third-party traffic is off, so turning + // the switch off at runtime resumes the checks; checkOnce skips meanwhile. + const skipped = result.error === NO_THIRD_PARTY_ERROR; + const delay = result.ok || skipped ? jitteredDelay(HOUR_MS) : FAILURE_BACKOFF_MS; await scheduleNext(delay); } @@ -80,10 +83,6 @@ export async function startScheduler(): Promise { logger.info('version-check: scheduler not started (disabled by env)'); return; } - if (await isNoThirdPartyTrafficOn()) { - logger.info('version-check: scheduler not started (no third-party traffic)'); - return; - } const state = await loadState(); if (!effectiveEndpoint(state)) { logger.info('version-check: scheduler not started (no endpoint)');