fix: cap admin sign-in attempts across all clients (GHSA-7pj2-232x-6698)

The admin login limit keys on the client IP taken from
X-Forwarded-For. With no reverse proxy in front, that header is
whatever the client sends (Next only fills it from the socket when the
request carries none), so each forged address got a fresh bucket of
five guesses. Route handlers cannot see the socket address, so the
limiter now also stops at 50 attempts per 15 minutes across all
clients. `.env.example` says why a proxy that appends the header is
still needed for trustworthy per-IP limits and audit addresses.
This commit is contained in:
Linus Rath
2026-09-26 15:07:09 +02:00
parent 8b3e29fe75
commit 32280b9cc1
3 changed files with 70 additions and 1 deletions
+22 -1
View File
@@ -1,17 +1,28 @@
/**
* In-memory rate limiter for admin login.
* Max 5 attempts per IP per 15 minutes.
* Max 5 attempts per IP per 15 minutes, and 50 across all clients.
*/
const MAX_ATTEMPTS = 5;
const WINDOW_MS = 15 * 60 * 1000; // 15 minutes
/**
* Ceiling across all clients. The per-IP key comes from X-Forwarded-For
* (getClientIP), which a client can write itself when the app is reachable
* without a reverse proxy in front: Next fills the header from the socket
* only when the request carries none. Rotating forged addresses would
* otherwise buy unlimited guesses. 50 per window still leaves room for a
* few admins mistyping at once.
*/
const GLOBAL_MAX_ATTEMPTS = 50;
interface RateLimitEntry {
count: number;
resetAt: number;
}
const attempts = new Map<string, RateLimitEntry>();
let globalAttempts: RateLimitEntry | null = null;
// Clean up expired entries periodically
setInterval(() => {
@@ -28,11 +39,20 @@ setInterval(() => {
*/
export function checkRateLimit(ip: string): { allowed: boolean; remaining: number; retryAfterMs: number } {
const now = Date.now();
if (!globalAttempts || globalAttempts.resetAt <= now) {
globalAttempts = { count: 0, resetAt: now + WINDOW_MS };
}
if (globalAttempts.count >= GLOBAL_MAX_ATTEMPTS) {
return { allowed: false, remaining: 0, retryAfterMs: globalAttempts.resetAt - now };
}
const entry = attempts.get(ip);
if (!entry || entry.resetAt <= now) {
// New window
attempts.set(ip, { count: 1, resetAt: now + WINDOW_MS });
globalAttempts.count++;
return { allowed: true, remaining: MAX_ATTEMPTS - 1, retryAfterMs: 0 };
}
@@ -41,5 +61,6 @@ export function checkRateLimit(ip: string): { allowed: boolean; remaining: numbe
}
entry.count++;
globalAttempts.count++;
return { allowed: true, remaining: MAX_ATTEMPTS - entry.count, retryAfterMs: 0 };
}