From 4e2affe406fdc92507d53f1e36cba03dc2cfc020 Mon Sep 17 00:00:00 2001 From: Linus Rath <139418639+rathlinus@users.noreply.github.com> Date: Thu, 29 Oct 2026 16:42:46 +0100 Subject: [PATCH] fix: name the remaining search boxes, filter fields and settings inputs that only had a placeholder --- app/(main)/admin/_pages/policy.tsx | 5 +++++ components/__tests__/form-labels.test.tsx | 12 ++++++++++++ components/calendar/event-detail-popover.tsx | 1 + components/contacts/contact-group-form.tsx | 2 ++ components/contacts/contact-list.tsx | 4 ++++ components/files/file-picker-dialog.tsx | 1 + components/filters/filter-rule-modal.tsx | 1 + components/layout/icon-picker.tsx | 1 + components/layout/mv-side-panel.tsx | 1 + components/mail/mail-app.tsx | 1 + .../settings/address-book-management-settings.tsx | 1 + components/settings/calendar-management-settings.tsx | 1 + components/settings/composing-settings.tsx | 1 + components/settings/downloads-settings.tsx | 1 + components/settings/folder-settings.tsx | 2 ++ components/settings/keyword-settings.tsx | 1 + components/settings/share-collection-dialog.tsx | 2 ++ components/settings/sidebar-apps-settings.tsx | 2 ++ components/templates/template-picker.tsx | 1 + components/ui/prompt-dialog.tsx | 1 + lib/__tests__/helpers/dom-accessibility-api.d.ts | 5 +++++ locales/ar/common.json | 3 ++- locales/ca/common.json | 3 ++- locales/cs/common.json | 3 ++- locales/da/common.json | 3 ++- locales/de/common.json | 3 ++- locales/en/common.json | 3 ++- locales/es/common.json | 3 ++- locales/et/common.json | 3 ++- locales/fa/common.json | 3 ++- locales/fr/common.json | 3 ++- locales/he/common.json | 3 ++- locales/hu/common.json | 3 ++- locales/it/common.json | 3 ++- locales/ja/common.json | 3 ++- locales/ko/common.json | 3 ++- locales/lv/common.json | 3 ++- locales/mn/common.json | 3 ++- locales/nb/common.json | 3 ++- locales/nl/common.json | 3 ++- locales/pl/common.json | 3 ++- locales/pt/common.json | 3 ++- locales/ro/common.json | 3 ++- locales/ru/common.json | 3 ++- locales/sk/common.json | 3 ++- locales/th/common.json | 3 ++- locales/tr/common.json | 3 ++- locales/uk/common.json | 3 ++- locales/zh-TW/common.json | 3 ++- locales/zh/common.json | 3 ++- 50 files changed, 105 insertions(+), 29 deletions(-) create mode 100644 lib/__tests__/helpers/dom-accessibility-api.d.ts diff --git a/app/(main)/admin/_pages/policy.tsx b/app/(main)/admin/_pages/policy.tsx index 8308403b5..0aca6bd8a 100644 --- a/app/(main)/admin/_pages/policy.tsx +++ b/app/(main)/admin/_pages/policy.tsx @@ -345,6 +345,7 @@ export function PolicyPage() {
Relay URL
tied to it or an aria-label, never just @@ -63,4 +65,14 @@ describe('form fields have labels', () => { expect(document.querySelectorAll('input').length).toBeGreaterThanOrEqual(8); expect(unnamedFields()).toEqual([]); }); + + it('contact group form', () => { + render(); + expect(unnamedFields()).toEqual([]); + }); + + it('the shared one-field prompt', () => { + render(); + expect(unnamedFields()).toEqual([]); + }); }); diff --git a/components/calendar/event-detail-popover.tsx b/components/calendar/event-detail-popover.tsx index d9b30d3ed..6c29019a2 100644 --- a/components/calendar/event-detail-popover.tsx +++ b/components/calendar/event-detail-popover.tsx @@ -644,6 +644,7 @@ export function EventDetailPopover({ {noteExpanded ? (