mirror of
https://github.com/bulwarkmail/webmail.git
synced 2026-10-31 16:13:15 +00:00
Linus Rath
f7d1a86b5e
Edits of a recurring meeting from one of its occurrences went wrong in several ways (live on 1.0 and 0.16.23, attendees included): - A "this and following" split whose new series could not be created stayed half done: the calendar store answers most failures with null, and only a thrown error put the old series back. The series stayed ended, told so to the attendees, and the save said it had worked. A null now puts the series back as well and fails the save. The rollback writes the old overrides back as a whole map: a pointer into a series without overrides fails, and the split may just have removed its only one. - "This occurrence" on the series itself (a meeting opened from a link or a search result) went out in one write that reached no attendee who had answered. It now takes the same two steps as an occurrence of an expanded series: the override as it is without messages, then the change of it. - The new series of a split started at the opened occurrence's own time and in the user's zone: Mondays in New York, one occurrence moved to Tuesday, renamed from there by a user in Berlin, became a Tuesday series in Berlin. It now goes on from that occurrence's recurrence id, in the series' zone, moved only by what the editor moved; the occurrence keeps its own time through its override. It takes the old series' details with what the user changed, not the opened occurrence's own ones. - "All events" from an occurrence with an override of its own wrote that occurrence's own title, copied into its override, back to the series: a new room there renamed the series. Only the fields the user changed go to the series now; the opened occurrence's override takes them too (on 1.0 also where it holds them as pointers), and other overrides where they only held the series' old value. - The move of an "all" edit was measured on the user's clock: across a week in which only one of the two zones changes to or from summer time, the series moved an hour more or less than picked. It is now measured on the series' own clock. - 0.16 (0.16.23 checked) reads a rule's UNTIL as the series' wall clock taken for UTC, so in a zone behind UTC a split or "delete this and following" kept the occurrence it was to end before. The UNTIL is now earlier by the zone's offset, which ends the series there on 0.16 and 1.0 alike. - An applied counter proposal for one occurrence of a recurring meeting went to the first event with its uid. It now goes to the occurrence the proposal names; one for a whole series of which only occurrences are in view is not applied to any of them.