mirror of
https://github.com/bulwarkmail/webmail.git
synced 2026-10-31 16:13:15 +00:00
KazNIISA IT
bed69db2e8
Renaming a tag changes its id - the id is a slug of the display name - and with it the `$label:` keyword the tag is stored under. The rename migrated the keyword on every message but left Sieve rules naming the old id, in both the generated `addflag` line and the metadata block the visual editor reads back. The rule then went on tagging new mail under an id no definition names any more: the tag renders as its raw id in grey and a search for the renamed tag misses everything that arrived since, which reads as the filter having quietly stopped working. `renameKeywordInRules` rewrites every `add_label` action naming the old id, disabled rules included. An external rule reaches the script through its verbatim `rawBlock`, so that is rewritten too - but only the operand of an `addflag`, since a test comparing a header against the same literal is the rule's own logic rather than the tag it applies. The store fetches, rewrites and uploads the account's active script on its own rather than through fetchFilters/saveFilters, so a rename from the tag settings cannot disturb which account an open filter view is showing; that view is updated in place when it shows the same account. The write still runs through the same plugin pipeline a save does, or a plugin's managed section would be dropped from the script this activates. A script that is not the active one is left alone entirely: writing to it would activate it, and a tag rename must not switch someone's filters back on. Whatever still names the old tag in the script that ends up being written - a rule kept verbatim, a test comparing against the keyword, a section a plugin just grafted back on - is counted, and the tag settings warn that some rules still use the old tag, because only the user can fix those. Mail delivered between the message migration and the rewrite was still tagged by the old rule, so a successful rewrite is followed by one more migration sweep, which no rewritten rule can race any more.