From 00ec2c3e587eee367ac57aa9aa618e7a703e3c34 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Wed, 10 Jun 2026 16:45:24 +0000
Subject: [PATCH] fix: treat DROP TABLE as table-level write in sql asset
 parser

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 .../src/asset_parser.rs                       | 68 +++++++++++++++++++
 1 file changed, 68 insertions(+)

diff --git a/backend/parsers/windmill-parser-sql-asset/src/asset_parser.rs b/backend/parsers/windmill-parser-sql-asset/src/asset_parser.rs
index 38990bd495..c157d7d2d0 100644
--- a/backend/parsers/windmill-parser-sql-asset/src/asset_parser.rs
+++ b/backend/parsers/windmill-parser-sql-asset/src/asset_parser.rs
@@ -658,6 +658,26 @@ impl Visitor for AssetCollector {
                 self.track_table_definition(name);
             }
 
+            // DROP TABLE/VIEW is a write to the dropped object — the
+            // canonical idempotent-refresh pattern (`DROP TABLE IF EXISTS x;
+            // CREATE TABLE x AS …`) must resolve to a table-level write.
+            // Without this arm, a tagged-template snippet containing only the
+            // DROP yields no table-level asset and the TS/Python SDK parsers
+            // fall back to a db-level `datatable://<db>` reference, putting a
+            // stray database node on the pipeline canvas.
+            sqlparser::ast::Statement::Drop { object_type, names, .. } => {
+                if matches!(
+                    object_type,
+                    sqlparser::ast::ObjectType::Table
+                        | sqlparser::ast::ObjectType::View
+                        | sqlparser::ast::ObjectType::MaterializedView
+                ) {
+                    for name in names {
+                        self.track_table_definition(name);
+                    }
+                }
+            }
+
             sqlparser::ast::Statement::Copy { target: CopyTarget::File { filename }, .. } => {
                 self.current_access_type_stack.push(W);
                 self.handle_string_literal(filename);
@@ -931,6 +951,54 @@ mod tests {
         );
     }
 
+    #[test]
+    fn test_sql_asset_parser_drop_table_is_write() {
+        // A lone DROP (e.g. one SDK tagged-template snippet of an
+        // idempotent-refresh script) must resolve to a table-level write,
+        // not fall through to nothing.
+        let input = r#"
+            ATTACH 'datatable://main' AS dt; USE dt;
+            DROP TABLE IF EXISTS orders_raw;
+        "#;
+        let s = parse_assets(input).map(|s| s.assets);
+        assert_eq!(
+            s.map_err(|e| e.to_string()),
+            Ok(vec![ParseAssetsResult {
+                kind: AssetKind::DataTable,
+                path: "main/orders_raw".to_string(),
+                access_type: Some(W),
+                columns: None
+            },])
+        );
+    }
+
+    #[test]
+    fn test_sql_asset_parser_drop_then_create_qualified() {
+        // Canonical refresh pattern over an attached catalog: DROP + CREATE
+        // AS on the output, SELECT on the input.
+        let input = r#"
+            ATTACH 'datatable://main' AS pg;
+            DROP TABLE IF EXISTS pg.daily_revenue;
+            CREATE TABLE pg.daily_revenue AS SELECT * FROM pg.orders_clean;
+        "#;
+        let s = parse_assets(input).map(|mut s| {
+            s.assets.sort_by(|a, b| a.path.cmp(&b.path));
+            s.assets
+        });
+        // NB: the SELECT inside CREATE TABLE … AS is not walked for reads
+        // (pre-existing behavior — CreateTable only tracks the definition
+        // name); this test pins the DROP+CTAS combo to a single clean write.
+        assert_eq!(
+            s.map_err(|e| e.to_string()),
+            Ok(vec![ParseAssetsResult {
+                kind: AssetKind::DataTable,
+                path: "main/daily_revenue".to_string(),
+                access_type: Some(W),
+                columns: None
+            },])
+        );
+    }
+
     // Make sure a_function is not detected as main/a_function
     #[test]
     fn test_sql_asset_parser_function_table() {